Skip to contentSkip to conversation

dt-bindings: watchdog: ti,rti-wdt: Fix assigned-clock-parents

PATCH In review Rob Herring 3 participants 3 messages Dec 6, 2021 – Dec 7, 2021

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: watchdog: ti,rti-wdt: Fix assigned-clock-parents

With 'unevaluatedProperties' support implemented, the ti,rti-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.example.dt.yaml: watchdog@2200000: Unevaluated properties are not allowed ('assigned-clock-parents' was unexpected)

The problem is the schema has a typo in 'assigned-clocks-parents'. As it is not required to list assigned clocks in bindings, just drop the property definitions to fix this.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Tero Kristo <[email protected]>
---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 6 ------
 1 file changed, 6 deletions(-)
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml +0 -6
index 054584d7543a..2f33635876ff 100644
@@ -34,12 +34,6 @@ properties:
   power-domains:
     maxItems: 1
 
-  assigned-clocks:
-    maxItems: 1
-
-  assigned-clocks-parents:
-    maxItems: 1
-
 required:
   - compatible
   - reg
Signature · 1 line
2.32.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the ti,rti-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.example.dt.yaml: watchdog@2200000: Unevaluated properties are not allowed ('assigned-clock-parents' was unexpected)

The problem is the schema has a typo in 'assigned-clocks-parents'. As it is not required to list assigned clocks in bindings, just drop the property definitions to fix this.

Quoted 5 lines
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Tero Kristo <[email protected]>

... assuming you want to carry this and the following patch through your tree. If not, please let me know.

Thanks,
Guenter

Quoted 24 lines
---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 6 ------
 1 file changed, 6 deletions(-)
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml +0 -6
index 054584d7543a..2f33635876ff 100644
@@ -34,12 +34,6 @@ properties:
   power-domains:
     maxItems: 1
 
-  assigned-clocks:
-    maxItems: 1
-
-  assigned-clocks-parents:
-    maxItems: 1
-
 required:
   - compatible
   - reg
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the ti,rti-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.example.dt.yaml: watchdog@2200000: Unevaluated properties are not allowed ('assigned-clock-parents' was unexpected)

The problem is the schema has a typo in 'assigned-clocks-parents'. As it is not required to list assigned clocks in bindings, just drop the property definitions to fix this.

Quoted 8 lines
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Tero Kristo <[email protected]>
---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 6 ------
 1 file changed, 6 deletions(-)