Skip to contentSkip to conversation

dt-bindings: watchdog: atmel: Add missing 'interrupts' property

PATCH In review Rob Herring 4 participants 4 messages Dec 6, 2021 – Dec 7, 2021

Subsystems (3)
Device tree bindings Arm/Microchip (AT91) SoC support Watchdog device drivers
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: watchdog: atmel: Add missing 'interrupts' property

With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)

Document the missing 'interrupts' property.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Eugen Hristev <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +3 -0
index 9856cd76c28d..a9635c03761c 100644
@@ -22,6 +22,9 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 1
+
   atmel,watchdog-type:
     $ref: /schemas/types.yaml#/definitions/string
     description: should be hardware or software.
Signature · 1 line
2.32.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)

Document the missing 'interrupts' property.

Quoted 9 lines
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Eugen Hristev <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Acked-by Guenter Roeck <[email protected]>
Quoted 21 lines
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +3 -0
index 9856cd76c28d..a9635c03761c 100644
@@ -22,6 +22,9 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 1
+
   atmel,watchdog-type:
     $ref: /schemas/types.yaml#/definitions/string
     description: should be hardware or software.
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 16 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)

Document the missing 'interrupts' property.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Eugen Hristev <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)
Reviewed-by Thierry Reding <[email protected]>
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt example has the following warning:

/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@fc068640: Unevaluated properties are not allowed ('interrupts' was unexpected)

Document the missing 'interrupts' property.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Nicolas Ferre <[email protected]>
Acked-by Nicolas Ferre <[email protected]>

Thanks for the fix Rob!
Best regards,
Nicolas

Quoted 27 lines
Cc Alexandre Belloni <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Eugen Hristev <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
  .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
  1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +3 -1
index 9856cd76c28d..a9635c03761c 100644
@@ -22,6 +22,9 @@ properties:
    reg:
      maxItems: 1
 
+  interrupts:
+    maxItems: 1
+
    atmel,watchdog-type:
      $ref: /schemas/types.yaml#/definitions/string
      description: should be hardware or software.
--

2.32.0

Signature · 1 line
Nicolas Ferre