Skip to contentSkip to conversation

dt-bindings: dma: ti: Add missing ti,k3-sci-common.yaml reference

PATCH Applied Rob Herring 3 participants 5 messages Dec 6, 2021 – Dec 13, 2021

Subsystems (3)
Device tree bindings dmaengine Texas Instruments DMA drivers
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: dma: ti: Add missing ti,k3-sci-common.yaml reference

The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id' properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties' support is enabled, a the follow warning is generated:

Documentation/devicetree/bindings/dma/ti/k3-bcdma.example.dt.yaml: dma-controller@485c0100: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected) Documentation/devicetree/bindings/dma/ti/k3-pktdma.example.dt.yaml: dma-controller@485c0000: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)

Add a reference to ti,k3-sci-common.yaml to fix this.

Cc Peter Ujfalusi <[email protected]>
Cc Vinod Koul <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml  | 1 +
 Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml +1 -0
index df29d59d13a8..08627d91e607 100644
@@ -30,6 +30,7 @@ description: |
 
 allOf:
   - $ref: /schemas/dma/dma-controller.yaml#
+  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
 
 properties:
   compatible:
Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml +1 -0
index ea19d12a9337..507d16d84ade 100644
@@ -25,6 +25,7 @@ description: |
 
 allOf:
   - $ref: /schemas/dma/dma-controller.yaml#
+  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
 
 properties:
   compatible:
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Rob Herring

The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id' properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties' support is enabled, a the follow warning is generated:

s/a the following/the following/

Otherwise looks good:

Reviewed-by Thierry Reding <[email protected]>

One question below...

Quoted 20 lines

Documentation/devicetree/bindings/dma/ti/k3-bcdma.example.dt.yaml: dma-controller@485c0100: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected) Documentation/devicetree/bindings/dma/ti/k3-pktdma.example.dt.yaml: dma-controller@485c0000: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)

Add a reference to ti,k3-sci-common.yaml to fix this.

Cc Peter Ujfalusi <[email protected]>
Cc Vinod Koul <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml  | 1 +
 Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml +0 -0
index df29d59d13a8..08627d91e607 100644

Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml description: | · line 33

Quoted 4 lines
Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml +1 -0
@@ -30,6 +30,7 @@ description: |
 
 allOf:
   - $ref: /schemas/dma/dma-controller.yaml#
+  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#

Out of curiosity: is the # at the end necessary, or do you just use it as a convention? I've seen a mix of both and there also seems to be a healthy mix of quoted and unquoted paths. Do we want to settle on one going forward or do we not care enough?

Thierry

author maintainer
#2 lore raw
Quoted 11 lines · Thierry Reding
Quoted 3 lines · Rob Herring

The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id' properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties' support is enabled, a the follow warning is generated:

s/a the following/the following/

Otherwise looks good:

Reviewed-by Thierry Reding <[email protected]>

Thanks.

Quoted 24 lines

One question below...

Quoted 21 lines

Documentation/devicetree/bindings/dma/ti/k3-bcdma.example.dt.yaml: dma-controller@485c0100: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected) Documentation/devicetree/bindings/dma/ti/k3-pktdma.example.dt.yaml: dma-controller@485c0000: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)

Add a reference to ti,k3-sci-common.yaml to fix this.

Cc Peter Ujfalusi <[email protected]>
Cc Vinod Koul <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml  | 1 +
 Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml +0 -0
index df29d59d13a8..08627d91e607 100644
@@ -30,6 +30,7 @@ description: |
Quoted 6 lines

Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml description: | · line 33

Quoted 3 lines
Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml +1 -0
 allOf:
   - $ref: /schemas/dma/dma-controller.yaml#
+  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#

Out of curiosity: is the # at the end necessary, or do you just use it as a convention?

It is at least convention. The jsonschema module doesn't require it, but not sure what the spec says.

Quoted 3 lines

I've seen a mix of both and there also seems to be a healthy mix of quoted and unquoted paths. Do we want to settle on one going forward or do we not care enough?

I don't really want to dictate one way if it can't automatically be checked. The '#' could be checked easily, but quoting is harder. There is some tool support for checking quotes actually, but you have to enable the yaml round trip loader which is noticeably slower. yamllint might be the better place to add it though getting yaml quoting rules right in the general case is a bit harder. Also, to enforce it, I have to first go fix all the existing cases.

Rob

maintainer
#3 lore raw
In reply to Thierry Reding
Quoted 8 lines · Thierry Reding
Quoted 3 lines · Rob Herring

The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id' properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties' support is enabled, a the follow warning is generated:

s/a the following/the following/

Otherwise looks good:

Fixed up while applying..

Signature · 1 line
~Vinod
maintainer Applied
#4 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id' properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties' support is enabled, a the follow warning is generated:

Documentation/devicetree/bindings/dma/ti/k3-bcdma.example.dt.yaml: dma-controller@485c0100: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected) Documentation/devicetree/bindings/dma/ti/k3-pktdma.example.dt.yaml: dma-controller@485c0000: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)

Add a reference to ti,k3-sci-common.yaml to fix this.

Applied, thanks

Signature · 1 line
~Vinod