Skip to contentSkip to conversation

unit: add asserts to unitset test

PATCH Applied James Prestwood 2 participants 2 messages Dec 7, 2021

lore
Share & tools
lore

James Prestwood

author
#0 lore raw

PATCH 1/1 unit: add asserts to unitset test

To satisfy static analysis add a few more return checks

---
 unit/test-uintset.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
unit/test-uintset.c +5 -5
index 0918ef2..31dc274 100644
@@ -370,18 +370,18 @@ static void test_uintset_size(const void *user_data)
 
 	assert(l_uintset_size(set) == 0);
 
-	for (i = 0; i < 32; i++) {
-		l_uintset_put(set, i);
+	for (i = 1; i < 32; i++) {
+		assert(l_uintset_put(set, i));
 		assert(l_uintset_size(set) == i);
 	}
 
 	assert(l_uintset_size(set) == i - 1);
 
-	l_uintset_take(set, 10);
+	assert(l_uintset_take(set, 10));
 	assert(l_uintset_size(set) == i - 2);
 
-	for (i = 0; i < 32; i++)
-		l_uintset_take(set, i);
+	for (i = 1; i < 32; i++)
+		assert(l_uintset_take(set, i));
 
 	assert(l_uintset_size(set) == 0);
 }
Signature · 1 line
2.31.1
Applied
#1 lore raw

Hi James,

Quoted 5 lines · James Prestwood

To satisfy static analysis add a few more return checks

---
  unit/test-uintset.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

Regards,
-Denis