ARM: tegra: Drop reg-shift for Tegra HS UART
Subsystems (2)
PATCH 1/1 ARM: tegra: Drop reg-shift for Tegra HS UART
From: Thierry Reding <[email protected]>
When the Tegra High-Speed UART is used instead of the regular UART, the reg-shift property is implied from the compatible string and should not be explicitly listed.
--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++ arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++ arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++ arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++ 4 files changed, 9 insertions(+)
arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +3 -0
@@ -1539,14 +1539,17 @@ sdmmc3-clk-lb-out-pee4 { /* NC */ serial@70006040 { compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; }; serial@70006200 { compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; }; serial@70006300 { compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; }; hdmi_ddc: i2c@7000c700 {
arch/arm/boot/dts/tegra124-jetson-tk1.dts +2 -0
@@ -1389,6 +1389,7 @@ dsi_b { */ serial@70006000 { compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; status = "okay"; };
@@ -1401,6 +1402,7 @@ serial@70006000 { */ serial@70006040 { compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; status = "okay"; };
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +2 -0
@@ -804,11 +804,13 @@ drive_gma { uartb: serial@70006040 { compatible = "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; /* GPS BCM4751 */ }; uartc: serial@70006200 { compatible = "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; status = "okay"; nvidia,adjust-baud-rates = <0 9600 100>,
arch/arm/boot/dts/tegra30-colibri.dtsi +2 -0
@@ -701,10 +701,12 @@ pv0 { serial@70006040 { compatible = "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; }; serial@70006300 { compatible = "nvidia,tegra30-hsuart"; + /delete-property/ reg-shift; }; hdmi_ddc: i2c@7000c700 {
Signature · 1 line
2.33.1
07.12.2021 13:13, Thierry Reding пишет:
Quoted 6 lines
From: Thierry Reding <[email protected]>
When the Tegra High-Speed UART is used instead of the regular UART, the reg-shift property is implied from the compatible string and should not be explicitly listed.
Quoted 7 lines
Signed-off-by Thierry Reding <[email protected]>--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++ arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++ arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++ arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++ 4 files changed, 9 insertions(+)
What about Ouya?
07.12.2021 17:19, Dmitry Osipenko пишет:
Quoted 15 lines
07.12.2021 13:13, Thierry Reding пишет:
Quoted 6 lines
From: Thierry Reding <[email protected]>
When the Tegra High-Speed UART is used instead of the regular UART, the reg-shift property is implied from the compatible string and should not be explicitly listed.
Quoted 7 lines
Signed-off-by Thierry Reding <[email protected]>--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++ arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++ arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++ arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++ 4 files changed, 9 insertions(+)
Quoted 2 lines
What about Ouya?
What about T20?
Quoted 16 lines · Dmitry Osipenko
07.12.2021 17:19, Dmitry Osipenko пишет:
Quoted 15 lines
07.12.2021 13:13, Thierry Reding пишет:
Quoted 13 lines
From: Thierry Reding <[email protected]>
When the Tegra High-Speed UART is used instead of the regular UART, the reg-shift property is implied from the compatible string and should not be explicitly listed.
Signed-off-by Thierry Reding <[email protected]>--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++ arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++ arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++ arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++ 4 files changed, 9 insertions(+)
Quoted 4 lines
Quoted 2 lines
What about Ouya?
What about T20?
I went through all of the above based on results from a dtbs_check run. I don't see these errors flagged for Ouya or any Tegra20 boards. I have no idea why and will need to look into it some more.
Thierry
08.12.2021 17:59, Thierry Reding пишет:
Quoted 17 lines · Dmitry Osipenko
Quoted 16 lines
07.12.2021 17:19, Dmitry Osipenko пишет:
Quoted 15 lines
07.12.2021 13:13, Thierry Reding пишет:
Quoted 13 lines
From: Thierry Reding <[email protected]>
When the Tegra High-Speed UART is used instead of the regular UART, the reg-shift property is implied from the compatible string and should not be explicitly listed.
Signed-off-by Thierry Reding <[email protected]>--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++ arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++ arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++ arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++ 4 files changed, 9 insertions(+)
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
What about Ouya?
What about T20?
I went through all of the above based on results from a
dtbs_checkrun. I don't see these errors flagged for Ouya or any Tegra20 boards. I have no idea why and will need to look into it some more.
Alright, something is wrong then. The serial@70006200 node on Ouya is exactly the same as on Nexus7, T20 Acer A500 is almost the same.
Quoted 21 lines · Dmitry Osipenko
08.12.2021 17:59, Thierry Reding пишет:
Quoted 20 lines · Dmitry Osipenko
Quoted 19 lines
07.12.2021 17:19, Dmitry Osipenko пишет:
Quoted 17 lines
07.12.2021 13:13, Thierry Reding пишет:
Quoted 6 lines
From: Thierry Reding <[email protected]>
When the Tegra High-Speed UART is used instead of the regular UART, the reg-shift property is implied from the compatible string and should not be explicitly listed.
Quoted 7 lines
Signed-off-by Thierry Reding <[email protected]>--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++ arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++ arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++ arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++ 4 files changed, 9 insertions(+)What about Ouya?
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
What about T20?
I went through all of the above based on results from a
dtbs_checkrun. I don't see these errors flagged for Ouya or any Tegra20 boards. I have no idea why and will need to look into it some more.Alright, something is wrong then. The serial@70006200 node on Ouya is exactly the same as on Nexus7, T20 Acer A500 is almost the same.
Indeed, looks like I no longer get any reg-shift related warnings even if I revert this patch in my tree. I don't immediately see why that would be. The reg-shift property is definitely not defined by either the HSUART bindings or anywhere that it references.
Rob, any idea where this might be coming from? Doesn't look like reg-shift is defined anywhere in the core schema either. Is this perhaps some fallout from the additionalProperties: true fixup? Perhaps that's not applied correctly in all cases?
Thierry