debian: Resend .gitcensus change
v2 cover debian: Resend .gitcensus change
This is a resend with the Reviewed-by tag collected.
I guess this was not integrated because the first version had one more patchcthat ended being replaced by a different patch.
Changelog:
v2: Drop 2nd patch that was reworked by Darrick.
Bastian Germann (1):
debian: Generate .gitcensus instead of .census (Closes: #999743)
debian/rules | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/1 debian: Generate .gitcensus instead of .census (Closes: #999743)
Fix the Debian build outside a git tree (e.g., Debian archive builds) by creating an empty .gitcensus instead of .census file on config.
--- debian/rules | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
debian/rules +4 -4
@@ -43,15 +43,15 @@ built: dibuild config $(MAKE) $(PMAKEFLAGS) default touch built -config: .census -.census: +config: .gitcensus +.gitcensus: @echo "== dpkg-buildpackage: configure" 1>&2 $(checkdir) AUTOHEADER=/bin/true dh_autoreconf dh_update_autotools_config $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h cp -f include/install-sh . - touch .census + touch .gitcensus dibuild: $(checkdir)
@@ -72,7 +72,7 @@ dibuild: clean: @echo "== dpkg-buildpackage: clean" 1>&2 $(checkdir) - -rm -f built .census mkfs/mkfs.xfs-$(bootpkg) + -rm -f built .gitcensus mkfs/mkfs.xfs-$(bootpkg) $(MAKE) distclean -rm -rf $(dirme) $(dirdev) $(dirdi) -rm -f debian/*substvars debian/files* debian/*.debhelper
Signature · 1 line
2.34.1
Re: [PATCH v2 1/1] debian: Generate .gitcensus instead of .census (Closes: #999743)
Hey,
I want to remind you of this patch before releasing xfsprogs 5.15.0.
Thanks,
Bastian
Am 07.12.21 um 13:21 schrieb Bastian Germann:
Quoted 41 lines
Fix the Debian build outside a git tree (e.g., Debian archive builds) by creating an empty .gitcensus instead of .census file on config.
Signed-off-by Bastian Germann <[email protected]>Reviewed-by Darrick J. Wong <[email protected]>--- debian/rules | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)debian/rules +4
-4@@ -43,15 +43,15 @@ built: dibuild config $(MAKE) $(PMAKEFLAGS) default touch built -config: .census -.census: +config: .gitcensus +.gitcensus: @echo "== dpkg-buildpackage: configure" 1>&2 $(checkdir) AUTOHEADER=/bin/true dh_autoreconf dh_update_autotools_config $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h cp -f include/install-sh . - touch .census + touch .gitcensus dibuild: $(checkdir)@@ -72,7 +72,7 @@ dibuild: clean: @echo "== dpkg-buildpackage: clean" 1>&2 $(checkdir) - -rm -f built .census mkfs/mkfs.xfs-$(bootpkg) + -rm -f built .gitcensus mkfs/mkfs.xfs-$(bootpkg) $(MAKE) distclean -rm -rf $(dirme) $(dirdev) $(dirdi) -rm -f debian/*substvars debian/files* debian/*.debhelper
Re: [PATCH v2 1/1] debian: Generate .gitcensus instead of .census (Closes: #999743)
In reply to Bastian GermannHi!
Am 07.12.21 um 13:21 schrieb Bastian Germann:
Quoted 5 lines
Fix the Debian build outside a git tree (e.g., Debian archive builds) by creating an empty .gitcensus instead of .census file on config.
Signed-off-by Bastian Germann <[email protected]>Reviewed-by Darrick J. Wong <[email protected]>
2nd friendly ping on this.
For the last few Debian releases, I applied this.
Quoted 36 lines
--- debian/rules | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)debian/rules +4
-4@@ -43,15 +43,15 @@ built: dibuild config $(MAKE) $(PMAKEFLAGS) default touch built -config: .census -.census: +config: .gitcensus +.gitcensus: @echo "== dpkg-buildpackage: configure" 1>&2 $(checkdir) AUTOHEADER=/bin/true dh_autoreconf dh_update_autotools_config $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h cp -f include/install-sh . - touch .census + touch .gitcensus dibuild: $(checkdir)@@ -72,7 +72,7 @@ dibuild: clean: @echo "== dpkg-buildpackage: clean" 1>&2 $(checkdir) - -rm -f built .census mkfs/mkfs.xfs-$(bootpkg) + -rm -f built .gitcensus mkfs/mkfs.xfs-$(bootpkg) $(MAKE) distclean -rm -rf $(dirme) $(dirdev) $(dirdi) -rm -f debian/*substvars debian/files* debian/*.debhelper
Re: [PATCH v2 1/1] debian: Generate .gitcensus instead of .census (Closes: #999743)
Quoted 11 lines · Bastian Germann
Hi!
Am 07.12.21 um 13:21 schrieb Bastian Germann:
Quoted 5 lines
Fix the Debian build outside a git tree (e.g., Debian archive builds) by creating an empty .gitcensus instead of .census file on config.
Signed-off-by Bastian Germann <[email protected]>Reviewed-by Darrick J. Wong <[email protected]>2nd friendly ping on this.
For the last few Debian releases, I applied this.
Very sorry for the delay. Does this need magic in debian/changelog to auto-close the bug?
I have the change itself staged for 5.16.0 now.
-Eric
Re: [PATCH v2 1/1] debian: Generate .gitcensus instead of .census (Closes: #999743)
Am 03.05.22 um 01:25 schrieb Eric Sandeen:
Quoted 7 lines · Bastian Germann
Quoted 6 lines
Hi!
Am 07.12.21 um 13:21 schrieb Bastian Germann:
Quoted 3 lines
Fix the Debian build outside a git tree (e.g., Debian archive builds) by creating an empty .gitcensus instead of .census file on config.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Bastian Germann <[email protected]>Reviewed-by Darrick J. Wong <[email protected]>2nd friendly ping on this.
For the last few Debian releases, I applied this.Very sorry for the delay. Does this need magic in debian/changelog to auto-close the bug?
When the "Closes: #999743" is contained in the changelog, it triggers an auto-close. But I can also close it manually.
Thanks!