Skip to contentSkip to conversation

ARM: tegra: Add compatible string for built-in ASIX on Colibri boards

PATCH In review Thierry Reding 2 participants 2 messages Dec 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: Add compatible string for built-in ASIX on Colibri boards

From: Thierry Reding <[email protected]>

The device tree node for the built-in ASIX Ethernet device on Colibri boards needs a compatible string in order to pass DT schema validation. Add the USB VID,PID compatible string as required by the DT schema for USB devices.

---
Marcel, Philippe, I've used the USB vendor and device IDs from the ASIX driver match entry for the AX88772B module, but do you have a quick way of verifying that that's indeed the ID that the device reports in those systems?

Rob, I do get a checkpatch.pl warning for this new compatible string, but I'm not sure there's anything easy that could be done about this, other than perhaps making checkpatch.pl aware of the special USB (and potentially PCI) compatible strings as well.

---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 1 +
 arch/arm/boot/dts/tegra30-colibri.dtsi | 1 +
 2 files changed, 2 insertions(+)
arch/arm/boot/dts/tegra20-colibri.dtsi +1 -0
index 2350fda3be6a..c5c401edd0bf 100644
@@ -689,6 +689,7 @@ usb@c5004000 {
 		#size-cells = <0>;
 
 		asix@1 {
+			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
 		};
arch/arm/boot/dts/tegra30-colibri.dtsi +1 -0
index e89b4e5a238d..4361b93d0934 100644
@@ -950,6 +950,7 @@ usb@7d004000 {
 		#size-cells = <0>;
 
 		asix@1 {
+			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
 		};
Signature · 1 line
2.33.1
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The device tree node for the built-in ASIX Ethernet device on Colibri boards needs a compatible string in order to pass DT schema validation. Add the USB VID,PID compatible string as required by the DT schema for USB devices.

Quoted 5 lines

---
Marcel, Philippe, I've used the USB vendor and device IDs from the ASIX driver match entry for the AX88772B module, but do you have a quick way of verifying that that's indeed the ID that the device reports in those systems?

Yes, that looks fine:

root@colibri-t30:~# uname -a
Linux colibri-t30 5.16.0-rc4-next-20211207-00025-g122da7b0a9d4 #2 SMP PREEMPT Tue Dec 7 16:54:46 CET 2021
armv7l GNU/Linux
root@colibri-t30:~# lsusb
Bus 003 Device 002: ID 0424:2514 Standard Microsystems Corp. USB 2.0 Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 002: ID 0b95:772b ASIX Electronics Corp. AX88772B
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

Thanks, Thierry!

Quoted 33 lines

Rob, I do get a checkpatch.pl warning for this new compatible string, but I'm not sure there's anything easy that could be done about this, other than perhaps making checkpatch.pl aware of the special USB (and potentially PCI) compatible strings as well.
---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 1 + arch/arm/boot/dts/tegra30-colibri.dtsi | 1 +

 2 files changed, 2 insertions(+)
arch/arm/boot/dts/tegra20-colibri.dtsi +0 -0
index 2350fda3be6a..c5c401edd0bf 100644
@@ -689,6 +689,7 @@ usb@c5004000 {
                 #size-cells = <0>;


                asix@1 {
+                       compatible = "usbb95,772b"; reg = <1>;
                        local-mac-address = [00 00 00 00 00 00]; };

arch/arm/boot/dts/tegra30-colibri.dtsi +0 -0
index e89b4e5a238d..4361b93d0934 100644
@@ -950,6 +950,7 @@ usb@7d004000 {
                 #size-cells = <0>;


                asix@1 {
+                       compatible = "usbb95,772b"; reg = <1>;
                        local-mac-address = [00 00 00 00 00 00]; };