Skip to contentSkip to conversation

intel_th: remove redundant re-assignment of pointer hubdrv

PATCH In review Colin Ian King 2 participants 2 messages Dec 7, 2021 – Dec 8, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 intel_th: remove redundant re-assignment of pointer hubdrv

The pointer hubdrv is being re-assigned the same value as it was initialized with only a few lines earlier. The re-assignment is redundant and can be removed.

As Dan Carpenter pointed out, the pointer hubdrv is hub - some_offset and in this case some_offset is zero. Since hub has already been dereferenced hubdrv can't be NULL so the NULL check is redundant and can also be removed.

---

V2: Remove null check, kudos to Dan Carpenter for spotting this.

---
 drivers/hwtracing/intel_th/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/hwtracing/intel_th/core.c +1 -2
index 7e753a75d23b..bf4ee2a31006 100644
@@ -1048,8 +1048,7 @@ int intel_th_set_output(struct intel_th_device *thdev,
 	 * hub is instantiated together with the source device that
 	 * calls here, so guaranteed to be present.
 	 */
-	hubdrv = to_intel_th_driver(hub->dev.driver);
-	if (!hubdrv || !try_module_get(hubdrv->driver.owner))
+	if (!try_module_get(hubdrv->driver.owner))
 		return -EINVAL;
 
 	if (!hubdrv->set_output) {
Signature · 1 line
2.33.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Colin Ian King

The pointer hubdrv is being re-assigned the same value as it was initialized with only a few lines earlier. The re-assignment is redundant and can be removed.

Quoted 8 lines

As Dan Carpenter pointed out, the pointer hubdrv is hub - some_offset and in this case some_offset is zero. Since hub has already been dereferenced hubdrv can't be NULL so the NULL check is redundant and can also be removed.

---

Thanks!

regards,
dan carpenter