Skip to contentSkip to conversation

libata: add horkage for ASMedia 1092

PATCH Applied Hannes Reinecke 3 participants 4 messages Dec 8, 2021 – Dec 9, 2021 libata

lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 1/1 libata: add horkage for ASMedia 1092

The ASMedia 1092 has a configuration mode which will present a dummy device; sadly the implementation falsely claims to provide a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.

Signed-off-by Hannes Reinecke <[email protected]>
---
 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ata/libata-core.c +2 -0
index 9c05177e09c2..f1a2f0a4ce05 100644
@@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
 	/* Odd clown on sil3726/4726 PMPs */
 	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
+	/* Similar story with ASMedia 1092 */
+	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
 
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },
Signature · 1 line
2.29.2
#1 lore raw
Quoted 16 lines · Hannes Reinecke

The ASMedia 1092 has a configuration mode which will present a dummy device; sadly the implementation falsely claims to provide a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.

Signed-off-by Hannes Reinecke <[email protected]>
---
 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ata/libata-core.c +0 -0
index 9c05177e09c2..f1a2f0a4ce05 100644

drivers/ata/libata-core.c static const struct ata_blacklist_entry ata_device_blacklist [] = { · line 4423

Quoted 8 lines
drivers/ata/libata-core.c +2 -0
@@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
 	/* Odd clown on sil3726/4726 PMPs */
 	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
+	/* Similar story with ASMedia 1092 */
+	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
 
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },

Doesn't this need a Cc stable ? I can add it.

Signature · 2 lines
Damien Le Moal
Western Digital Research
author
#2 lore raw
Quoted 22 lines · Damien Le Moal
Quoted 21 lines · Hannes Reinecke

The ASMedia 1092 has a configuration mode which will present a dummy device; sadly the implementation falsely claims to provide a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.

Signed-off-by Hannes Reinecke <[email protected]>
---
 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ata/libata-core.c +2 -0
index 9c05177e09c2..f1a2f0a4ce05 100644
@@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
 	/* Odd clown on sil3726/4726 PMPs */
 	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
+	/* Similar story with ASMedia 1092 */
+	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
Quoted 6 lines

drivers/ata/libata-core.c static const struct ata_blacklist_entry ata_device_blacklist [] = { · line 4423

Quoted 3 lines
drivers/ata/libata-core.c +0 -0
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },

Doesn't this need a Cc stable ? I can add it.

Possibly; device has never worked properly.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		           Kernel Storage Architect
[email protected]			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
Applied
#3 lore raw
In reply to Hannes Reinecke
Quoted 16 lines · Hannes Reinecke

The ASMedia 1092 has a configuration mode which will present a dummy device; sadly the implementation falsely claims to provide a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.

Signed-off-by Hannes Reinecke <[email protected]>
---
 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ata/libata-core.c +0 -0
index 9c05177e09c2..f1a2f0a4ce05 100644

drivers/ata/libata-core.c static const struct ata_blacklist_entry ata_device_blacklist [] = { · line 4423

Quoted 8 lines
drivers/ata/libata-core.c +2 -0
@@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "VRFDFC22048UCHC-TE*", NULL,		ATA_HORKAGE_NODMA },
 	/* Odd clown on sil3726/4726 PMPs */
 	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },
+	/* Similar story with ASMedia 1092 */
+	{ "ASMT109x- Config",	NULL,		ATA_HORKAGE_DISABLE },
 
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 },

Applied to for-5.16-fixes with CC stable added.
Thanks !

Signature · 2 lines
Damien Le Moal
Western Digital Research