drivers/mmc/core/bus: Remove redundant driver match function
PATCH 1/1 drivers/mmc/core/bus: Remove redundant driver match function
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches. See function driver_match_device().
Drop the mmc bus's match function that always returned 1 and so implements the same behaviour as when there is no match function.
--- drivers/mmc/core/bus.c | 11 ----------- 1 file changed, 11 deletions(-)
drivers/mmc/core/bus.c +0 -11
@@ -53,16 +53,6 @@ static struct attribute *mmc_dev_attrs[] = { };ATTRIBUTE_GROUPS (mmc_dev); -/* -* This currently matches any MMC driver to any MMC card - drivers -* themselves make the decision whether to drive this card in their -* probe method. -*/ -static int mmc_bus_match (struct device *dev,struct device_driver *drv) -{ -return 1 ; -} -static int mmc_bus_uevent (struct device *dev,struct kobj_uevent_env *env) {
@@ -226,7 +216,6 @@ static const struct dev_pm_ops mmc_bus_pm_ops = {static struct bus_type mmc_bus_type = { .name ="mmc" , .dev_groups = mmc_dev_groups, - .match = mmc_bus_match, .uevent = mmc_bus_uevent, .probe = mmc_bus_probe, .remove = mmc_bus_remove,
Signature · 1 line
2.25.1
Quoted 10 lines · lizhe
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches. See function
driver_match_device().Drop the mmc bus's match function that always returned 1 and so implements the same behaviour as when there is no match function.
Signed-off-by lizhe <[email protected]>
I have already applied your previous version. Or is there a change in this version?
Future wise, please bump the version number between each submission and highlight what you have changed. See Documentation/SubmittingPatches.
Kind regards
Uffe
Quoted 37 lines
--- drivers/mmc/core/bus.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/mmc/core/bus.c +0
-12@@ -53,16 +53,6 @@ static struct attribute *mmc_dev_attrs[] = { };ATTRIBUTE_GROUPS (mmc_dev); -/* -* This currently matches any MMC driver to any MMC card - drivers -* themselves make the decision whether to drive this card in their -* probe method. -*/ -static int mmc_bus_match (struct device *dev,struct device_driver *drv) -{ -return 1 ; -} -static int mmc_bus_uevent (struct device *dev,struct kobj_uevent_env *env) {@@ -226,7 +216,6 @@ static const struct dev_pm_ops mmc_bus_pm_ops = {static struct bus_type mmc_bus_type = { .name ="mmc" , .dev_groups = mmc_dev_groups, - .match = mmc_bus_match, .uevent = mmc_bus_uevent, .probe = mmc_bus_probe, .remove = mmc_bus_remove, --2.25.1