ALSA: drivers: opl3: Fix incorrect use of vp->state
Subsystems (2)
PATCH 1/1 ALSA: drivers: opl3: Fix incorrect use of vp->state
Static analysis with scan-build has found an assignment to vp2 that is never used. It seems that the check on vp->state > 0 should be actually on vp2->state instead. Fix this.
This dates back to 2002, I found the offending commit from the git history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")
--- sound/drivers/opl3/opl3_midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/drivers/opl3/opl3_midi.c +1 -1
@@ -397,7 +397,7 @@ void snd_opl3_note_on(void *p, int note, int vel, struct snd_midi_channel *chan) }if (instr_4op) { vp2 = &opl3->voices[voice +3 ]; -if (vp->state >0 ) { +if (vp2->state >0 ) { opl3_reg = reg_side | (OPL3_REG_KEYON_BLOCK + voice_offset +3 ); reg_val = vp->keyon_reg & ~OPL3_KEYON_BIT ;
Signature · 1 line
2.33.1
Takashi Iwai
AppliedQuoted 10 lines · Colin Ian King
Static analysis with scan-build has found an assignment to vp2 that is never used. It seems that the check on
vp->state> 0 should be actually onvp2->stateinstead. Fix this.This dates back to 2002, I found the offending commit from the git history
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
commit91e39521bbf6("[PATCH] ALSA patch for 2.5.4")Signed-off-by Colin Ian King <[email protected]>
Thanks, applied now with Cc-to-stable.
Takashi