dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema
Subsystems (3)
PATCH v3 1/1 dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema
From: Stefan Wahren <[email protected]>
This converts the VCHIQ bindings to YAML format.
Signed-off-by Stefan Wahren <[email protected]>
Co-developed-by Nicolas Saenz Julienne <[email protected]>
Signed-off-by Nicolas Saenz Julienne <[email protected]>
---
Changes since v2:
- Reinstate fallback compatible
.../bindings/soc/bcm/brcm,bcm2835-vchiq.txt | 17 ------ .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 53 +++++++++++++++++++ 2 files changed, 53 insertions(+), 17 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt deleted +0 -17
@@ -1,17 +0,0 @@ -Broadcom VCHIQ firmware services - -Required properties: - -- compatible: Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise - "brcm,bcm2836-vchiq". -- reg: Physical base address and length of the doorbell register pair -- interrupts: The interrupt number - See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt - -Example: - -mailbox@7e00b840 { - compatible = "brcm,bcm2835-vchiq"; - reg = <0x7e00b840 0xf>; - interrupts = <0 2>; -};
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml new file +53 -0
53 lines not on this page · raw message
Signature · 1 line
2.33.1
Rob Herring
maintainerQuoted 3 lines · Nicolas Saenz Julienne
From: Stefan Wahren <[email protected]>
This converts the VCHIQ bindings to YAML format.
Am I supposed to review this? Some version of it is already in linux-next...
Quoted 101 lines
Signed-off-by Stefan Wahren <[email protected]>Co-developed-by Nicolas Saenz Julienne <[email protected]>Signed-off-by Nicolas Saenz Julienne <[email protected]>---
Changes since v2:
- Reinstate fallback compatible.../bindings/soc/bcm/brcm,bcm2835-vchiq.txt | 17 ------ .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 53 +++++++++++++++++++ 2 files changed, 53 insertions(+), 17 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yamlDocumentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt deleted +0
-17@@ -1,17 +0,0 @@ -Broadcom VCHIQ firmware services - -Required properties: - -- compatible: Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise - "brcm,bcm2836-vchiq". -- reg: Physical base address and length of the doorbell register pair -- interrupts: The interrupt number - See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt - -Example: - -mailbox@7e00b840 { - compatible = "brcm,bcm2835-vchiq"; - reg = <0x7e00b840 0xf>; - interrupts = <0 2>; -};Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml new file +53
-0@@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2835-vchiq.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom VCHIQ firmware services + +maintainers: + - Nicolas Saenz Julienne <[email protected]> + +description: + The VCHIQ communication channel can be provided by BCM283x and Capri SoCs, + to communicate with the VPU-side OS services. + +properties: + compatible: + oneOf: + - description: BCM2835 based boards + items: + - enum: + - brcm,bcm2835-vchiq + + - description: BCM2836/BCM2837 based boards + items: + - enum: + - brcm,bcm2836-vchiq + - const: brcm,bcm2835-vchiq + + reg: + description: Physical base address and length of the doorbell register pair + minItems: 1 + + interrupts: + description: Interrupt number of the doorbell interrupt + minItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + mailbox@7e00b840 { + compatible = "brcm,bcm2835-vchiq"; + reg = <0x7e00b840 0xf>; + interrupts = <0 2>; + }; + +...Signature · 1 line
2.33.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Rob,
Quoted 7 lines · Rob Herring
Quoted 3 lines · Nicolas Saenz Julienne
From: Stefan Wahren <[email protected]>
This converts the VCHIQ bindings to YAML format.
Am I supposed to review this? Some version of it is already in linux-next...
It's been removed from linux-next for the time being. There was some issues with the previous binding, namely the fact that it removed the fallback to 'bcrm,bcm2835-vchiq' on BCM2836/BCM2837. All in all, having it is harmless and might avoid regressions on some OSs.
Regards,
Nicolas
Quoted 84 lines · Nicolas Saenz Julienne
From: Stefan Wahren <[email protected]>
This converts the VCHIQ bindings to YAML format.
Signed-off-by Stefan Wahren <[email protected]>Co-developed-by Nicolas Saenz Julienne <[email protected]>Signed-off-by Nicolas Saenz Julienne <[email protected]>---
Changes since v2:
- Reinstate fallback compatible.../bindings/soc/bcm/brcm,bcm2835-vchiq.txt | 17 ------ .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 53 +++++++++++++++++++ 2 files changed, 53 insertions(+), 17 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yamlDocumentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt deleted +0
-17@@ -1,17 +0,0 @@ -Broadcom VCHIQ firmware services - -Required properties: - -- compatible: Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise - "brcm,bcm2836-vchiq". -- reg: Physical base address and length of the doorbell register pair -- interrupts: The interrupt number - See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt - -Example: - -mailbox@7e00b840 { - compatible = "brcm,bcm2835-vchiq"; - reg = <0x7e00b840 0xf>; - interrupts = <0 2>; -};Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml new file +37
-0@@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2835-vchiq.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom VCHIQ firmware services + +maintainers: + - Nicolas Saenz Julienne <[email protected]> + +description: + The VCHIQ communication channel can be provided by BCM283x and Capri SoCs, + to communicate with the VPU-side OS services. + +properties: + compatible: + oneOf: + - description: BCM2835 based boards + items: + - enum: + - brcm,bcm2835-vchiq + + - description: BCM2836/BCM2837 based boards + items: + - enum: + - brcm,bcm2836-vchiq + - const: brcm,bcm2835-vchiq + + reg: + description: Physical base address and length of the doorbell register pair + minItems: 1 + + interrupts: + description: Interrupt number of the doorbell interrupt + minItems: 1 +
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml line 47
Quoted 10 lines
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml new file +10
-0+required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + mailbox@7e00b840 {
A 'mailbox' node should have '#mbox-cells'. And be located in bindings/mailbox. That can all be a separate patch (or part of this one if you want).
Reviewed-by Rob Herring <[email protected]>
Quoted 10 lines
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml new file +6
-0+ compatible = "brcm,bcm2835-vchiq"; + reg = <0x7e00b840 0xf>; + interrupts = <0 2>; + }; + +...Signature · 1 line
2.33.1