Skip to contentSkip to conversation

PM / devfreq: sun8i: addd COMMON_CLK dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 15, 2021 – Dec 16, 2021 Device frequency (devfreq)

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 PM / devfreq: sun8i: addd COMMON_CLK dependency

From: Arnd Bergmann <[email protected]>

Compile-testing the driver without CONFIG_COMMON_CLK causes a link failure:

arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_remove':
sun8i-a33-mbus.c:(.text+0x450): undefined reference to `clk_rate_exclusive_put'
arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x460): undefined reference to `clk_rate_exclusive_put'
arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_probe':
sun8i-a33-mbus.c:(.text+0x85c): undefined reference to `clk_rate_exclusive_get'
arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x878): undefined reference to `clk_rate_exclusive_get'

Fixes 8bfd4858b4bb ("PM / devfreq: Add a driver for the sun8i/sun50i MBUS")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/devfreq/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/devfreq/Kconfig +1 -0
index b94eb04761f6..87eb2b837e68 100644
@@ -135,6 +135,7 @@ config ARM_RK3399_DMC_DEVFREQ
 config ARM_SUN8I_A33_MBUS_DEVFREQ
 	tristate "sun8i/sun50i MBUS DEVFREQ Driver"
 	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on COMMON_CLK
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
 	help
 	  This adds the DEVFREQ driver for the MBUS controller in some
Signature · 1 line
2.29.2
maintainer
#1 lore raw
Quoted 24 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Compile-testing the driver without CONFIG_COMMON_CLK causes a link failure:

arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_remove':
sun8i-a33-mbus.c:(.text+0x450): undefined reference to `clk_rate_exclusive_put'
arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x460): undefined reference to `clk_rate_exclusive_put'
arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_probe':
sun8i-a33-mbus.c:(.text+0x85c): undefined reference to `clk_rate_exclusive_get'
arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x878): undefined reference to `clk_rate_exclusive_get'

Fixes 8bfd4858b4bb ("PM / devfreq: Add a driver for the sun8i/sun50i MBUS")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/devfreq/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/devfreq/Kconfig +0 -0
index b94eb04761f6..87eb2b837e68 100644

drivers/devfreq/Kconfig config ARM_RK3399_DMC_DEVFREQ · line 141

Quoted 7 lines
drivers/devfreq/Kconfig +1 -0
@@ -135,6 +135,7 @@ config ARM_RK3399_DMC_DEVFREQ
 config ARM_SUN8I_A33_MBUS_DEVFREQ
 	tristate "sun8i/sun50i MBUS DEVFREQ Driver"
 	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on COMMON_CLK
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
 	help
 	  This adds the DEVFREQ driver for the MBUS controller in some

Thanks. Applied it.

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics