Skip to contentSkip to conversation

drm/msm: remove variable set but not used

PATCH In review Yang Li 2 participants 2 messages Dec 16, 2021 – Jan 19, 2022

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 drm/msm: remove variable set but not used

The code that uses variable mdss has been removed, So the declaration and assignment of the variable can be removed.

Eliminate the following clang warning:
drivers/gpu/drm/msm/msm_drv.c:513:19: warning: variable 'mdss' set but not used [-Wunused-but-set-variable]

Fixes 2027e5b3413d ("drm/msm: Initialize MDSS irq domain at probe time")
---
 drivers/gpu/drm/msm/msm_drv.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/msm/msm_drv.c +0 -3
index ad35a5d94053..59e30192cdf6 100644
@@ -510,7 +510,6 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
 	struct msm_drm_private *priv = dev_get_drvdata(dev);
 	struct drm_device *ddev;
 	struct msm_kms *kms;
-	struct msm_mdss *mdss;
 	int ret, i;
 
 	ddev = drm_dev_alloc(drv, dev);
@@ -521,8 +520,6 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
 	ddev->dev_private = priv;
 	priv->dev = ddev;
 
-	mdss = priv->mdss;
-
 	priv->wq = alloc_ordered_workqueue("msm", 0);
 	priv->hangcheck_period = DRM_MSM_HANGCHECK_DEFAULT_PERIOD;
 
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Yang Li

The code that uses variable mdss has been removed, So the declaration and assignment of the variable can be removed.

Eliminate the following clang warning:
drivers/gpu/drm/msm/msm_drv.c:513:19: warning: variable 'mdss' set but not used [-Wunused-but-set-variable]

Fixes 2027e5b3413d ("drm/msm: Initialize MDSS irq domain at probe time")
Quoted 25 lines
---
  drivers/gpu/drm/msm/msm_drv.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/gpu/drm/msm/msm_drv.c +0 -3
index ad35a5d94053..59e30192cdf6 100644
@@ -510,7 +510,6 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
  	struct msm_drm_private *priv = dev_get_drvdata(dev);
  	struct drm_device *ddev;
  	struct msm_kms *kms;
-	struct msm_mdss *mdss;
  	int ret, i;
 
  	ddev = drm_dev_alloc(drv, dev);
@@ -521,8 +520,6 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
  	ddev->dev_private = priv;
  	priv->dev = ddev;
 
-	mdss = priv->mdss;
-
  	priv->wq = alloc_ordered_workqueue("msm", 0);
  	priv->hangcheck_period = DRM_MSM_HANGCHECK_DEFAULT_PERIOD;
 
Signature · 2 lines
With best wishes
Dmitry