Skip to contentSkip to conversation

memblock: fix memblock_phys_alloc() section mismatch error

PATCH Applied Jackie Liu 2 participants 2 messages Dec 17, 2021 – Dec 18, 2021

Subsystems (2)
lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH v2 1/1 memblock: fix memblock_phys_alloc() section mismatch error

From: Jackie Liu <[email protected]>

Fix modpost Section mismatch error in memblock_phys_alloc()

[...]
WARNING: modpost: vmlinux.o(.text.unlikely+0x1dcc): Section mismatch in reference from the function memblock_phys_alloc() to the function .init.text:memblock_phys_alloc_range() The function memblock_phys_alloc() references
the function __init memblock_phys_alloc_range().
This is often because memblock_phys_alloc lacks a __init
annotation or the annotation of memblock_phys_alloc_range is wrong.

ERROR: modpost: Section mismatches detected. Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them. [...]

I have checked that the memblock_phys_alloc used in the source tree is all in the __init section, we should make it as always inline.

---
 include/linux/memblock.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/memblock.h +2 -2
index 8adcf1fa8096..9dc7cb239d21 100644
@@ -405,8 +405,8 @@ phys_addr_t memblock_alloc_range_nid(phys_addr_t size,
 				      phys_addr_t end, int nid, bool exact_nid);
 phys_addr_t memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t align, int nid);
 
-static inline phys_addr_t memblock_phys_alloc(phys_addr_t size,
-					      phys_addr_t align)
+static __always_inline phys_addr_t memblock_phys_alloc(phys_addr_t size,
+						       phys_addr_t align)
 {
 	return memblock_phys_alloc_range(size, align, 0,
 					 MEMBLOCK_ALLOC_ACCESSIBLE);
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw

From: Mike Rapoport <[email protected]>

Quoted 12 lines · Jackie Liu

From: Jackie Liu <[email protected]>

Fix modpost Section mismatch error in memblock_phys_alloc()

[...]
WARNING: modpost: vmlinux.o(.text.unlikely+0x1dcc): Section mismatch in reference from the function memblock_phys_alloc() to the function .init.text:memblock_phys_alloc_range() The function memblock_phys_alloc() references
the function __init memblock_phys_alloc_range().
This is often because memblock_phys_alloc lacks a __init
annotation or the annotation of memblock_phys_alloc_range is wrong.

Quoted 1 line

[...]

Applied, thanks!

[1/1] memblock: fix memblock_phys_alloc() section mismatch error
(no commit info)

Best regards,

Signature · 1 line
Mike Rapoport <[email protected]>