drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
Subsystems (4)
PATCH 1/1 drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
The suported page sizes of an iommu_domain are saved in the pgsize_bitmap field. Retrieve the value from the right place.
Fixes 58fd9375c2c534 ("drm/nouveau/platform: probe IOMMU if present")
Signed-off-by Lu Baolu <[email protected]>
--- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c +1 -1
@@ -133,7 +133,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)* or equal to the system's PAGE_SIZE, with a preference if * both are equal. */ - pgsize_bitmap = tdev->iommu.domain->ops->pgsize_bitmap; + pgsize_bitmap = tdev->iommu.domain->pgsize_bitmap;if (pgsize_bitmap &PAGE_SIZE ) { tdev->iommu.pgshift =PAGE_SHIFT ; }else {
Signature · 1 line
2.25.1
Quoted 4 lines · Lu Baolu
The suported page sizes of an
iommu_domainare saved in thepgsize_bitmapfield. Retrieve the value from the right place.Fixes 58fd9375c2c534 ("drm/nouveau/platform: probe IOMMU if present")
...except domain->pgsize_bitmap was introduced more than a year after that commit ;)
As an improvement rather than a fix, though,
Reviewed-by Robin Murphy <[email protected]>
Quoted 18 lines
Signed-off-by Lu Baolu <[email protected]>--- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c +1
-1@@ -133,7 +133,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)* or equal to the system's PAGE_SIZE, with a preference if * both are equal. */ - pgsize_bitmap = tdev->iommu.domain->ops->pgsize_bitmap; + pgsize_bitmap = tdev->iommu.domain->pgsize_bitmap;if (pgsize_bitmap &PAGE_SIZE ) { tdev->iommu.pgshift =PAGE_SHIFT ; }else {