Skip to contentSkip to conversation

syscalls/keyctl09: test encrypted keys.

PATCH In review Yael Tiomkin 4 participants 8 messages Dec 21, 2021 – Dec 22, 2021 Keys-trusted

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 syscalls/keyctl09: test encrypted keys.

Test that encrypted keys can be instantiated using both user-provided decrypted data
(https://lore.kernel.org/linux-integrity/[email protected]/),
or kernel-generated numbers.

---

Notes:

    v -> v2: added key revocation and made styling changes.
 runtest/syscalls                            |  1 +
 testcases/kernel/syscalls/keyctl/.gitignore |  1 +
 testcases/kernel/syscalls/keyctl/keyctl09.c | 58 +++++++++++++++++++++
 3 files changed, 60 insertions(+)
 create mode 100644 testcases/kernel/syscalls/keyctl/keyctl09.c
runtest/syscalls +1 -0
index bcf3d56c9..ccea1ddbd 100644
@@ -643,6 +643,7 @@ keyctl05 keyctl05
 keyctl06 keyctl06
 keyctl07 keyctl07
 keyctl08 keyctl08
+keyctl09 keyctl09
 
 kcmp01 kcmp01
 kcmp02 kcmp02
testcases/kernel/syscalls/keyctl/.gitignore +1 -0
index 3544ac79c..f9948c176 100644
@@ -6,3 +6,4 @@
 /keyctl06
 /keyctl07
 /keyctl08
+/keyctl09
testcases/kernel/syscalls/keyctl/keyctl09.c new file +58 -0

58 lines not on this page · raw message

Signature · 1 line
2.34.1.307.g9b7440fafd-goog
Reviewed-by on v2 1/1
#1 lore raw

Hi Yael,

you still have some problem when running more iterations:

./keyctl09 -i500
keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read
...
keyctl09.c:33: TFAIL: Failed to instantiate encrypted key using payload decrypted data

(some people really try high number of iterations.) Could you please have a look?

Quoted 4 lines

Test that encrypted keys can be instantiated using both user-provided decrypted data
(https://lore.kernel.org/linux-integrity/[email protected]/),
or kernel-generated numbers.

+1 for doc!

...

Quoted 6 lines
testcases/kernel/syscalls/keyctl/keyctl09.c new file +6 -0
+static void do_test(void)
+{
+	key_serial_t masterkey;
+	key_serial_t encryptedkey1;
+	key_serial_t encryptedkey2;
+	char buffer[128];

testcases/kernel/syscalls/keyctl/keyctl09.c line 33

Quoted 10 lines
testcases/kernel/syscalls/keyctl/keyctl09.c new file +10 -0
+
+	masterkey = add_key("user", "user:masterkey", "foo", 3,
+			    KEY_SPEC_PROCESS_KEYRING);
+	if (masterkey == -1)
+		tst_brk(TBROK | TERRNO, "Failed to add user key");
+
+	encryptedkey1 = add_key("encrypted", "ltptestkey1", ENCRYPTED_KEY_1_PAYLOAD,
+				60, KEY_SPEC_PROCESS_KEYRING);
+	if (encryptedkey1 == -1)
+		tst_brk(TFAIL, "Failed to instantiate encrypted key using payload decrypted data");

nit: this might be TBROK (test preparation phase), not sure (and not that important).

The rest LGTM.

Kind regards,
Petr

Tested-by on v2 1/1
#2 lore raw
In reply to Yael Tiomkin
Quoted 6 lines · Yael Tiomkin

Test that encrypted keys can be instantiated using both user-provided decrypted data
(https://lore.kernel.org/linux-integrity/[email protected]/),
or kernel-generated numbers.

Tested on ppc64le platform

...
<<<test_start>>>
tag=keyctl09 stime=1640078325
cmdline="keyctl09"
contacts=""
analysis=exit
<<<test_output>>>
tst_test.c:1425: TINFO: Timeout per run is 0h 05m 00s keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read

Summary:

passed   1
failed   0
broken   0
skipped  0

warnings 0
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no cutime=0 cstime=0
<<<test_end>>>
...

Quoted 96 lines

---

Notes:

     v -> v2: added key revocation and made styling changes.
  runtest/syscalls                            |  1 +
  testcases/kernel/syscalls/keyctl/.gitignore |  1 +
  testcases/kernel/syscalls/keyctl/keyctl09.c | 58 +++++++++++++++++++++
  3 files changed, 60 insertions(+)

create mode 100644 testcases/kernel/syscalls/keyctl/keyctl09.c

runtest/syscalls +1 -0
index bcf3d56c9..ccea1ddbd 100644
@@ -643,6 +643,7 @@ keyctl05 keyctl05
  keyctl06 keyctl06
  keyctl07 keyctl07
  keyctl08 keyctl08
+keyctl09 keyctl09
 
  kcmp01 kcmp01
  kcmp02 kcmp02
testcases/kernel/syscalls/keyctl/.gitignore +1 -0
index 3544ac79c..f9948c176 100644
@@ -6,3 +6,4 @@
  /keyctl06
  /keyctl07
  /keyctl08
+/keyctl09
testcases/kernel/syscalls/keyctl/keyctl09.c new file +58 -0
new file mode 100644
index 000000000..507cd5628
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2021 Google, Inc.
+ */
+
+/*\
+ * [Description]
+ * Test that encrypted keys can be instantiated using user-provided decrypted
+ * data (plaintext), and separately, using kernel-generated key material.
+ */
+
+#include "tst_test.h"
+#include "lapi/keyctl.h"
+
+#define ENCRYPTED_KEY_1_PAYLOAD	"new enc32 user:masterkey 32 plaintext12345678901234567890123"
+#define ENCRYPTED_KEY_2_PAYLOAD	"new enc32 user:masterkey 32"
+
+static void do_test(void)
+{
+	key_serial_t masterkey;
+	key_serial_t encryptedkey1;
+	key_serial_t encryptedkey2;
+	char buffer[128];
+
+	masterkey = add_key("user", "user:masterkey", "foo", 3,
+			    KEY_SPEC_PROCESS_KEYRING);
+	if (masterkey == -1)
+		tst_brk(TBROK | TERRNO, "Failed to add user key");
+
+	encryptedkey1 = add_key("encrypted", "ltptestkey1", ENCRYPTED_KEY_1_PAYLOAD,
+				60, KEY_SPEC_PROCESS_KEYRING);
+	if (encryptedkey1 == -1)
+		tst_brk(TFAIL, "Failed to instantiate encrypted key using payload decrypted data");
+
+	TEST(keyctl(KEYCTL_READ, encryptedkey1, buffer, sizeof(buffer)));
+	if (TST_RET < 0)
+		tst_brk(TFAIL, "KEYCTL_READ failed for encryptedkey1");
+
+	encryptedkey2 = add_key("encrypted", "ltptestkey2", ENCRYPTED_KEY_2_PAYLOAD,
+				27, KEY_SPEC_PROCESS_KEYRING);
+	if (encryptedkey2 == -1)
+		tst_brk(TFAIL,
+			"Failed to instantiate encrypted key using kernel-generated key material");
+
+	TEST(keyctl(KEYCTL_READ, encryptedkey2, buffer, sizeof(buffer)));
+	if (TST_RET < 0)
+		tst_brk(TFAIL, "KEYCTL_READ failed for encryptedkey2");
+
+	tst_res(TPASS, "Encrypted keys were successfully instantiated and read");
+
+	keyctl(KEYCTL_REVOKE, encryptedkey1);
+	keyctl(KEYCTL_REVOKE, encryptedkey2);
+	keyctl(KEYCTL_REVOKE, masterkey);
+}
+
+static struct tst_test test = {
+	.test_all = do_test,
+};
Signature · 2 lines
Thanks and Regards
R.Nageswara Sastry
#3 lore raw

Hi Nageswara,

Quoted 9 lines · Yael Tiomkin
Quoted 6 lines

Test that encrypted keys can be instantiated using both user-provided decrypted data
(https://lore.kernel.org/linux-integrity/[email protected]/),
or kernel-generated numbers.

Tested on ppc64le platform

I suppose it also fails on ppc64le when run more iterations.
./keyctl09 -i500
keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read
...
keyctl09.c:33: TFAIL: Failed to instantiate encrypted key using payload decrypted data

(It's always good to put higher number iterations.)

Kind regards,
Petr

#4 lore raw
Quoted 8 lines · Petr Vorel

Hi Nageswara,

Quoted 5 lines · Yael Tiomkin
Quoted 4 lines

Test that encrypted keys can be instantiated using both user-provided decrypted data
(https://lore.kernel.org/linux-integrity/[email protected]/),
or kernel-generated numbers.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Tested on ppc64le platform

I suppose it also fails on ppc64le when run more iterations.

Tried with -i500, -i5000 and -i50000 also ... no failures were seen on ppc64le architecture.

Summary:
passed 500
failed 0

Summary:
passed 5000
failed 0

Summary:
passed 50000
failed 0

Quoted 10 lines

./keyctl09 -i500
keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read
...
keyctl09.c:33: TFAIL: Failed to instantiate encrypted key using payload decrypted data

(It's always good to put higher number iterations.)

Kind regards,
Petr

Signature · 2 lines
Thanks and Regards
R.Nageswara Sastry
#5 lore raw

Hi all,

Quoted 23 lines · Petr Vorel
Quoted 8 lines

Hi Nageswara,

Quoted 5 lines · Yael Tiomkin
Quoted 4 lines

Test that encrypted keys can be instantiated using both user-provided decrypted data
(https://lore.kernel.org/linux-integrity/[email protected]/),
or kernel-generated numbers.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Tested on ppc64le platform

I suppose it also fails on ppc64le when run more iterations.

Tried with -i500, -i5000 and -i50000 also ... no failures were seen on ppc64le architecture.

Summary:
passed 500
failed 0

Quoted 7 lines

Summary:
passed 5000
failed 0

Summary:
passed 50000
failed 0

Interesting, thx for info. It's either arch specific or specific to openSUSE kernel on my laptop (~ 5.16.0-rc5) where I tested it. Testing on various VM it works well (including openSUSE with latest kernel stable). It also works on RPI 4 with openSUSE kernel.

Also it fails on 2 VMs with fips enabled: Debian testing (immediately) and SLES 15-SP4 (after 63 iterations - the same number as 5.16.0-rc5 on my laptop):
keyctl09.c:33: TBROK: Failed to instantiate encrypted key using payload decrypted data

but on my laptop I don't use fips.

Kind regards,
Petr

#6 lore raw
In reply to Yael Tiomkin
Quoted 7 lines · Yael Tiomkin
testcases/kernel/syscalls/keyctl/keyctl09.c new file +1 -0
new file mode 100644
index 000000000..507cd5628
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-or-later

testcases/kernel/syscalls/keyctl/keyctl09.c line 11

Quoted 10 lines
testcases/kernel/syscalls/keyctl/keyctl09.c new file +10 -0
+/*
+ * Copyright (c) 2021 Google, Inc.
+ */
+
+/*\
+ * [Description]
+ * Test that encrypted keys can be instantiated using user-provided decrypted
+ * data (plaintext), and separately, using kernel-generated key material.
+ */
+

This test doesn't seem to work as intended.

First, it fails if CONFIG_ENCRYPTED_KEYS is unset (it should be skipped):

keyctl09.c:33: TFAIL: Failed to instantiate encrypted key using payload decrypted data

Second, I don't have your patch "Instantiate key with user-provided decrypted data" (https://lore.kernel.org/r/[email protected]) in my kernel, so instantiating a key using "user-provided decrypted data" is not implemented by the kernel. However, the test still passes regardless:

keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read

The test should detect when "user-provided decrypted data" is not supported by the kernel, and report that the test of that is being skipped in that case.

- Eric

#7 lore raw
Quoted 30 lines · Eric Biggers
Quoted 7 lines · Yael Tiomkin
testcases/kernel/syscalls/keyctl/keyctl09.c new file +1 -0
new file mode 100644
index 000000000..507cd5628
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-or-later

testcases/kernel/syscalls/keyctl/keyctl09.c line 11

Quoted 10 lines
testcases/kernel/syscalls/keyctl/keyctl09.c new file +10 -0
+/*
+ * Copyright (c) 2021 Google, Inc.
+ */
+
+/*\
+ * [Description]
+ * Test that encrypted keys can be instantiated using user-provided decrypted
+ * data (plaintext), and separately, using kernel-generated key material.
+ */
+

This test doesn't seem to work as intended.

First, it fails if CONFIG_ENCRYPTED_KEYS is unset (it should be skipped):

keyctl09.c:33: TFAIL: Failed to instantiate encrypted key using payload decrypted data

Second, I don't have your patch "Instantiate key with user-provided decrypted data" (https://lore.kernel.org/r/[email protected]) in my kernel, so instantiating a key using "user-provided decrypted data" is not implemented by the kernel. However, the test still passes regardless:

Quoted 5 lines

keyctl09.c:49: TPASS: Encrypted keys were successfully instantiated and read

The test should detect when "user-provided decrypted data" is not supported by the kernel, and report that the test of that is being skipped in that case.

And of course, if "user-provided decrypted data" *is* supported by the kernel, the test should actually test it.

- Eric