mm/damon/dbgfs: Protect targets destructions with kdamond_lock
Subsystems (3)
SeongJae Park
maintainerPATCH 1/1 mm/damon/dbgfs: Protect targets destructions with kdamond_lock
DAMON debugfs interface iterates current monitoring targets in 'dbgfs_target_ids_read()' while holding the corresponding 'kdamond_lock'. However, it also destructs the monitoring targets in 'dbgfs_before_terminate()' without holding the lock. This can result in a use_after_free bug. This commit avoids the race by protecting the destruction with the corresponding 'kdamond_lock'.
Reported-by Sangwoo Bae <[email protected]>
Fixes 4bc05954d007 ("mm/damon: implement a debugfs-based user space interface")
Signed-off-by SeongJae Park <[email protected]>
Cc <[email protected]> # 5.15.x
---
This cannot cleanly applied on 5.15.y tree. I will post a backport as soon as this is applied on the mainline.
mm/damon/dbgfs.c | 2 ++ 1 file changed, 2 insertions(+)
mm/damon/dbgfs.c +2 -0
@@ -659,10 +659,12 @@ static void dbgfs_before_terminate(struct damon_ctx *ctx)if (!targetid_is_pid (ctx))return ; +mutex_lock (&ctx->kdamond_lock);damon_for_each_target_safe (t, next, ctx) {put_pid ((struct pid *)t->id);damon_destroy_target (t); } +mutex_unlock (&ctx->kdamond_lock); }static struct damon_ctx *dbgfs_new_ctx (void )
Signature · 1 line
2.17.1