Skip to contentSkip to conversation

crypto: cleanup warning in qm_get_qos_value()

PATCH In review [email protected] 2 participants 2 messages Dec 22, 2021 – Dec 31, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 crypto: cleanup warning in qm_get_qos_value()

From: Tom Rix <[email protected]>

Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value

        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting *val. So check ret before checking *val.

Fixes 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")

---
v2: Add Fixes: line

 drivers/crypto/hisilicon/qm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/hisilicon/qm.c +1 -1
index b1fe9c7b8cc89..c906f2e59277b 100644
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
 		return -EINVAL;
 
 	ret = qm_qos_value_init(val_buf, val);
-	if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+	if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
 		pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
 		return -EINVAL;
 	}
Signature · 1 line
2.26.3
maintainer
#1 lore raw
Quoted 11 lines · On Wed, Dec 22, 2021 at 09:29:23AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value

        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting *val. So check ret before checking *val.

Quoted 7 lines
Fixes 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")

---
v2: Add Fixes: line

 drivers/crypto/hisilicon/qm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt