Skip to contentSkip to conversation

OMAP2: Nokia N810: prepare tahvo cells for display

PATCH In review [email protected] 2 participants 6 messages Dec 24, 2021 – Feb 3, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover OMAP2: Nokia N810: prepare tahvo cells for display

Bye, and Merry Christmas everyone :-)
Peter

Peter Vasil (6):
[PATCH 1/6] dt-bindings: leds: Nokia Tahvo/Betty ASIC LEDPWM [PATCH 2/6] dt-bindings: regulator: Nokia Tahvo/Betty ASIC Vcore [PATCH 3/6] ARM: dts: omap2420-n810: Add Tahvo/Betty LEDPWM and Vcore [PATCH 4/6] leds: tahvo: Driver for Tahvo/Betty ASIC LEDPWM output [PATCH 5/6] regulator: tahvo-vcore: Add basic Tahvo/Betty ASIC Vcore [PATCH 6/6] mfd: retu: Add support for LEDPWM and Vcore regulator MFD

 Documentation/devicetree/bindings/regulator/nokia,tahvo-vcore-regulator.yaml |  41 +++++++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/omap2420-n810.dts                                          |  13 +++++++++++++
 arch/arm/boot/dts/omap2420-n8x0-common.dtsi                                  |   8 +++++++-
 drivers/leds/Kconfig                                                         |  12 ++++++++++++
 drivers/leds/Makefile                                                        |   1 +
 drivers/leds/leds-tahvo.c                                                    |  85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/mfd/retu-mfd.c                                                       |   8 ++++++++
 drivers/regulator/Kconfig                                                    |   8 ++++++++
 drivers/regulator/Makefile                                                   |   1 +
 drivers/regulator/tahvo-vcore-regulator.c                                    | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 10 files changed, 280 insertions(+), 1 deletion(-)
#1 lore raw

PATCH 1/6 dt-bindings: leds: Nokia Tahvo/Betty ASIC LEDPWM controller

From: Peter Vasil <[email protected]>

One of the functions of Tahvo/Betty ASIC MFD chip is a PWM output able to drive LED with 127 levels of brightness.
On Nokia N8x0 Internet Tablet devices, this controls the LCD backlight.

---
 .../bindings/leds/nokia,tahvo-ledpwm.yaml     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/nokia,tahvo-ledpwm.yaml
Documentation/devicetree/bindings/leds/nokia,tahvo-ledpwm.yaml new file +32 -0
new file mode 100644
index 000000000000..6f6d9e4a9425
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/nokia,tahvo-ledpwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nokia Tahvo/Betty ASIC LEDPWM controller
+
+maintainers:
+  - Peter Vasil <[email protected]>
+
+description:
+  One of the functions of Tahvo/Betty ASIC MFD chip is a PWM output able to
+  drive LED with 127 levels of brightness.
+  On Nokia N8x0 Internet Tablet devices, this controls the LCD backlight.
+
+properties:
+  compatible:
+    const: nokia,tahvo-ledpwm
+
+additionalProperties: false
+
+examples:
+  - |
+
+    tahvo {
+        tahvo_ledpwm {
+            compatible = "nokia,tahvo-ledpwm";
+        };
+    };
+
+...
Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH 1/6] dt-bindings: leds: Nokia Tahvo/Betty ASIC LEDPWM controller

Quoted 8 lines · Tony Lindgren
Quoted 5 lines · * [email protected] <[email protected]> [211224 21:53]:

From: Peter Vasil <[email protected]>

One of the functions of Tahvo/Betty ASIC MFD chip is a PWM output able to drive LED with 127 levels of brightness.
On Nokia N8x0 Internet Tablet devices, this controls the LCD backlight.

Just noticed that the binding patches should be sent to Rob Herring and devicetree list for merging. Please take a look at the MAINTAINERS file for details and resend :)

Regards,

Tony

#4 lore raw

PATCH 2/6 dt-bindings: regulator: Nokia Tahvo/Betty ASIC Vcore regulator

In reply to [email protected]

From: Peter Vasil <[email protected]>

One of the functions of Tahvo/Betty ASIC MFD chip is a voltage regulator for Vcore output, adjustable from 1.005V to 1.475V. On Nokia N8x0 Internet Tablet devices, this controls power to the Epson S1D13745 framebuffer IC.

---
 .../nokia,tahvo-vcore-regulator.yaml          | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/nokia,tahvo-vcore-regulator.yaml
Documentation/devicetree/bindings/regulator/nokia,tahvo-vcore-regulator.yaml new file +41 -0
new file mode 100644
index 000000000000..5e1e98c32311
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/nokia,tahvo-vcore-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nokia Tahvo/Betty ASIC Vcore regulator
+
+maintainers:
+  - Peter Vasil <[email protected]>
+
+description: |
+  One of the functions of Tahvo/Betty ASIC MFD chip is a voltage regulator
+  for Vcore output, adjustable from 1.005V to 1.475V.
+  On Nokia N8x0 Internet Tablet devices, this controls power to the Epson
+  S1D13745 framebuffer IC.
+
+allOf:
+  - $ref: "regulator.yaml#"
+
+properties:
+  compatible:
+    const: nokia,tahvo-vcore-regulator
+
+required:
+  - compatible
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    tahvo {
+        tahvo_vcore {
+            compatible = "nokia,tahvo-vcore-regulator";
+            regulator-name = "tornado_vcore";
+            regulator-min-microvolt = <1500000>;
+            regulator-max-microvolt = <3000000>;
+            regulator-always-on;
+        };
+    };
+...
Signature · 1 line
2.25.1
Reviewed-by on v1 2/6
#5 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Nokia Tahvo/Betty ASIC Vcore regulator

Quoted 5 lines · * [email protected] <[email protected]> [211224 21:53]:

From: Peter Vasil <[email protected]>

One of the functions of Tahvo/Betty ASIC MFD chip is a voltage regulator for Vcore output, adjustable from 1.005V to 1.475V. On Nokia N8x0 Internet Tablet devices, this controls power to the Epson S1D13745 framebuffer IC.