Skip to contentSkip to conversation

net: eth-phy: Demote missing phy-handle log message to debug

PATCH In review Marek Vasut 2 participants 3 messages Jan 1, 2022 – Jan 15, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: eth-phy: Demote missing phy-handle log message to debug

Reduce the missing phy-handle log message to debug message. It is possible for ethernet DT node to have no phy-handle e.g. in case of a fixed-link connection. Furthermore, drop the FEC: prefix, which is a copy-paste error and rather print the ethernet device name.

---
 drivers/net/eth-phy-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/eth-phy-uclass.c +1 -1
index a9b358ee234..1f285f7afd2 100644
@@ -103,7 +103,7 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev)
 			return uc_priv->mdio_bus;
 		}
 	} else {
-		log_notice("FEC: can't find phy-handle\n");
+		log_debug("Can't find phy-handle for %s\n", eth_dev->name);
 	}
 
 	return NULL;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Marek Vasut

Reduce the missing phy-handle log message to debug message. It is possible for ethernet DT node to have no phy-handle e.g. in case of a fixed-link connection. Furthermore, drop the FEC: prefix, which is a copy-paste error and rather print the ethernet device name.

---
 drivers/net/eth-phy-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/eth-phy-uclass.c +1 -2
index a9b358ee234..1f285f7afd2 100644
@@ -103,7 +103,7 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev)
                        return uc_priv->mdio_bus;
                }
        } else {
-               log_notice("FEC: can't find phy-handle\n");
+               log_debug("Can't find phy-handle for %s\n", eth_dev->name);
        }
 
        return NULL;
--
Quoted 2 lines

2.34.1

#2 lore raw
Quoted 27 lines · Ramon Fried
Quoted 25 lines · Marek Vasut

Reduce the missing phy-handle log message to debug message. It is possible for ethernet DT node to have no phy-handle e.g. in case of a fixed-link connection. Furthermore, drop the FEC: prefix, which is a copy-paste error and rather print the ethernet device name.

---
 drivers/net/eth-phy-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/eth-phy-uclass.c +1 -1
index a9b358ee234..1f285f7afd2 100644
@@ -103,7 +103,7 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev)
                        return uc_priv->mdio_bus;
                }
        } else {
-               log_notice("FEC: can't find phy-handle\n");
+               log_debug("Can't find phy-handle for %s\n", eth_dev->name);
        }
 
Quoted 5 lines
Quoted 4 lines
drivers/net/eth-phy-uclass.c +0 -1
        return NULL;
--

2.34.1

Applied to u-boot-net/next
Thanks !