Skip to contentSkip to conversation

imx: Enable ACTLR.SMP in SPL for i.MX6/7

PATCH In review Sven Schwermer 3 participants 3 messages Jan 2, 2022 – Feb 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 imx: Enable ACTLR.SMP in SPL for i.MX6/7

Similar to what has been done before with c5437e5b for u-boot proper, we enable the SMP bit for SPL as well. This is necessary when SDP booting straight into Linux, i.e. falcon boot. When SDP boot mode is active, the ROM code does not set this bit which makes the caches not work once activated in Linux.

On an i.MX6ULL (528MHz), this reduces a minimal kernel's boot time into an initramfs shell from ~6.1s down to ~1.2s.

---

Changes in v2:
- Apply fix for i.MX7(ULP) as well
- Document quantitive improvement in boot time

 arch/arm/include/asm/mach-imx/sys_proto.h | 5 +++++
 arch/arm/mach-imx/cache.c                 | 2 +-
 arch/arm/mach-imx/mx6/soc.c               | 3 +++
 arch/arm/mach-imx/mx7/soc.c               | 3 +++
 arch/arm/mach-imx/mx7ulp/soc.c            | 2 ++
 5 files changed, 14 insertions(+), 1 deletion(-)
arch/arm/include/asm/mach-imx/sys_proto.h +5 -0
index 444834995e..3f66d225c8 100644
@@ -236,4 +236,9 @@ unsigned long call_imx_sip_ret2(unsigned long id, unsigned long reg0,
 				unsigned long reg3);
 
 void imx_get_mac_from_fuse(int dev_id, unsigned char *mac);
+
+#if defined(CONFIG_MX6) || defined(CONFIG_MX7) || defined(CONFIG_MX7ULP)
+void enable_ca7_smp(void);
+#endif
+
 #endif
arch/arm/mach-imx/cache.c +1 -1
index 4e3b49a3fd..ab9b621a2a 100644
@@ -11,7 +11,7 @@
 #include <asm/io.h>
 #include <asm/mach-imx/sys_proto.h>
 
-static void enable_ca7_smp(void)
+void enable_ca7_smp(void)
 {
 	u32 val;
 
arch/arm/mach-imx/mx6/soc.c +3 -0
index aacfc854a2..41f1a6e64e 100644
@@ -487,6 +487,9 @@ int arch_cpu_init(void)
 	if (is_mx6dqp())
 		noc_setup();
 #endif
+
+	enable_ca7_smp();
+
 	return 0;
 }
 
arch/arm/mach-imx/mx7/soc.c +3 -0
index 21690072e1..f6aec5a3aa 100644
@@ -14,6 +14,7 @@
 #include <asm/mach-imx/rdc-sema.h>
 #include <asm/arch/imx-rdc.h>
 #include <asm/mach-imx/boot_mode.h>
+#include <asm/mach-imx/sys_proto.h>
 #include <asm/arch/crm_regs.h>
 #include <asm/bootm.h>
 #include <dm.h>
@@ -323,6 +324,8 @@ int arch_cpu_init(void)
 
 	imx_gpcv2_init();
 
+	enable_ca7_smp();
+
 	return 0;
 }
 #else
arch/arm/mach-imx/mx7ulp/soc.c +2 -0
index c90ce22404..bc41cbc687 100644
@@ -13,6 +13,7 @@
 #include <asm/arch/sys_proto.h>
 #include <asm/mach-imx/boot_mode.h>
 #include <asm/mach-imx/hab.h>
+#include <asm/mach-imx/sys_proto.h>
 #include <asm/setup.h>
 #include <linux/bitops.h>
 
@@ -77,6 +78,7 @@ enum bt_mode get_boot_mode(void)
 
 int arch_cpu_init(void)
 {
+	enable_ca7_smp();
 	return 0;
 }
 
Signature · 1 line
2.34.1
reviewer Reviewed-by on v2 1/1
#1 lore raw

Hi Sven,

Quoted 10 lines · Sven Schwermer

Similar to what has been done before with c5437e5b for u-boot proper, we enable the SMP bit for SPL as well. This is necessary when SDP booting straight into Linux, i.e. falcon boot. When SDP boot mode is active, the ROM code does not set this bit which makes the caches not work once activated in Linux.

On an i.MX6ULL (528MHz), this reduces a minimal kernel's boot time into an initramfs shell from ~6.1s down to ~1.2s.

Quoted 6 lines

---

Changes in v2:
- Apply fix for i.MX7(ULP) as well
- Document quantitive improvement in boot time

Thanks for the updated version. It looks good to me:

#2 lore raw

PATCH v2 1/1 imx: Enable ACTLR.SMP in SPL for i.MX6/7

In reply to Sven Schwermer
Quoted 9 lines

Similar to what has been done before with c5437e5b for u-boot proper, we enable the SMP bit for SPL as well. This is necessary when SDP booting straight into Linux, i.e. falcon boot. When SDP boot mode is active, the ROM code does not set this bit which makes the caches not work once activated in Linux.
On an i.MX6ULL (528MHz), this reduces a minimal kernel's boot time into an initramfs shell from ~6.1s down to ~1.2s.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================