Skip to contentSkip to conversation

ice: fix setting l4 port flag when adding filter

PATCH New Michal Swiatkowski 2 participants 2 messages Jan 3, 2022 – Feb 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ice: fix setting l4 port flag when adding filter

Accidentally filter flag for none encapsulated l4 port filed is always set. Even if user wants to add encapsulated l4 port field.

Remove this unnecessary flag setting.

Fixes 9e300987d4a81 ("ice: VXLAN and Geneve TC support")
---
 drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ice/ice_tc_lib.c +2 -2
index e8aab664270a..65cf32eb4046 100644
@@ -709,7 +709,7 @@ ice_tc_set_port(struct flow_match_ports match,
 			fltr->flags |= ICE_TC_FLWR_FIELD_ENC_DEST_L4_PORT;
 		else
 			fltr->flags |= ICE_TC_FLWR_FIELD_DEST_L4_PORT;
-		fltr->flags |= ICE_TC_FLWR_FIELD_DEST_L4_PORT;
+
 		headers->l4_key.dst_port = match.key->dst;
 		headers->l4_mask.dst_port = match.mask->dst;
 	}
@@ -718,7 +718,7 @@ ice_tc_set_port(struct flow_match_ports match,
 			fltr->flags |= ICE_TC_FLWR_FIELD_ENC_SRC_L4_PORT;
 		else
 			fltr->flags |= ICE_TC_FLWR_FIELD_SRC_L4_PORT;
-		fltr->flags |= ICE_TC_FLWR_FIELD_SRC_L4_PORT;
+
 		headers->l4_key.src_port = match.key->src;
 		headers->l4_mask.src_port = match.mask->src;
 	}
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/1 ice: fix setting l4 port flag when adding filter

Quoted 4 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Michal Swiatkowski
Sent: Monday, January 3, 2022 12:11 PM

To: [email protected]

Quoted 6 lines

Subject: [Intel-wired-lan] [PATCH net] ice: fix setting l4 port flag when adding filter

Accidentally filter flag for none encapsulated l4 port filed is always set. Even if user wants to add encapsulated l4 port field.

Quoted 8 lines

Remove this unnecessary flag setting.

Fixes 9e300987d4a81 ("ice: VXLAN and Geneve TC support")

---
drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)