Skip to contentSkip to conversation

Fix reserved Feature bits numbering

PATCH In review Max Gurtovoy 3 participants 5 messages Jan 3, 2022 – Jan 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Fix reserved Feature bits numbering

This should have been updated during VIRTIO_F_NOTIFICATION_DATA, VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.

---

changes from v1:
- added "Reviewed-by" signature (Stefan)
- include VIRTIO_F_RING_RESET feature bit (Cornelia)

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index cf20570..32de668 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 40] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[41 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}
Signature · 1 line
2.21.0
#1 lore raw
Quoted 5 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA, VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.

Can you please also update the archive link in the issue, once the mail shows up there?

Quoted 17 lines

---

changes from v1:
- added "Reviewed-by" signature (Stefan)
- include VIRTIO_F_RING_RESET feature bit (Cornelia)

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index cf20570..32de668 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 10 lines
content.tex +2 -2
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 40] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[41 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}

LGTM.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#2 lore raw
Quoted 11 lines · Cornelia Huck
Quoted 5 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA, VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.

Can you please also update the archive link in the issue, once the mail shows up there?

Done.

Please let me know if there is something else, or you can take it from here ?

Quoted 30 lines
Quoted 18 lines

---

changes from v1:
- added "Reviewed-by" signature (Stefan)
- include VIRTIO_F_RING_RESET feature bit (Cornelia)

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index cf20570..32de668 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 10 lines
content.tex +2 -2
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 40] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[41 and above] Feature bits reserved for future extensions.
  \end{description}
 
  \begin{note}

LGTM.

#3 lore raw
In reply to Cornelia Huck
Quoted 5 lines · Cornelia Huck
Quoted 3 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA, VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.

Quoted 7 lines
Quoted 2 lines

Can you please also update the archive link in the issue, once the mail shows up there?

Wish we had a cleaner way to do it than updating this each time we add a generic feature bit.

Quoted 29 lines
Quoted 17 lines

---

changes from v1:
- added "Reviewed-by" signature (Stefan)
- include VIRTIO_F_RING_RESET feature bit (Cornelia)

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index cf20570..32de668 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 10 lines
content.tex +2 -2
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 40] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[41 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}

LGTM.

#4 lore raw
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Cornelia Huck
Quoted 5 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA, VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.

Quoted 8 lines
Quoted 4 lines

Can you please also update the archive link in the issue, once the mail shows up there?

Wish we had a cleaner way to do it than updating this each time we add a generic feature bit.

Indeed. But let's just go with this fixup until we come up with a better way.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/