Skip to contentSkip to conversation

buildtools: fix avx512 check for Python 3.5

PATCH Applied Lance Richardson 3 participants 3 messages Jan 3, 2022 – Jan 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildtools: fix avx512 check for Python 3.5

Python 3.5 subprocess.run() does not have a capture_output parameter (it is present only in 3.7 and up). Capture output by using subprocess.PIPE for stdout instead.

Fixes bb9cd91095b3 ("buildtools: make AVX512 check portable")
---
 buildtools/binutils-avx512-check.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
buildtools/binutils-avx512-check.py +1 -1
index a4e14f3593..9d7d360d95 100644
@@ -15,7 +15,7 @@
     src = '__asm__("vpgatherqq {}");'.format(gather_params).encode('utf-8')
     subprocess.run(cc + ['-c', '-xc', '-o', obj.name, '-'], input=src, check=True)
     asm = subprocess.run([objdump, '-d', '--no-show-raw-insn', obj.name],
-                         capture_output=True, check=True).stdout.decode('utf-8')
+                         stdout=subprocess.PIPE, check=True).stdout.decode('utf-8')
     if gather_params not in asm:
 	    print('vpgatherqq displacement error with as')
 	    sys.exit(1)
Signature · 1 line
2.25.1
#2 lore raw

03/01/2022 19:00, Dmitry Kozlyuk:

Quoted 10 lines

2022-01-03 12:09 (UTC-0500), Lance Richardson:

Quoted 7 lines

Python 3.5 subprocess.run() does not have a capture_output parameter (it is present only in 3.7 and up). Capture output by using subprocess.PIPE for stdout instead.

Fixes bb9cd91095b3 ("buildtools: make AVX512 check portable")

Applied, thanks.