Skip to contentSkip to conversation

mmc: sunxi-mmc: check ocr_avail on resource request

PATCH In review Michael Wu 3 participants 3 messages Jan 4, 2022 – Jan 12, 2022

Subsystems (2)
lore
Share & tools
lore

Michael Wu

author
#0 lore raw

PATCH v2 1/1 mmc: sunxi-mmc: check ocr_avail on resource request

Some platforms have no regulator, discrete power devices are used instead. However, sunxi_mmc_probe does not catch this exception when regulator is absent in DTS. This leads to sd or eMMC init failure.

To solve this, a fixed vmmc regulator must be hooked up in DTS, like this:

reg_dummy_vmmc: dummy_vmmc {
	compatible = "regulator-fixed";
	regulator-name = "dummy-vmmc";
	regulator-min-microvolt = <3300000>;
	regulator-max-microvolt = <3300000>;
};
mmc0:mmc@4020000 {
	compatible = "allwinner,sun50i-a100-emmc";
	device_type = "mmc0";
	vmmc-supply = <&reg_dummy_vmmc>;
}

In this patch, we print an error message and abort the probe process if the regulator is not specified in DTS.

---
 drivers/mmc/host/sunxi-mmc.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mmc/host/sunxi-mmc.c +5 -0
index 2702736a1c57..0da74bddaf87 100644
@@ -1300,6 +1300,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
 	if (ret)
 		return ret;
 
+	if (!host->mmc->ocr_avail) {
+		dev_err(&pdev->dev, "Could not get mmc regulator\n");
+		return -EINVAL;
+	}
+
 	host->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(host->reg_base))
 		return PTR_ERR(host->reg_base);
Signature · 1 line
2.29.0
#1 lore raw

Hi,

Quoted 1 line · Michael Wu

Some platforms have no regulator, discrete power devices are used instead.

Is it really the case? vmmc at least should be mandatory so a platform not having a regulator would violate the binding itself.

Quoted 2 lines

However, sunxi_mmc_probe does not catch this exception when regulator is absent in DTS. This leads to sd or eMMC init failure.

This will still happen with your patch though?

Quoted 8 lines

To solve this, a fixed vmmc regulator must be hooked up in DTS, like this:

reg_dummy_vmmc: dummy_vmmc {
	compatible = "regulator-fixed";
	regulator-name = "dummy-vmmc";
	regulator-min-microvolt = <3300000>;
	regulator-max-microvolt = <3300000>;
};
Quoted 8 lines
mmc0:mmc@4020000 {
	compatible = "allwinner,sun50i-a100-emmc";
	device_type = "mmc0";
	vmmc-supply = <&reg_dummy_vmmc>;
}

In this patch, we print an error message and abort the probe process if the regulator is not specified in DTS.

I'm fine with the patch itself, but it's really not clear to me what situation is being fixed or improved here.

You're first mentioning that this is fixing the driver probing even if a regulator is absent, but then states (rightfully) that in such a case we should use a fixed regulator. So we should always have a regulator then?

I assume that you want the driver to properly error out instead of going on if either a regulator is missing or if its voltages are out of range?

If the former, then we should probably check if host->mmc->supply.vmmc returned an error. If the latter, then yes, checking ocr_avail is probably fine but we should make it clearer in the error message that it's what it's about.

Maxime

#2 lore raw
Quoted 38 lines · Maxime Ripard

Hi,

Quoted 1 line · Michael Wu

Some platforms have no regulator, discrete power devices are used instead.

Is it really the case? vmmc at least should be mandatory so a platform not having a regulator would violate the binding itself.

Quoted 2 lines

However, sunxi_mmc_probe does not catch this exception when regulator is absent in DTS. This leads to sd or eMMC init failure.

This will still happen with your patch though?

Quoted 8 lines

To solve this, a fixed vmmc regulator must be hooked up in DTS, like this:

reg_dummy_vmmc: dummy_vmmc {
      compatible = "regulator-fixed";
      regulator-name = "dummy-vmmc";
      regulator-min-microvolt = <3300000>;
      regulator-max-microvolt = <3300000>;
};
Quoted 8 lines
mmc0:mmc@4020000 {
      compatible = "allwinner,sun50i-a100-emmc";
      device_type = "mmc0";
      vmmc-supply = <&reg_dummy_vmmc>;
}

In this patch, we print an error message and abort the probe process if the regulator is not specified in DTS.

I'm fine with the patch itself, but it's really not clear to me what situation is being fixed or improved here.

You're first mentioning that this is fixing the driver probing even if a regulator is absent, but then states (rightfully) that in such a case we should use a fixed regulator. So we should always have a regulator then?

Quoted 7 lines

I assume that you want the driver to properly error out instead of going on if either a regulator is missing or if its voltages are out of range?

If the former, then we should probably check if host->mmc->supply.vmmc returned an error. If the latter, then yes, checking ocr_avail is probably fine but we should make it clearer in the error message that it's what it's about.

Just wanted to mention that I just had a very similar discussion around another patch [1]. Please have a look at that discussion to get my opinion on this.

Kind regards
Uffe

[1]
https://patchwork.kernel.org/project/linux-mmc/patch/[email protected]/