debugfs: lockdown: Allow reading debugfs files that are not world readable
Subsystems (2)
PATCH 1/1 debugfs: lockdown: Allow reading debugfs files that are not world readable
When the kernel is locked down the kernel allows reading only debugfs files with mode 444. Mode 400 is also valid but is not allowed.
Make the 444 into a mask.
--- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/file.c +1 -1
@@ -147,7 +147,7 @@ static int debugfs_locked_down(struct inode *inode, struct file *filp, const struct file_operations *real_fops) { - if ((inode->i_mode & 07777) == 0444 && + if ((inode->i_mode & 07777 & ~0444) == 0 && !(filp->f_mode & FMODE_WRITE) && !real_fops->unlocked_ioctl && !real_fops->compat_ioctl &&
Signature · 1 line
2.31.1
Greg Kroah-Hartman
maintainerQuoted 11 lines · Michal Suchanek
When the kernel is locked down the kernel allows reading only debugfs files with mode 444. Mode 400 is also valid but is not allowed.
Make the 444 into a mask.
Fixes 5496197f9b08 ("debugfs: Restrict debugfs when the kernel is locked down")Signed-off-by Michal Suchanek <[email protected]>--- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Why has it taken so long for anyone to notice this (2 years!)?
Is that because no one uses the lockdown mode and tries to read debugfs files?
fs/debugfs/file.c static int debugfs_locked_down(struct inode *inode, · line 150
Quoted 11 lines
fs/debugfs/file.c +1
-1@@ -147,7 +147,7 @@ static int debugfs_locked_down(struct inode *inode, struct file *filp, const struct file_operations *real_fops) { - if ((inode->i_mode & 07777) == 0444 && + if ((inode->i_mode & 07777 & ~0444) == 0 &&
You are now allowing more than just 0400, is that intentional?
I never understood why files that were 0666 were not able to be read here as well, why not allow that as well? What was magic about 0444 files?
thanks,
greg k-h
Hello,
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Michal Suchanek
When the kernel is locked down the kernel allows reading only debugfs files with mode 444. Mode 400 is also valid but is not allowed.
Make the 444 into a mask.
Fixes 5496197f9b08 ("debugfs: Restrict debugfs when the kernel is locked down")Signed-off-by Michal Suchanek <[email protected]>--- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Why has it taken so long for anyone to notice this (2 years!)?
Is that because no one uses the lockdown mode and tries to read debugfs files?
It's because people use those LTSS kernels that don't have this change.
Quoted 13 lines
fs/debugfs/file.c static int debugfs_locked_down(struct inode *inode, · line 150
Quoted 11 lines
fs/debugfs/file.c +1
-1@@ -147,7 +147,7 @@ static int debugfs_locked_down(struct inode *inode, struct file *filp, const struct file_operations *real_fops) { - if ((inode->i_mode & 07777) == 0444 && + if ((inode->i_mode & 07777 & ~0444) == 0 &&You are now allowing more than just 0400, is that intentional?
The intent is to allow files that have permissions that are subset of 0444. The only one that makes sense and people complain about is 0400 but if you had 0440 or 0004 it would be permitted as well.
Quoted 3 lines
I never understood why files that were 0666 were not able to be read here as well, why not allow that as well? What was magic about 0444 files?
I don't understand that either but I am not really trying to challenge that part.
Thanks
Michal
Greg Kroah-Hartman
maintainerQuoted 41 lines · Michal Suchánek
Hello,
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Michal Suchanek
When the kernel is locked down the kernel allows reading only debugfs files with mode 444. Mode 400 is also valid but is not allowed.
Make the 444 into a mask.
Fixes 5496197f9b08 ("debugfs: Restrict debugfs when the kernel is locked down")Signed-off-by Michal Suchanek <[email protected]>--- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 4 lines
Why has it taken so long for anyone to notice this (2 years!)?
Is that because no one uses the lockdown mode and tries to read debugfs files?
It's because people use those LTSS kernels that don't have this change.
Quoted 13 lines
fs/debugfs/file.c static int debugfs_locked_down(struct inode *inode, · line 150
Quoted 11 lines
fs/debugfs/file.c +1
-1@@ -147,7 +147,7 @@ static int debugfs_locked_down(struct inode *inode, struct file *filp, const struct file_operations *real_fops) { - if ((inode->i_mode & 07777) == 0444 && + if ((inode->i_mode & 07777 & ~0444) == 0 &&You are now allowing more than just 0400, is that intentional?
The intent is to allow files that have permissions that are subset of 0444. The only one that makes sense and people complain about is 0400 but if you had 0440 or 0004 it would be permitted as well.
Quoted 6 lines
Quoted 3 lines
I never understood why files that were 0666 were not able to be read here as well, why not allow that as well? What was magic about 0444 files?
I don't understand that either but I am not really trying to challenge that part.
Fair enough. I don't care about the locked-down mode stuff, so I'll go queue this up now, thanks!
greg k-h