Set return code on failure
PATCH 1/1 Set return code on failure
From: Peter Foley <[email protected]>
Match the other error handling in this function.
--- net/tap.c | 1 + 1 file changed, 1 insertion(+)
net/tap.c +1 -0
@@ -900,6 +900,7 @@ int net_init_tap(const Netdev *netdev, const char *name,if (i ==0 ) { vnet_hdr =tap_probe_vnet_hdr (fd, errp);if (vnet_hdr <0 ) { + ret =-1 ; goto free_fail; } }else if (vnet_hdr !=tap_probe_vnet_hdr (fd,NULL )) {
Signature · 1 line
2.34.1.448.ga2b2bfdf31-goog
Quoted 4 lines · Patrick Venture
From: Peter Foley <[email protected]>
Match the other error handling in this function.
Just noticed I didn't fix up the commit title here to match style. Should I do a PATCH RESEND or a new patch, or can you add the "net/tap: " to the title before applying (should it be accepted).
Quoted 3 lines
Signed-off-by Peter Foley <[email protected]>
Quoted 21 lines
--- net/tap.c | 1 + 1 file changed, 1 insertion(+)net/tap.c +1
-0@@ -900,6 +900,7 @@ int net_init_tap(const Netdev *netdev, const char *name, if (i == 0) { vnet_hdr =tap_probe_vnet_hdr (fd, errp);if (vnet_hdr <0 ) { + ret =-1 ; goto free_fail; }} else if (vnet_hdr != tap_probe_vnet_hdr(fd, NULL)) {--
2.34.1.448.ga2b2bfdf31-goog
Re: [PATCH] net/tap: Set return code on failure
In reply to Patrick VentureCc'ing Daniel
Quoted 4 lines · Patrick Venture
From: Peter Foley <[email protected]>
Match the other error handling in this function.
Quoted 17 lines
Signed-off-by Peter Foley <[email protected]>--- net/tap.c | 1 + 1 file changed, 1 insertion(+)net/tap.c +1
-0@@ -900,6 +900,7 @@ int net_init_tap(const Netdev *netdev, const char *name,if (i ==0 ) { vnet_hdr =tap_probe_vnet_hdr (fd, errp);if (vnet_hdr <0 ) { + ret =-1 ; goto free_fail; } }else if (vnet_hdr !=tap_probe_vnet_hdr (fd,NULL )) {
Quoted 11 lines · Patrick Venture
Quoted 4 lines · Patrick Venture
From: Peter Foley <[email protected]>
Match the other error handling in this function.
Just noticed I didn't fix up the commit title here to match style. Should I do a PATCH RESEND or a new patch, or can you add the "net/tap: " to the title before applying (should it be accepted).
Please resend.
Thanks
Quoted 26 lines
Quoted 4 lines
Signed-off-by Peter Foley <[email protected]>Reviewed-by Patrick Venture <[email protected]>Quoted 20 lines
--- net/tap.c | 1 + 1 file changed, 1 insertion(+)net/tap.c +1
-1@@ -900,6 +900,7 @@ int net_init_tap(const Netdev *netdev, const char *name,if (i ==0 ) { vnet_hdr =tap_probe_vnet_hdr (fd, errp);if (vnet_hdr <0 ) { + ret =-1 ; goto free_fail; } }else if (vnet_hdr !=tap_probe_vnet_hdr (fd,NULL )) { --2.34.1.448.ga2b2bfdf31-goog