git-p4: don't allow cloning into non-empty directories
PATCH 1/1 git-p4: don't allow cloning into non-empty directories
Previously, git-p4 would allow users to clone a Perforce repository into a pre-existing git repository. When attempting this, git-p4 would download the Perforce commits (a time consuming process), and would fail at the end during the final git fast-import with a cryptic error message.
This was easy to do inadvertently when running the same git-p4 clone command more than once.
This patch changes the behaviour of git-p4.py so that it matches that of git itself: disallowing all clones into non-empty directories.
Signed-off-by Joel Holdsworth <[email protected]>
--- git-p4.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
git-p4.py +10 -3
@@ -4099,12 +4099,19 @@ def run(self, args): if not self.cloneDestination: self.cloneDestination = self.defaultDestination(args) - print("Importing from %s into %s" % (', '.join(depotPaths), self.cloneDestination)) - - if not os.path.exists(self.cloneDestination): + if os.path.exists(self.cloneDestination): + if (not os.path.isdir(self.cloneDestination) or + os.listdir(self.cloneDestination)): + die( + "fatal: destination path '{}' already exists and is not " + "an empty directory.".format(self.cloneDestination)) + else: os.makedirs(self.cloneDestination) chdir(self.cloneDestination) + print("Importing from {} into {}".format( + ', '.join(depotPaths), self.cloneDestination)) + init_cmd = [ "git", "init" ] if self.cloneBare: init_cmd.append("--bare")
Signature · 1 line
2.34.1