Skip to contentSkip to conversation

configure: Fix use of obsolete macros

PATCH In review Luiz Augusto von Dentz 2 participants 3 messages Jan 5, 2022 – Jan 7, 2022 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 configure: Fix use of obsolete macros

From: Luiz Augusto von Dentz <[email protected]>

This fixes the following warnings when using autoconf >= 2.70:

configure.ac:19: warning: The macro AC_LANG_C' is obsolete. configure.ac:45: warning: The macro AC_HELP_STRING' is obsolete. configure.ac:440: warning: AC_OUTPUT should be used without arguments.

The macros are replacing following the autoconf documentation:

https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html

---
 acinclude.m4 | 12 ++++----
 configure.ac | 87 ++++++++++++++++++++++++++--------------------------
 2 files changed, 50 insertions(+), 49 deletions(-)
acinclude.m4 +6 -6
index b388dfc11..c5d6de7b3 100644
@@ -71,13 +71,13 @@ AC_DEFUN([COMPILER_FLAGS], [
 AC_DEFUN([MISC_FLAGS], [
 	misc_cflags=""
 	misc_ldflags=""
-	AC_ARG_ENABLE(optimization, AC_HELP_STRING([--disable-optimization],
+	AC_ARG_ENABLE(optimization, AS_HELP_STRING([--disable-optimization],
 			[disable code optimization through compiler]), [
 		if (test "${enableval}" = "no"); then
 			misc_cflags="$misc_cflags -O0"
 		fi
 	])
-	AC_ARG_ENABLE(asan, AC_HELP_STRING([--enable-asan],
+	AC_ARG_ENABLE(asan, AS_HELP_STRING([--enable-asan],
 			[enable linking with address sanitizer]), [
 		save_LIBS=$LIBS
 		AC_CHECK_LIB(asan, _init)
@@ -90,7 +90,7 @@ AC_DEFUN([MISC_FLAGS], [
 			AC_SUBST([ASAN_LIB], ${ac_cv_lib_asan__init})
 		fi
 	])
-	AC_ARG_ENABLE(lsan, AC_HELP_STRING([--enable-lsan],
+	AC_ARG_ENABLE(lsan, AS_HELP_STRING([--enable-lsan],
 			[enable linking with address sanitizer]), [
 		save_LIBS=$LIBS
 		AC_CHECK_LIB(lsan, _init)
@@ -103,7 +103,7 @@ AC_DEFUN([MISC_FLAGS], [
 			AC_SUBST([ASAN_LIB], ${ac_cv_lib_lsan__init})
 		fi
 	])
-	AC_ARG_ENABLE(ubsan, AC_HELP_STRING([--enable-ubsan],
+	AC_ARG_ENABLE(ubsan, AS_HELP_STRING([--enable-ubsan],
 			[enable linking with address sanitizer]), [
 		save_LIBS=$LIBS
 		AC_CHECK_LIB(ubsan, _init)
@@ -115,14 +115,14 @@ AC_DEFUN([MISC_FLAGS], [
 			misc_ldflags="$misc_ldflags -fsanitize=undefined";
 		fi
 	])
-	AC_ARG_ENABLE(debug, AC_HELP_STRING([--enable-debug],
+	AC_ARG_ENABLE(debug, AS_HELP_STRING([--enable-debug],
 			[enable compiling with debugging information]), [
 		if (test "${enableval}" = "yes" &&
 				test "${ac_cv_prog_cc_g}" = "yes"); then
 			misc_cflags="$misc_cflags -g"
 		fi
 	])
-	AC_ARG_ENABLE(pie, AC_HELP_STRING([--enable-pie],
+	AC_ARG_ENABLE(pie, AS_HELP_STRING([--enable-pie],
 			[enable position independent executables flag]), [
 		if (test "${enableval}" = "yes" &&
 				test "${ac_cv_prog_cc_pie}" = "yes"); then
configure.ac +44 -43

283 lines not on this page · raw message

Signature · 1 line
2.33.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=603033

---Test result---

Test Summary:

CheckPatch                    FAIL      1.58 seconds
GitLint                       FAIL      1.11 seconds
Prep - Setup ELL              PASS      43.34 seconds
Build - Prep                  PASS      0.68 seconds
Build - Configure             PASS      8.63 seconds
Build - Make                  PASS      1436.54 seconds
Make Check                    PASS      11.94 seconds
Make Check w/Valgrind         PASS      451.87 seconds
Make Distcheck                PASS      237.29 seconds
Build w/ext ELL - Configure   PASS      8.83 seconds
Build w/ext ELL - Make        PASS      1406.07 seconds
Incremental Build with patchesPASS      0.00 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] configure: Fix use of obsolete macros
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #86:
https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html

/github/workspace/src/12704810.patch total: 0 errors, 1 warnings, 330 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12704810.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ] configure: Fix use of obsolete macros
13: B1 Line exceeds max length (89>80): "https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html"

---
Regards,
Linux Bluetooth

author maintainer
#2 lore raw

Hi,

Quoted 58 lines · On Wed, Jan 5, 2022 at 3:46 PM <[email protected]> wrote:

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=603033

---Test result---

Test Summary:

CheckPatch                    FAIL      1.58 seconds
GitLint                       FAIL      1.11 seconds
Prep - Setup ELL              PASS      43.34 seconds
Build - Prep                  PASS      0.68 seconds
Build - Configure             PASS      8.63 seconds
Build - Make                  PASS      1436.54 seconds
Make Check                    PASS      11.94 seconds
Make Check w/Valgrind         PASS      451.87 seconds
Make Distcheck                PASS      237.29 seconds
Build w/ext ELL - Configure   PASS      8.83 seconds
Build w/ext ELL - Make        PASS      1406.07 seconds
Incremental Build with patchesPASS      0.00 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] configure: Fix use of obsolete macros
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #86:
https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html

/github/workspace/src/12704810.patch total: 0 errors, 1 warnings, 330 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12704810.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ] configure: Fix use of obsolete macros
13: B1 Line exceeds max length (89>80): "https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html"

Quoted 3 lines

---
Regards,
Linux Bluetooth

Pushed.

Signature · 1 line
Luiz Augusto von Dentz