Skip to contentSkip to conversation

x86/quirks: Fix logic to apply quirk once

PATCH In review Lucas De Marchi 3 participants 9 messages Jan 6, 2022 – Jan 7, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 x86/quirks: Fix logic to apply quirk once

When using QFLAG_APPLY_ONCE we make sure the quirk is called only once. This is useful when it's enough one device to trigger a certain condition or when the resource in each that applies is global to the system rather than local to the device.

However we call the quirk handler based on vendor, class, and device, allowing the specific handler to do additional filtering. In that case check_dev_quirk() may incorrectly mark the quirk as applied when it's
not: the quirk was called, but may not have been applied due to the additional filter.

This is particularly bad for intel_graphics_quirks() that uses PCI_ANY_ID and then compares with a long list of devices. This hasn't been problematic so far because those devices are integrated GPUs and there can only be one in the system. However as Intel starts to release discrete cards, this condition is no longer true and we fail to reserve the stolen memory (for the integrated GPU) depending on the bus
topology: if the traversal finds the discrete card first, for which there is no system stolen memory, we will fail to reserve it for the integrated card.

This fixes the stolen memory reservation for an Alderlake-P system with one additional Intel discrete GPU (DG2 in this case, but applies for any of them). In this system we have:

- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Alderlake-P's integrated GPU

Since we do a depth-first traversal, when we call the handler because of DG2 we were marking it as already being applied and never reserving the stolen memory for Alderlake-P.

Since there are just a few quirks using the QFLAG_APPLY_ONCE logic and that is even the only flag, just use a static local variable in the quirk function itself. This allows to mark the quirk as applied only when it really is. As pointed out by Bjorn Helgaas, this is also more in line with the PCI fixups as done by pci_do_fixups().

---

v2: instead of changing all quirks to return if it was successfully applied, remove the flag infra and use a static local variable to mark quirks already applied (suggested by Bjorn Helgaas).

 arch/x86/kernel/early-quirks.c | 60 ++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 24 deletions(-)
arch/x86/kernel/early-quirks.c +36 -24
index 391a4e2b8604..102ecd0a910e 100644
@@ -57,12 +57,18 @@ static void __init fix_hypertransport_config(int num, int slot, int func)
 static void __init via_bugs(int  num, int slot, int func)
 {
 #ifdef CONFIG_GART_IOMMU
+	static bool quirk_applied __initdata;
+
+	if (quirk_applied)
+		return;
+
 	if ((max_pfn > MAX_DMA32_PFN ||  force_iommu) &&
 	    !gart_iommu_aperture_allowed) {
 		printk(KERN_INFO
 		       "Looks like a VIA chipset. Disabling IOMMU."
 		       " Override with iommu=allowed\n");
 		gart_iommu_aperture_disabled = 1;
+		quirk_applied = true;
 	}
 #endif
 }
@@ -81,6 +87,11 @@ static void __init nvidia_bugs(int num, int slot, int func)
 {
 #ifdef CONFIG_ACPI
 #ifdef CONFIG_X86_IO_APIC
+	static bool quirk_applied __initdata;
+
+	if (quirk_applied)
+		return;
+
 	/*
 	 * Only applies to Nvidia root ports (bus 0) and not to
 	 * Nvidia graphics cards with PCI ports on secondary buses.
@@ -105,6 +116,7 @@ static void __init nvidia_bugs(int num, int slot, int func)
 		       "timer override.\n");
 		printk(KERN_INFO "If you got timer trouble "
 			"try acpi_use_timer_override\n");
+		quirk_applied = true;
 	}
 #endif
 #endif
@@ -559,7 +571,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
 struct resource intel_graphics_stolen_res __ro_after_init = DEFINE_RES_MEM(0, 0);
 EXPORT_SYMBOL(intel_graphics_stolen_res);
 
-static void __init
+static bool __init
 intel_graphics_stolen(int num, int slot, int func,
 		      const struct intel_early_ops *early_ops)
 {
@@ -570,7 +582,7 @@ intel_graphics_stolen(int num, int slot, int func,
 	base = early_ops->stolen_base(num, slot, func, size);
 
 	if (!size || !base)
-		return;
+		return false;
 
 	end = base + size - 1;
 
@@ -583,14 +595,20 @@ intel_graphics_stolen(int num, int slot, int func,
 	/* Mark this space as reserved */
 	e820__range_add(base, size, E820_TYPE_RESERVED);
 	e820__update_table(e820_table);
+
+	return true;
 }
 
 static void __init intel_graphics_quirks(int num, int slot, int func)
 {
+	static bool quirk_applied __initdata;
 	const struct intel_early_ops *early_ops;
 	u16 device;
 	int i;
 
+	if (quirk_applied)
+		return;
+
 	device = read_pci_config_16(num, slot, func, PCI_DEVICE_ID);
 
 	for (i = 0; i < ARRAY_SIZE(intel_early_ids); i++) {
@@ -601,7 +619,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func)
 
 		early_ops = (typeof(early_ops))driver_data;
 
-		intel_graphics_stolen(num, slot, func, early_ops);
+		quirk_applied = intel_graphics_stolen(num, slot, func,
+						      early_ops);
 
 		return;
 	}
@@ -673,37 +692,33 @@ static void __init apple_airport_reset(int bus, int slot, int func)
 	early_iounmap(mmio, BCM4331_MMIO_SIZE);
 }
 
-#define QFLAG_APPLY_ONCE 	0x1
-#define QFLAG_APPLIED		0x2
-#define QFLAG_DONE		(QFLAG_APPLY_ONCE|QFLAG_APPLIED)
 struct chipset {
 	u32 vendor;
 	u32 device;
 	u32 class;
 	u32 class_mask;
-	u32 flags;
 	void (*f)(int num, int slot, int func);
 };
 
 static struct chipset early_qrk[] __initdata = {
 	{ PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
-	  PCI_CLASS_BRIDGE_PCI, PCI_ANY_ID, QFLAG_APPLY_ONCE, nvidia_bugs },
+	  PCI_CLASS_BRIDGE_PCI, PCI_ANY_ID, nvidia_bugs },
 	{ PCI_VENDOR_ID_VIA, PCI_ANY_ID,
-	  PCI_CLASS_BRIDGE_PCI, PCI_ANY_ID, QFLAG_APPLY_ONCE, via_bugs },
+	  PCI_CLASS_BRIDGE_PCI, PCI_ANY_ID, via_bugs },
 	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB,
-	  PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, fix_hypertransport_config },
+	  PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, fix_hypertransport_config },
 	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_SMBUS,
-	  PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs },
+	  PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, ati_bugs },
 	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS,
-	  PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs_contd },
+	  PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, ati_bugs_contd },
 	{ PCI_VENDOR_ID_INTEL, 0x3403, PCI_CLASS_BRIDGE_HOST,
-	  PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check },
+	  PCI_BASE_CLASS_BRIDGE, intel_remapping_check },
 	{ PCI_VENDOR_ID_INTEL, 0x3405, PCI_CLASS_BRIDGE_HOST,
-	  PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check },
+	  PCI_BASE_CLASS_BRIDGE, intel_remapping_check },
 	{ PCI_VENDOR_ID_INTEL, 0x3406, PCI_CLASS_BRIDGE_HOST,
-	  PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check },
+	  PCI_BASE_CLASS_BRIDGE, intel_remapping_check },
 	{ PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA, PCI_ANY_ID,
-	  QFLAG_APPLY_ONCE, intel_graphics_quirks },
+	  intel_graphics_quirks },
 	/*
 	 * HPET on the current version of the Baytrail platform has accuracy
 	 * problems: it will halt in deep idle state - so we disable it.
@@ -713,9 +728,9 @@ static struct chipset early_qrk[] __initdata = {
 	 *    http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/atom-z8000-datasheet-vol-1.pdf
 	 */
 	{ PCI_VENDOR_ID_INTEL, 0x0f00,
-		PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
+		PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, force_disable_hpet},
 	{ PCI_VENDOR_ID_BROADCOM, 0x4331,
-	  PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset},
+	  PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, apple_airport_reset},
 	{}
 };
 
@@ -756,12 +771,9 @@ static int __init check_dev_quirk(int num, int slot, int func)
 			((early_qrk[i].device == PCI_ANY_ID) ||
 			(early_qrk[i].device == device)) &&
 			(!((early_qrk[i].class ^ class) &
-			    early_qrk[i].class_mask))) {
-				if ((early_qrk[i].flags &
-				     QFLAG_DONE) != QFLAG_DONE)
-					early_qrk[i].f(num, slot, func);
-				early_qrk[i].flags |= QFLAG_APPLIED;
-			}
+			    early_qrk[i].class_mask)))
+				early_qrk[i].f(num, slot, func);
+
 	}
 
 	type = read_pci_config_byte(num, slot, func,

base-commit: c9e6606c7fe92b50a02ce51dda82586ebdf99b48

Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 2/2 x86/quirks: better wrap quirk conditions

Remove extra parenthesis and wrap lines so it's easier to read what are the conditions being checked. The call to the hook also had an extra
indentation: remove here to conform to coding style.

---
 arch/x86/kernel/early-quirks.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
arch/x86/kernel/early-quirks.c +6 -8
index 102ecd0a910e..03256f802aba 100644
@@ -766,14 +766,12 @@ static int __init check_dev_quirk(int num, int slot, int func)
 	device = read_pci_config_16(num, slot, func, PCI_DEVICE_ID);
 
 	for (i = 0; early_qrk[i].f != NULL; i++) {
-		if (((early_qrk[i].vendor == PCI_ANY_ID) ||
-			(early_qrk[i].vendor == vendor)) &&
-			((early_qrk[i].device == PCI_ANY_ID) ||
-			(early_qrk[i].device == device)) &&
-			(!((early_qrk[i].class ^ class) &
-			    early_qrk[i].class_mask)))
-				early_qrk[i].f(num, slot, func);
-
+		if ((early_qrk[i].vendor == PCI_ANY_ID ||
+		     early_qrk[i].vendor == vendor) &&
+		    (early_qrk[i].device == PCI_ANY_ID ||
+		     early_qrk[i].device == device) &&
+		    !((early_qrk[i].class ^ class) & early_qrk[i].class_mask))
+			early_qrk[i].f(num, slot, func);
 	}
 
 	type = read_pci_config_byte(num, slot, func,
Signature · 1 line
2.34.1
#2 lore raw

Re: [Intel-gfx] [PATCH v2 2/2] x86/quirks: better wrap quirk conditions

Quoted 3 lines · Lucas De Marchi

Remove extra parenthesis and wrap lines so it's easier to read what are the conditions being checked. The call to the hook also had an extra
indentation: remove here to conform to coding style.

It's nice when your subject lines are consistent. These look like:

x86/quirks: Fix logic to apply quirk once
x86/quirks: better wrap quirk conditions

The second isn't capitalized like the first. Obviously if you split the first patch, you'll have three subject lines, and one will mention Alderlake.

Bjorn

#3 lore raw

Re: [Intel-gfx] [PATCH v2 2/2] x86/quirks: better wrap quirk conditions

Quoted 11 lines · Bjorn Helgaas
Quoted 3 lines · Lucas De Marchi

Remove extra parenthesis and wrap lines so it's easier to read what are the conditions being checked. The call to the hook also had an extra
indentation: remove here to conform to coding style.

It's nice when your subject lines are consistent. These look like:

x86/quirks: Fix logic to apply quirk once
x86/quirks: better wrap quirk conditions

The second isn't capitalized like the first. Obviously if you split

trying to maintain the entropy from

	git log --oneline --no-merges -- arch/x86/kernel/early-quirks.c

:). Jokes aside, yeah, my bad.

Quoted 2 lines

the first patch, you'll have three subject lines, and one will mention Alderlake.

See my reply to the first patch - Alderlake is only the reproducer, but it's broken in other platforms as well, as long as it's paired with an Intel discrete gpu in the "right" pci slot.

It would be weird to send a patch "Fix xyz in Alderlake" and then telling people with the same problem in Icelake that they are missing that fix. So I went with the approach: 1) what is the generic problem; 2) where it was initially reproduced.

thanks
Lucas De Marchi

Quoted 2 lines

Bjorn

#4 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once
URL : https://patchwork.freedesktop.org/series/98523/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11051 -> Patchwork_21929
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/index.html

Participating hosts (46 -> 31)
------------------------------

Additional (1): fi-pnv-d510
Missing (16): fi-kbl-soraka bat-adls-5 bat-dg1-6 bat-dg1-5 fi-bsw-n3050 fi-tgl-dsi fi-icl-u2 fi-bwr-2160 bat-adlp-6 fi-bsw-cyan fi-bsw-kefka bat-rpls-1 fi-bdw-samus bat-jsl-2 fi-bsw-nick bat-jsl-1

Known issues
------------

Here are the changes found in Patchwork_21929 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-snb-2600/igt@amdgpu/[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- fi-tgl-1115g4: [PASS][2] -> [FAIL][3] ([i915#1888])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@hugepages:
- fi-snb-2520m: [PASS][4] -> [DMESG-FAIL][5] ([i915#4610])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/fi-snb-2520m/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-snb-2520m/igt@i915_selftest@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#4269])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/fi-cml-u2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-cml-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +57 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-pnv-d510/igt@[email protected]

* igt@runner@aborted:
- fi-snb-2520m: NOTRUN -> [FAIL][9] ([i915#2426] / [i915#4312])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-snb-2520m/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@reset:
- fi-snb-2600: [DMESG-FAIL][10] ([i915#4610]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/fi-snb-2600/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-snb-2600/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [INCOMPLETE][12] ([i915#4547] / [i915#4838]) -> [FAIL][13] ([i915#4547])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

* igt@runner@aborted:
- fi-skl-6600u: [FAIL][14] ([i915#2722] / [i915#4312]) -> [FAIL][15] ([i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/fi-skl-6600u/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/fi-skl-6600u/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4610]: https://gitlab.freedesktop.org/drm/intel/issues/4610
[i915#4838]: https://gitlab.freedesktop.org/drm/intel/issues/4838

Build changes
-------------

* Linux: CI_DRM_11051 -> Patchwork_21929

CI-20190529: 20190529
CI_DRM_11051: 9b0d7ca3667904f5d5ba802c5d7c840db46de5f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6323: 9dbaa0d5be7a859cda9b7d54c20ba96a596f43bd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21929: 5f1881f1ab58fdf136e766b319a9cc0bdedab16c @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5f1881f1ab58 x86/quirks: better wrap quirk conditions 82b222891e10 x86/quirks: Fix logic to apply quirk once

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/index.html

#5 lore raw
In reply to Lucas De Marchi
Quoted 54 lines · Lucas De Marchi

When using QFLAG_APPLY_ONCE we make sure the quirk is called only once. This is useful when it's enough one device to trigger a certain condition or when the resource in each that applies is global to the system rather than local to the device.

However we call the quirk handler based on vendor, class, and device, allowing the specific handler to do additional filtering. In that case check_dev_quirk() may incorrectly mark the quirk as applied when it's
not: the quirk was called, but may not have been applied due to the additional filter.

This is particularly bad for intel_graphics_quirks() that uses PCI_ANY_ID and then compares with a long list of devices. This hasn't been problematic so far because those devices are integrated GPUs and there can only be one in the system. However as Intel starts to release discrete cards, this condition is no longer true and we fail to reserve the stolen memory (for the integrated GPU) depending on the bus
topology: if the traversal finds the discrete card first, for which there is no system stolen memory, we will fail to reserve it for the integrated card.

This fixes the stolen memory reservation for an Alderlake-P system with one additional Intel discrete GPU (DG2 in this case, but applies for any of them). In this system we have:

- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Alderlake-P's integrated GPU

Since we do a depth-first traversal, when we call the handler because of DG2 we were marking it as already being applied and never reserving the stolen memory for Alderlake-P.

Since there are just a few quirks using the QFLAG_APPLY_ONCE logic and that is even the only flag, just use a static local variable in the quirk function itself. This allows to mark the quirk as applied only when it really is. As pointed out by Bjorn Helgaas, this is also more in line with the PCI fixups as done by pci_do_fixups().

---

v2: instead of changing all quirks to return if it was successfully applied, remove the flag infra and use a static local variable to mark quirks already applied (suggested by Bjorn Helgaas).

 arch/x86/kernel/early-quirks.c | 60 ++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 24 deletions(-)
arch/x86/kernel/early-quirks.c +0 -0
index 391a4e2b8604..102ecd0a910e 100644

arch/x86/kernel/early-quirks.c static void __init fix_hypertransport_config(int num, int slot, int func) · line 63

Quoted 7 lines
arch/x86/kernel/early-quirks.c +4 -0
@@ -57,12 +57,18 @@ static void __init fix_hypertransport_config(int num, int slot, int func)
 static void __init via_bugs(int  num, int slot, int func)
 {
 #ifdef CONFIG_GART_IOMMU
+	static bool quirk_applied __initdata;
+
+	if (quirk_applied)
+		return;

IMO this probably is better than using QFLAG_APPLY_ONCE, etc.

But this patch has the mechanical changes related to QFLAG_APPLY_ONCE, which I think are useful but not very interesting and not a fix for something that's broken, mixed together with the *important* change that actually fixes a problem on Alderlake.

Those two things need to be separate patches. A patch that fixes a problem should be as small as possible so it's easy to understand and backport.

The subject line of this patch doesn't say anything at all about Alderlake. Splitting into two patches will make the subject lines more useful.

Bjorn

#6 lore raw
Quoted 65 lines · Bjorn Helgaas
Quoted 54 lines · Lucas De Marchi

When using QFLAG_APPLY_ONCE we make sure the quirk is called only once. This is useful when it's enough one device to trigger a certain condition or when the resource in each that applies is global to the system rather than local to the device.

However we call the quirk handler based on vendor, class, and device, allowing the specific handler to do additional filtering. In that case check_dev_quirk() may incorrectly mark the quirk as applied when it's
not: the quirk was called, but may not have been applied due to the additional filter.

This is particularly bad for intel_graphics_quirks() that uses PCI_ANY_ID and then compares with a long list of devices. This hasn't been problematic so far because those devices are integrated GPUs and there can only be one in the system. However as Intel starts to release discrete cards, this condition is no longer true and we fail to reserve the stolen memory (for the integrated GPU) depending on the bus
topology: if the traversal finds the discrete card first, for which there is no system stolen memory, we will fail to reserve it for the integrated card.

This fixes the stolen memory reservation for an Alderlake-P system with one additional Intel discrete GPU (DG2 in this case, but applies for any of them). In this system we have:

- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Alderlake-P's integrated GPU

Since we do a depth-first traversal, when we call the handler because of DG2 we were marking it as already being applied and never reserving the stolen memory for Alderlake-P.

Since there are just a few quirks using the QFLAG_APPLY_ONCE logic and that is even the only flag, just use a static local variable in the quirk function itself. This allows to mark the quirk as applied only when it really is. As pointed out by Bjorn Helgaas, this is also more in line with the PCI fixups as done by pci_do_fixups().

---

v2: instead of changing all quirks to return if it was successfully applied, remove the flag infra and use a static local variable to mark quirks already applied (suggested by Bjorn Helgaas).

 arch/x86/kernel/early-quirks.c | 60 ++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 24 deletions(-)
arch/x86/kernel/early-quirks.c +0 -0
index 391a4e2b8604..102ecd0a910e 100644

arch/x86/kernel/early-quirks.c static void __init fix_hypertransport_config(int num, int slot, int func) · line 63

Quoted 7 lines
arch/x86/kernel/early-quirks.c +4 -0
@@ -57,12 +57,18 @@ static void __init fix_hypertransport_config(int num, int slot, int func)
 static void __init via_bugs(int  num, int slot, int func)
 {
 #ifdef CONFIG_GART_IOMMU
+	static bool quirk_applied __initdata;
+
+	if (quirk_applied)
+		return;

IMO this probably is better than using QFLAG_APPLY_ONCE, etc.

Quoted 4 lines

But this patch has the mechanical changes related to QFLAG_APPLY_ONCE, which I think are useful but not very interesting and not a fix for something that's broken, mixed together with the *important* change that actually fixes a problem on Alderlake.

In general I agree with the statement and also ask people to follow that logic, but here I thought it was small enough to be considered as a whole. Here is what I could do to split it up further in a way that is not going in a different direction:

1) add the static local only to intel graphics quirk and remove the flag from this item
2 and 3) add the static local to other functions and remove the flag from those items
4) remove the flag from the table, the defines and its usage.
5) fix the coding style (to be clear, it's already wrong, not something wrong introduced here... maybe could be squashed in (4)?)

thoughts?

Quoted 8 lines

Those two things need to be separate patches. A patch that fixes a problem should be as small as possible so it's easy to understand and backport.

The subject line of this patch doesn't say anything at all about Alderlake. Splitting into two patches will make the subject lines more useful.

Alderlake is the platform in which it was reproduced, but could very well be any other platform with Intel integrated graphics + Intel discrete graphics. So I described the concrete reproducer in the commit message rather than giving the impression this would be the only case the current logic is broken.

thanks,
Lucas De Marchi

Quoted 2 lines

Bjorn

#7 lore raw
Quoted 76 lines · Lucas De Marchi
Quoted 65 lines · Bjorn Helgaas
Quoted 54 lines · Lucas De Marchi

When using QFLAG_APPLY_ONCE we make sure the quirk is called only once. This is useful when it's enough one device to trigger a certain condition or when the resource in each that applies is global to the system rather than local to the device.

However we call the quirk handler based on vendor, class, and device, allowing the specific handler to do additional filtering. In that case check_dev_quirk() may incorrectly mark the quirk as applied when it's
not: the quirk was called, but may not have been applied due to the additional filter.

This is particularly bad for intel_graphics_quirks() that uses PCI_ANY_ID and then compares with a long list of devices. This hasn't been problematic so far because those devices are integrated GPUs and there can only be one in the system. However as Intel starts to release discrete cards, this condition is no longer true and we fail to reserve the stolen memory (for the integrated GPU) depending on the bus
topology: if the traversal finds the discrete card first, for which there is no system stolen memory, we will fail to reserve it for the integrated card.

This fixes the stolen memory reservation for an Alderlake-P system with one additional Intel discrete GPU (DG2 in this case, but applies for any of them). In this system we have:

- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Alderlake-P's integrated GPU

Since we do a depth-first traversal, when we call the handler because of DG2 we were marking it as already being applied and never reserving the stolen memory for Alderlake-P.

Since there are just a few quirks using the QFLAG_APPLY_ONCE logic and that is even the only flag, just use a static local variable in the quirk function itself. This allows to mark the quirk as applied only when it really is. As pointed out by Bjorn Helgaas, this is also more in line with the PCI fixups as done by pci_do_fixups().

---

v2: instead of changing all quirks to return if it was successfully applied, remove the flag infra and use a static local variable to mark quirks already applied (suggested by Bjorn Helgaas).

 arch/x86/kernel/early-quirks.c | 60 ++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 24 deletions(-)
arch/x86/kernel/early-quirks.c +0 -0
index 391a4e2b8604..102ecd0a910e 100644

arch/x86/kernel/early-quirks.c static void __init fix_hypertransport_config(int num, int slot, int func) · line 63

Quoted 7 lines
arch/x86/kernel/early-quirks.c +4 -0
@@ -57,12 +57,18 @@ static void __init fix_hypertransport_config(int num, int slot, int func)
 static void __init via_bugs(int  num, int slot, int func)
 {
 #ifdef CONFIG_GART_IOMMU
+	static bool quirk_applied __initdata;
+
+	if (quirk_applied)
+		return;

IMO this probably is better than using QFLAG_APPLY_ONCE, etc.

Quoted 4 lines

But this patch has the mechanical changes related to QFLAG_APPLY_ONCE, which I think are useful but not very interesting and not a fix for something that's broken, mixed together with the *important* change that actually fixes a problem on Alderlake.

In general I agree with the statement and also ask people to follow that logic, but here I thought it was small enough to be considered as a whole. Here is what I could do to split it up further in a way that is not going in a different direction:

Quoted 7 lines

1) add the static local only to intel graphics quirk and remove the flag from this item
2 and 3) add the static local to other functions and remove the flag from those items
4) remove the flag from the table, the defines and its usage.
5) fix the coding style (to be clear, it's already wrong, not something wrong introduced here... maybe could be squashed in (4)?)

I would make this two patches:

1) Add static locals to all QFLAG_APPLY_ONCE quirks and remove QFLAG_APPLY_ONCE etc. This patch is mechanical and shouldn't break or fix anything.

2) Update the intel graphics quirk to change the way it sets the static local. Make the subject be something about fixing the problem with Intel integrated + discrete graphics.

#8 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once
URL : https://patchwork.freedesktop.org/series/98523/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11051_full -> Patchwork_21929_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_21929_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_21929_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (13 -> 13)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_21929_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-skl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_exec_schedule@u-submit-early-slice@bcs0:
- {shard-tglu}: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-tglu-5/igt@gem_exec_schedule@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglu-7/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_whisper@basic-contexts-forked:
- {shard-rkl}: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-rkl-5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-rkl-5/igt@[email protected]

* igt@gem_exec_whisper@basic-fds-priority-all:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-rkl-5/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_21929_full that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- shard-apl: ([PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32]) -> ([PASS][33], [FAIL][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57]) ([i915#4386])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl1/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl2/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl2/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl2/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl6/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl6/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl6/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl7/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl1/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl2/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl2/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl2/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl4/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl6/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl6/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl7/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl7/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl7/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl7/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl8/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl8/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl8/boot.html

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#658])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-iclb2/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb8/igt@[email protected]

* igt@gem_create@create-massive:
- shard-tglb: NOTRUN -> [DMESG-WARN][60] ([i915#3002] / [i915#4856])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb5/igt@[email protected]

* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][61] -> [SKIP][62] ([i915#4525])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-iclb4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb5/igt@[email protected]

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#4525])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][64] -> [INCOMPLETE][65] ([i915#4547])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-skl4/igt@gem_exec_capture@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl10/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: [PASS][66] -> [FAIL][67] ([i915#2842]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-tglb6/igt@gem_exec_fair@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [PASS][68] -> [FAIL][69] ([i915#2842])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-kbl4/igt@gem_exec_fair@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][70] -> [FAIL][71] ([i915#2842])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-glk3/igt@gem_exec_fair@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-glk7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][72] ([i915#2842])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109283])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][74] -> [SKIP][75] ([i915#2190])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-tglb8/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb7/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#4613]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl4/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#4613]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl3/igt@[email protected]

* igt@gem_lmem_swapping@smem-oom:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#4613])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb5/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][79] ([i915#2658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl8/igt@[email protected]
- shard-skl: NOTRUN -> [WARN][80] ([i915#2658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl7/igt@[email protected]

* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][81] ([i915#4270])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#768])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109290])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#3323])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][85] ([i915#3318])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][86] -> [DMESG-WARN][87] ([i915#1436] / [i915#716])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl7/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl1/igt@[email protected]

* igt@gen9_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#2856])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][89] ([i915#454])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@[email protected]

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271]) +60 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl7/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][91] ([i915#1886] / [i915#2291])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl7/igt@i915_selftest@live@gt_pm.html

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#110725] / [fdo#111614])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][93] ([i915#3743]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3777]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl3/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#3777])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#110723]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109278] / [i915#3886]) +3 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3886]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#3886]) +11 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl5/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#3886]) +3 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][101] ([fdo#109271]) +105 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl4/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_cdclk@plane-scaling:
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#3742])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_chamelium@dp-hpd-storm:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109284] / [fdo#111827]) +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][104] ([fdo#109271] / [fdo#111827]) +17 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

* igt@kms_color@pipe-a-ctm-max:
- shard-skl: [PASS][105] -> [DMESG-WARN][106] ([i915#1982])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-skl3/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [fdo#111827]) +10 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][109] ([i915#1319])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl7/igt@[email protected]

* igt@kms_content_protection@type1:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109300] / [fdo#111066])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][111] ([i915#180]) +2 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109278] / [fdo#109279]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109278]) +7 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109279] / [i915#3359])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-tglb: NOTRUN -> [SKIP][115] ([fdo#109274] / [fdo#111825])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][116] ([i915#2346])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]
- shard-tglb: [PASS][117] -> [FAIL][118] ([i915#2346])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-tglb7/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][119] -> [FAIL][120] ([i915#2346])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-skl2/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl7/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109274]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_flip@busy-flip@c-edp1:
- shard-skl: [PASS][122] -> [FAIL][123] ([i915#4628])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-skl3/igt@kms_flip@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: NOTRUN -> [FAIL][124] ([i915#2122])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl5/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][125] -> [FAIL][126] ([i915#4911])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-glk7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling:
- shard-iclb: NOTRUN -> [SKIP][127] ([i915#2587])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][128] ([fdo#109280]) +11 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][129] ([fdo#109271]) +240 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][130] ([fdo#109280] / [fdo#111825]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][131] -> [DMESG-WARN][132] ([i915#180]) +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-apl2/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl8/igt@[email protected]

* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][133] ([fdo#109271] / [i915#533]) +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][134] ([fdo#109271] / [i915#533]) +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl10/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [PASS][135] -> [DMESG-WARN][136] ([i915#180]) +3 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-kbl3/igt@kms_plane@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl6/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][137] ([fdo#108145] / [i915#265]) +4 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl7/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][138] ([fdo#108145] / [i915#265])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-apl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][139] -> [FAIL][140] ([fdo#108145] / [i915#265])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-skl3/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][141] ([i915#265])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][142] ([i915#3536])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][143] ([fdo#109271] / [i915#2733])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl10/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][144] ([fdo#109271] / [i915#658])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl10/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][145] ([fdo#109271] / [i915#658])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl7/igt@[email protected]

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][146] ([fdo#109642] / [fdo#111068] / [i915#658])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][147] -> [SKIP][148] ([fdo#109441]) +2 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11051/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb7/igt@kms_psr@psr2_cursor_render.html

* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][149] ([fdo#109271] / [i915#2437]) +1 similar issue
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl4/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][150] ([fdo#109271] / [i915#2437])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl3/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][151] ([i915#2530])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-tglb5/igt@[email protected]

* igt@perf@gen12-unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> [SKIP][152] ([fdo#109289])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@prime_nv_api@i915_nv_import_twice:
- shard-iclb: NOTRUN -> [SKIP][153] ([fdo#109291]) +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@prime_nv_api@i915_nv_import_twice.html

* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][154] ([fdo#109271] / [i915#2994]) +2 similar issues
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-skl9/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-iclb: NOTRUN -> [SKIP][155] ([i915#2994])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-iclb3/igt@[email protected]

* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][156] ([fdo#109271] / [i915#2994]) +1 similar issue
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/shard-kbl4/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [FAIL][157] ([i915#2410]) -> [PASS]

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21929/index.html