Per client GPU stats
Subsystems (4)
cover Per client GPU stats
From: Tvrtko Ursulin <[email protected]>
Same old work but now rebased and series ending with some DRM docs proposing the common specification which should enable nice common userspace tools to be written.
For the moment I only have intel_gpu_top converted to use this and that seems to work okay.
v2:
* Added prototype of possible amdgpu changes and spec updates to align with the common spec.
v3:
* Documented that 'drm-driver' tag shall correspond with struct drm_driver.name.
v4:
* Dropped amdgpu conversion from the series for now until AMD folks can find some time to finish that patch.
Test-with: [email protected]
Tvrtko Ursulin (7):
drm/i915: Explicitly track DRM clients
drm/i915: Make GEM contexts track DRM clients
drm/i915: Track runtime spent in closed and unreachable GEM contexts drm/i915: Track all user contexts per client
drm/i915: Track context current active time
drm: Document fdinfo format specification
drm/i915: Expose client engine utilisation via fdinfo
Documentation/gpu/drm-usage-stats.rst | 103 +++++++++++++ Documentation/gpu/i915.rst | 27 ++++ Documentation/gpu/index.rst | 1 + drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_context.c | 42 ++++- .../gpu/drm/i915/gem/i915_gem_context_types.h | 6 + drivers/gpu/drm/i915/gt/intel_context.c | 27 +++- drivers/gpu/drm/i915/gt/intel_context.h | 15 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 24 ++- .../drm/i915/gt/intel_execlists_submission.c | 23 ++- .../gpu/drm/i915/gt/intel_gt_clock_utils.c | 4 + drivers/gpu/drm/i915/gt/intel_lrc.c | 27 ++-- drivers/gpu/drm/i915/gt/intel_lrc.h | 24 +++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 10 +- drivers/gpu/drm/i915/i915_driver.c | 9 ++ drivers/gpu/drm/i915/i915_drm_client.c | 143 ++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 66 ++++++++ drivers/gpu/drm/i915/i915_drv.h | 5 + drivers/gpu/drm/i915/i915_gem.c | 21 ++- drivers/gpu/drm/i915/i915_gpu_error.c | 9 +- drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- 21 files changed, 535 insertions(+), 54 deletions(-) create mode 100644 Documentation/gpu/drm-usage-stats.rst create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
Signature · 1 line
2.32.0
PATCH 1/7 drm/i915: Explicitly track DRM clients
From: Tvrtko Ursulin <[email protected]>
Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning task pid/name.
Unique client id is also assigned for the purpose of distinguishing/ consolidating between multiple file descriptors owned by the same process.
v2:
Chris Wilson:
* Enclose new members into dedicated structs.
* Protect against failed sysfs registration.
v3:
* sysfs_attr_init.
v4:
* Fix for internal clients.
v5:
* Use cyclic ida for client id. (Chris)
* Do not leak pid reference. (Chris)
* Tidy code with some locals.
v6:
* Use xa_alloc_cyclic to simplify locking. (Chris)
* No need to unregister individial sysfs files. (Chris)
* Rebase on top of fpriv kref.
* Track client closed status and reflect in sysfs.
v7:
* Make drm_client more standalone concept.
v8:
* Simplify sysfs show. (Chris)
* Always track name and pid.
v9:
* Fix cyclic id assignment.
v10:
* No need for a mutex around xa_alloc_cyclic.
* Refactor sysfs into own function.
* Unregister sysfs before freeing pid and name.
* Move clients setup into own function.
v11:
* Call clients init directly from driver init. (Chris)
v12:
* Do not fail client add on id wrap. (Maciej)
v13 (Lucas): Rebase.
v14:
* Dropped sysfs bits.
v15:
* Dropped tracking of pid/ and name.
* Dropped RCU freeing of the client object.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_driver.c | 6 +++ drivers/gpu/drm/i915/i915_drm_client.c | 68 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 50 +++++++++++++++++++ drivers/gpu/drm/i915/i915_drv.h | 5 ++ drivers/gpu/drm/i915/i915_gem.c | 21 ++++++-- 6 files changed, 148 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -31,6 +31,7 @@ subdir-ccflags-y += -I$(srctree)/$(src) # core driver code i915-y += i915_driver.o \ + i915_drm_client.o \ i915_config.o \ i915_irq.o \ i915_getparam.o \
drivers/gpu/drm/i915/i915_driver.c +6 -0
@@ -73,6 +73,7 @@#include "i915_debugfs.h" #include "i915_driver.h" +#include "i915_drm_client.h" #include "i915_drv.h" #include "i915_ioc32.h" #include "i915_irq.h"
@@ -349,6 +350,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)__intel_gt_init_early (to_gt (dev_priv), dev_priv); +i915_drm_clients_init (&dev_priv->clients, dev_priv); +i915_gem_init_early (dev_priv);/* This must be called before any calls to HAS_PCH_* */
@@ -368,6 +371,7 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv) err_gem:i915_gem_cleanup_early (dev_priv); +i915_drm_clients_fini (&dev_priv->clients);intel_gt_driver_late_release (to_gt (dev_priv));intel_region_ttm_device_fini (dev_priv); err_ttm:
@@ -387,6 +391,7 @@ static void i915_driver_late_release(struct drm_i915_private *dev_priv)intel_irq_fini (dev_priv);intel_power_domains_cleanup (dev_priv);i915_gem_cleanup_early (dev_priv); +i915_drm_clients_fini (&dev_priv->clients);intel_gt_driver_late_release (to_gt (dev_priv));intel_region_ttm_device_fini (dev_priv);vlv_suspend_cleanup (dev_priv);
@@ -1019,6 +1024,7 @@ static void i915_driver_postclose(struct drm_device *dev, struct drm_file *file)struct drm_i915_file_private *file_priv = file->driver_priv;i915_gem_context_close (file); +i915_drm_client_put (file_priv->client);kfree_rcu (file_priv, rcu);
drivers/gpu/drm/i915/i915_drm_client.c new file +68 -0
68 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drm_client.h new file +50 -0
50 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drv.h +5 -0
@@ -98,6 +98,7 @@#include "intel_wakeref.h" #include "intel_wopcm.h" +#include "i915_drm_client.h" #include "i915_gem.h" #include "i915_gem_gtt.h" #include "i915_gpu_error.h"
@@ -259,6 +260,8 @@ struct drm_i915_file_private {/** ban_score: Accumulated score of all ctx bans and fast hangs. */ atomic_t ban_score;unsigned long hang_timestamp; + +struct i915_drm_client *client; };/* Interface history:
@@ -1029,6 +1032,8 @@ struct drm_i915_private {struct i915_pmu pmu; +struct i915_drm_clients clients; +struct i915_hdcp_comp_master *hdcp_master;bool hdcp_comp_added;
drivers/gpu/drm/i915/i915_gem.c +18 -3
@@ -1201,25 +1201,40 @@ void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)int i915_gem_open (struct drm_i915_private *i915,struct drm_file *file) {struct drm_i915_file_private *file_priv; -int ret; +struct i915_drm_client *client; +int ret = -ENOMEM ;DRM_DEBUG ("\n" ); file_priv =kzalloc (sizeof (*file_priv),GFP_KERNEL );if (!file_priv) -return -ENOMEM ; + goto err_alloc; + + client =i915_drm_client_add (&i915->clients); +if (IS_ERR (client)) { + ret =PTR_ERR (client); + goto err_client; + } file->driver_priv = file_priv; file_priv->dev_priv = i915; file_priv->file = file; + file_priv->client = client; file_priv->bsd_engine =-1 ; file_priv->hang_timestamp = jiffies; ret =i915_gem_context_open (i915, file);if (ret) -kfree (file_priv); + goto err_context; + +return 0 ; +err_context: +i915_drm_client_put (client); +err_client: +kfree (file_priv); +err_alloc:return ret; }
Signature · 1 line
2.32.0
PATCH 2/7 drm/i915: Make GEM contexts track DRM clients
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches.
v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4 (Ram): Rebase.
v5: Trivial rebase for proto ctx changes.
v6: Rebase after clients no longer track name and pid.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 3 +++ 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_context.c +5 -0
@@ -1230,6 +1230,9 @@ static void i915_gem_context_release_work(struct work_struct *work)if (ctx->pxp_wakeref)intel_runtime_pm_put (&ctx->i915->runtime_pm, ctx->pxp_wakeref); +if (ctx->client) +i915_drm_client_put (ctx->client); +mutex_destroy (&ctx->engines_mutex);mutex_destroy (&ctx->lut_mutex);
@@ -1653,6 +1656,8 @@ static void gem_context_register(struct i915_gem_context *ctx, ctx->file_priv = fpriv; ctx->pid =get_task_pid (current,PIDTYPE_PID ); + ctx->client =i915_drm_client_get (fpriv->client); +snprintf (ctx->name,sizeof (ctx->name),"%s[%d]" , current->comm,pid_nr (ctx->pid));
drivers/gpu/drm/i915/gem/i915_gem_context_types.h +3 -0
@@ -293,6 +293,9 @@ struct i915_gem_context {/** @link: place with &drm_i915_private.context_list */ struct list_head link; +/** @client: struct i915_drm_client */ +struct i915_drm_client *client; +/** * @ref: reference count *
Signature · 1 line
2.32.0
PATCH 3/7 drm/i915: Track runtime spent in closed and unreachable GEM contexts
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes.
As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter purposes.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 25 +++++++++++++++++++-- drivers/gpu/drm/i915/i915_drm_client.h | 7 ++++++ 2 files changed, 30 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.c +23 -2
@@ -1004,23 +1004,44 @@ static void free_engines_rcu(struct rcu_head *rcu)free_engines (engines); } +static void accumulate_runtime (struct i915_drm_client *client, +struct i915_gem_engines *engines) +{ +struct i915_gem_engines_iter it; +struct intel_context *ce; + +if (!client) +return ; + +/* Transfer accumulated runtime to the parent GEM context. */ +for_each_gem_engine (ce, engines, it) { +unsigned int class = ce->engine->uabi_class; + +GEM_BUG_ON (class >=ARRAY_SIZE (client->past_runtime)); +atomic64_add (intel_context_get_total_runtime_ns (ce), + &client->past_runtime[class]); + } +} +static int engines_notify (struct i915_sw_fence *fence,enum i915_sw_fence_notify state) {struct i915_gem_engines *engines =container_of (fence,typeof (*engines), fence); +struct i915_gem_context *ctx = engines->ctx;switch (state) {case FENCE_COMPLETE :if (!list_empty (&engines->link)) { -struct i915_gem_context *ctx = engines->ctx;unsigned long flags;spin_lock_irqsave (&ctx->stale.lock, flags);list_del (&engines->link);spin_unlock_irqrestore (&ctx->stale.lock, flags); } -i915_gem_context_put (engines->ctx); +accumulate_runtime (ctx->client, engines); +i915_gem_context_put (ctx); +break ;case FENCE_FREE :
drivers/gpu/drm/i915/i915_drm_client.h +7 -0
@@ -9,6 +9,8 @@#include <linux/kref.h> #include <linux/xarray.h> +#include "gt/intel_engine_types.h" +struct drm_i915_private ;struct i915_drm_clients {
@@ -24,6 +26,11 @@ struct i915_drm_client {unsigned int id;struct i915_drm_clients *clients; + +/** +* @past_runtime: Accumulation of pphwsp runtimes from closed contexts. +*/ +atomic64_t past_runtime[MAX_ENGINE_CLASS +1 ]; }; void i915_drm_clients_init(struct i915_drm_clients *clients,
Signature · 1 line
2.32.0
PATCH 4/7 drm/i915: Track all user contexts per client
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using.
To enable this we start tracking all context belonging to a client on a separate list.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 12 ++++++++++++ drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 3 +++ drivers/gpu/drm/i915/i915_drm_client.c | 2 ++ drivers/gpu/drm/i915/i915_drm_client.h | 5 +++++ 4 files changed, 22 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_context.c +12 -0
@@ -1464,6 +1464,7 @@ static void set_closed_name(struct i915_gem_context *ctx)static void context_close (struct i915_gem_context *ctx) { +struct i915_drm_client *client;struct i915_address_space *vm;/* Flush any concurrent set_engines() */
@@ -1501,6 +1502,13 @@ static void context_close(struct i915_gem_context *ctx)list_del (&ctx->link);spin_unlock (&ctx->i915->gem.contexts.lock); + client = ctx->client; +if (client) { +spin_lock (&client->ctx_lock); +list_del_rcu (&ctx->client_link); +spin_unlock (&client->ctx_lock); + } +mutex_unlock (&ctx->mutex);/*
@@ -1686,6 +1694,10 @@ static void gem_context_register(struct i915_gem_context *ctx, old =xa_store (&fpriv->context_xa, id, ctx,GFP_KERNEL );WARN_ON (old); +spin_lock (&ctx->client->ctx_lock); +list_add_tail_rcu (&ctx->client_link, &ctx->client->ctx_list); +spin_unlock (&ctx->client->ctx_lock); +spin_lock (&i915->gem.contexts.lock);list_add_tail (&ctx->link, &i915->gem.contexts.list);spin_unlock (&i915->gem.contexts.lock);
drivers/gpu/drm/i915/gem/i915_gem_context_types.h +3 -0
@@ -296,6 +296,9 @@ struct i915_gem_context {/** @client: struct i915_drm_client */ struct i915_drm_client *client; +/** link: &drm_client.context_list */ +struct list_head client_link; +/** * @ref: reference count *
drivers/gpu/drm/i915/i915_drm_client.c +2 -0
@@ -38,6 +38,8 @@ struct i915_drm_client *i915_drm_client_add(struct i915_drm_clients *clients) goto err;kref_init (&client->kref); +spin_lock_init (&client->ctx_lock); +INIT_LIST_HEAD (&client->ctx_list); client->clients = clients;return client;
drivers/gpu/drm/i915/i915_drm_client.h +5 -0
@@ -7,6 +7,8 @@#define __I915_DRM_CLIENT_H__#include <linux/kref.h> +#include <linux/list.h> +#include <linux/spinlock.h> #include <linux/xarray.h> #include "gt/intel_engine_types.h"
@@ -25,6 +27,9 @@ struct i915_drm_client {unsigned int id; +spinlock_t ctx_lock;/* For add/remove from ctx_list. */ +struct list_head ctx_list;/* List of contexts belonging to client. */ +struct i915_drm_clients *clients;/**
Signature · 1 line
2.32.0
PATCH 5/7 drm/i915: Track context current active time
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Track context active (on hardware) status together with the start timestamp.
This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime.
The latter is only updated on context save so does not give us visibility to any currently executing work.
As part of the patch the existing runtime tracking data is moved under the new ce->stats member and updated under the seqlock. This provides the ability to atomically read out accumulated plus active runtime.
v2:
* Rename and make __intel_context_get_active_time unlocked.
v3:
* Use GRAPHICS_VER.
--- drivers/gpu/drm/i915/gt/intel_context.c | 27 ++++++++++++++++++- drivers/gpu/drm/i915/gt/intel_context.h | 15 ++++------- drivers/gpu/drm/i915/gt/intel_context_types.h | 24 +++++++++++------ .../drm/i915/gt/intel_execlists_submission.c | 23 ++++++++++++---- .../gpu/drm/i915/gt/intel_gt_clock_utils.c | 4 +++ drivers/gpu/drm/i915/gt/intel_lrc.c | 27 ++++++++++--------- drivers/gpu/drm/i915/gt/intel_lrc.h | 24 +++++++++++++++++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 10 +++---- drivers/gpu/drm/i915/i915_gpu_error.c | 9 +++---- drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- 10 files changed, 116 insertions(+), 49 deletions(-)
drivers/gpu/drm/i915/gt/intel_context.c +26 -1
@@ -386,7 +386,7 @@ intel_context_init(struct intel_context *ce, struct intel_engine_cs *engine) ce->ring =NULL ; ce->ring_size =SZ_4K ; -ewma_runtime_init (&ce->runtime.avg); +ewma_runtime_init (&ce->stats.runtime.avg); ce->vm =i915_vm_get (engine->gt->vm);
@@ -576,6 +576,31 @@ void intel_context_bind_parent_child(struct intel_context *parent, child->parallel.parent = parent; } +u64 intel_context_get_total_runtime_ns (const struct intel_context *ce) +{ +u64 total, active; + + total = ce->stats.runtime.total; +if (ce->ops->flags &COPS_RUNTIME_CYCLES ) + total *= ce->engine->gt->clock_period_ns; + + active =READ_ONCE (ce->stats.active); +if (active) + active =intel_context_clock () - active; + +return total + active; +} + +u64 intel_context_get_avg_runtime_ns (struct intel_context *ce) +{ +u64 avg =ewma_runtime_read (&ce->stats.runtime.avg); + +if (ce->ops->flags &COPS_RUNTIME_CYCLES ) + avg *= ce->engine->gt->clock_period_ns; + +return avg; +} +#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )#include "selftest_context.c" #endif
drivers/gpu/drm/i915/gt/intel_context.h +5 -10
@@ -351,18 +351,13 @@ intel_context_clear_nopreempt(struct intel_context *ce) clear_bit(CONTEXT_NOPREEMPT, &ce->flags); } -static inline u64 intel_context_get_total_runtime_ns (struct intel_context *ce) -{ -const u32 period = ce->engine->gt->clock_period_ns; - -return READ_ONCE (ce->runtime.total) * period; -} +u64 intel_context_get_total_runtime_ns (const struct intel_context *ce); +u64 intel_context_get_avg_runtime_ns (struct intel_context *ce); -static inline u64 intel_context_get_avg_runtime_ns (struct intel_context *ce) +static inline u64 intel_context_clock (void ) { -const u32 period = ce->engine->gt->clock_period_ns; - -return mul_u32_u32 (ewma_runtime_read (&ce->runtime.avg), period); +/* As we mix CS cycles with CPU clocks, use the raw monotonic clock. */ +return ktime_get_raw_fast_ns (); }#endif /* __INTEL_CONTEXT_H__ */
drivers/gpu/drm/i915/gt/intel_context_types.h +16 -8
@@ -35,6 +35,9 @@ struct intel_context_ops {#define COPS_HAS_INFLIGHT_BIT 0#define COPS_HAS_INFLIGHT BIT(COPS_HAS_INFLIGHT_BIT) +#define COPS_RUNTIME_CYCLES_BIT 1 +#define COPS_RUNTIME_CYCLES BIT(COPS_RUNTIME_CYCLES_BIT) +int (*alloc)(struct intel_context *ce);void (*ban)(struct intel_context *ce,struct i915_request *rq);
@@ -134,14 +137,19 @@ struct intel_context { } lrc;u32 tag;/* cookie passed to HW to track this context on submission */ -/* Time on GPU as tracked by the hw. */ -struct { -struct ewma_runtime avg; -u64 total; -u32 last; - I915_SELFTEST_DECLARE(u32 num_underflow); - I915_SELFTEST_DECLARE(u32 max_underflow); - } runtime; +/** stats: Context GPU engine busyness tracking. */ +struct intel_context_stats { +u64 active; + +/* Time on GPU as tracked by the hw. */ +struct { +struct ewma_runtime avg; +u64 total; +u32 last; + I915_SELFTEST_DECLARE(u32 num_underflow); + I915_SELFTEST_DECLARE(u32 max_underflow); + } runtime; + } stats;unsigned int active_count;/* protected by timeline->mutex */
drivers/gpu/drm/i915/gt/intel_execlists_submission.c +18 -5
@@ -622,8 +622,6 @@ static void __execlists_schedule_out(struct i915_request * const rq,GEM_BUG_ON (test_bit (ccid -1 , &engine->context_tag));__set_bit (ccid -1 , &engine->context_tag); } - -lrc_update_runtime (ce);intel_engine_context_out (engine);execlists_context_status_change (rq,INTEL_CONTEXT_SCHEDULE_OUT );if (engine->fw_domain && !--engine->fw_active)
@@ -2004,8 +2002,23 @@ process_csb(struct intel_engine_cs *engine, struct i915_request **inactive)* and merits a fresh timeslice. We reinstall the timer after * inspecting the queue to see if we need to resumbit. */ -if (*prev != *execlists->active)/* elide lite-restores */ +if (*prev != *execlists->active) {/* elide lite-restores */ +/* +* Note the inherent discrepancy between the HW runtime, +* recorded as part of the context switch, and the CPU +* adjustment for active contexts. We have to hope that +* the delay in processing the CS event is very small +* and consistent. It works to our advantage to have +* the CPU adjustment _undershoot_ (i.e. start later than) +* the CS timestamp so we never overreport the runtime +* and correct overselves later when updating from HW. +*/ +if (*prev) +lrc_runtime_stop ((*prev)->context); +if (*execlists->active) +lrc_runtime_start ((*execlists->active)->context);new_timeslice (execlists); + }return inactive; }
@@ -2637,7 +2650,7 @@ execlists_create_parallel(struct intel_engine_cs **engines, }static const struct intel_context_ops execlists_context_ops = { - .flags =COPS_HAS_INFLIGHT , + .flags =COPS_HAS_INFLIGHT |COPS_RUNTIME_CYCLES , .alloc = execlists_context_alloc,
@@ -3692,7 +3705,7 @@ virtual_get_sibling(struct intel_engine_cs *engine, unsigned int sibling) }static const struct intel_context_ops virtual_context_ops = { - .flags =COPS_HAS_INFLIGHT , + .flags =COPS_HAS_INFLIGHT |COPS_RUNTIME_CYCLES , .alloc = virtual_context_alloc,
drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c +4 -0
@@ -159,6 +159,10 @@ void intel_gt_init_clock_frequency(struct intel_gt *gt)if (gt->clock_frequency) gt->clock_period_ns =intel_gt_clock_interval_to_ns (gt,1 ); +/* Icelake appears to use another fixed frequency for CTX_TIMESTAMP */ +if (GRAPHICS_VER (gt->i915) ==11 ) + gt->clock_period_ns =NSEC_PER_SEC /13750000 ; + GT_TRACE(gt, "Using clock frequency: %dkHz, period: %dns, wrap: %lldms\n", gt->clock_frequency / 1000,
drivers/gpu/drm/i915/gt/intel_lrc.c +14 -13
@@ -774,7 +774,7 @@ static void init_common_regs(u32 * const regs, CTX_CTRL_RS_CTX_ENABLE); regs[CTX_CONTEXT_CONTROL ] = ctl; - regs[CTX_TIMESTAMP ] = ce->runtime.last; + regs[CTX_TIMESTAMP ] = ce->stats.runtime.last; } static void init_wa_bb_regs(u32 * const regs,
@@ -1682,35 +1682,36 @@ void lrc_init_wa_ctx(struct intel_engine_cs *engine) } } -static void st_update_runtime_underflow (struct intel_context *ce,s32 dt) +static void st_runtime_underflow (struct intel_context_stats *stats,s32 dt) {#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST ) - ce->runtime.num_underflow++; - ce->runtime.max_underflow =max_t (u32, ce->runtime.max_underflow, -dt); + stats->runtime.num_underflow++; + stats->runtime.max_underflow = +max_t (u32, stats->runtime.max_underflow, -dt);#endif }void lrc_update_runtime (struct intel_context *ce) { +struct intel_context_stats *stats = &ce->stats;u32 old;s32 dt; -if (intel_context_is_barrier (ce)) + old = stats->runtime.last; + stats->runtime.last =lrc_get_runtime (ce); + dt = stats->runtime.last - old; +if (!dt)return ; - old = ce->runtime.last; - ce->runtime.last =lrc_get_runtime (ce); - dt = ce->runtime.last - old; -if (unlikely (dt <0 )) {CE_TRACE (ce,"runtime underflow: last=%u, new=%u, delta=%d\n" , - old, ce->runtime.last, dt); -st_update_runtime_underflow (ce, dt); + old, stats->runtime.last, dt); +st_runtime_underflow (stats, dt);return ; } -ewma_runtime_add (&ce->runtime.avg, dt); - ce->runtime.total += dt; +ewma_runtime_add (&stats->runtime.avg, dt); + stats->runtime.total += dt; }#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )
drivers/gpu/drm/i915/gt/intel_lrc.h +24 -0
@@ -79,4 +79,28 @@ static inline u32 lrc_get_runtime(const struct intel_context *ce) return READ_ONCE(ce->lrc_reg_state[CTX_TIMESTAMP]); } +static inline void lrc_runtime_start (struct intel_context *ce) +{ +struct intel_context_stats *stats = &ce->stats; + +if (intel_context_is_barrier (ce)) +return ; + +if (stats->active) +return ; + +WRITE_ONCE (stats->active,intel_context_clock ()); +} + +static inline void lrc_runtime_stop (struct intel_context *ce) +{ +struct intel_context_stats *stats = &ce->stats; + +if (!stats->active) +return ; + +lrc_update_runtime (ce); +WRITE_ONCE (stats->active,0 ); +} +#endif /* __INTEL_LRC_H__ */
drivers/gpu/drm/i915/gt/selftest_lrc.c +5 -5
@@ -1751,8 +1751,8 @@ static int __live_pphwsp_runtime(struct intel_engine_cs *engine)if (IS_ERR (ce))return PTR_ERR (ce); - ce->runtime.num_underflow =0 ; - ce->runtime.max_underflow =0 ; + ce->stats.runtime.num_underflow =0 ; + ce->stats.runtime.max_underflow =0 ; do { unsigned int loop = 1024;
@@ -1790,11 +1790,11 @@ static int __live_pphwsp_runtime(struct intel_engine_cs *engine) intel_context_get_avg_runtime_ns(ce)); err =0 ; -if (ce->runtime.num_underflow) { +if (ce->stats.runtime.num_underflow) {pr_err ("%s: pphwsp underflow %u time(s), max %u cycles!\n" , engine->name, - ce->runtime.num_underflow, - ce->runtime.max_underflow); + ce->stats.runtime.num_underflow, + ce->stats.runtime.max_underflow);GEM_TRACE_DUMP (); err = -EOVERFLOW ; }
drivers/gpu/drm/i915/i915_gpu_error.c +3 -6
@@ -505,13 +505,10 @@ static void error_print_context(struct drm_i915_error_state_buf *m, const char *header, const struct i915_gem_context_coredump *ctx) { - const u32 period = to_gt(m->i915)->clock_period_ns; - err_printf(m, "%s%s[%d] prio %d, guilty %d active %d, runtime total %lluns, avg %lluns\n", header, ctx->comm, ctx->pid, ctx->sched_attr.priority, ctx->guilty, ctx->active, - ctx->total_runtime * period, -mul_u32_u32 (ctx->avg_runtime, period)); + ctx->total_runtime, ctx->avg_runtime); } static struct i915_vma_coredump *
@@ -1313,8 +1310,8 @@ static bool record_context(struct i915_gem_context_coredump *e, e->guilty =atomic_read (&ctx->guilty_count); e->active =atomic_read (&ctx->active_count); - e->total_runtime = rq->context->runtime.total; - e->avg_runtime =ewma_runtime_read (&rq->context->runtime.avg); + e->total_runtime =intel_context_get_total_runtime_ns (rq->context); + e->avg_runtime =intel_context_get_avg_runtime_ns (rq->context); simulated =i915_gem_context_no_error_capture (ctx);
drivers/gpu/drm/i915/i915_gpu_error.h +1 -1
@@ -88,7 +88,7 @@ struct intel_engine_coredump {char comm[TASK_COMM_LEN ];u64 total_runtime; -u32 avg_runtime; +u64 avg_runtime;pid_t pid;int active;
Signature · 1 line
2.32.0
PATCH 6/7 drm: Document fdinfo format specification
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching intel_gpu_top tool exists.
Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.
v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)
--- Documentation/gpu/drm-usage-stats.rst | 97 +++++++++++++++++++++++++++ Documentation/gpu/index.rst | 1 + 2 files changed, 98 insertions(+) create mode 100644 Documentation/gpu/drm-usage-stats.rst
Documentation/gpu/drm-usage-stats.rst new file +97 -0
@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text output via the +`fops->show_fdinfo()` as part of the driver specific file operations registered +in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic as practicaly +feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specification of the +output is split between common and driver specific parts. Having said that, +wherever possible effort should still be made to standardise as much as +possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespace character shall be + ignored when parsing. +- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification. + +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters or whitespace. + +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via the respective +`struct drm_driver` data structure. + +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of the device in +question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used to distinguish +duplicated and shared file descriptors. Conceptually the value should map 1:1 +to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or unique within the +scope of each device, in which case `drm-pdev` shall be present as well. + +Userspace should make sure to not double account any usage statistics by using +the above described criteria in order to associate data to individual clients. + +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall be given a stable +and unique name (str), with possible values documented in the driver specific +documentation. + +Value shall be in specified time units which the respective GPU engine spent +busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes the driver +implementation easier, but are required to catch up with the previously reported +larger value within a reasonable period. Upon observing a value lower than what +was previously read, userspace is expected to stay with that larger previous +value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objects by the +GPU in question shall be given a stable and unique name to be returned as the +string here. + +Value shall reflect the amount of storage currently consumed by the buffer +object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' +indicating kibi- or mebi-bytes.
Documentation/gpu/index.rst +1 -0
@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guide drm-kms drm-kms-helpers drm-uapi + drm-usage-stats driver-uapi drm-client drivers
Signature · 1 line
2.32.0
PATCH 7/7 drm/i915: Expose client engine utilisation via fdinfo
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Similar to AMD commit
874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915.
Example of the output:
pos: 0
flags: 0100002
mnt_id: 21
drm-driver: i915
drm-pdev: 0000:00:02.0
drm-client-id: 7 drm-engine-render: 9288864723 ns drm-engine-copy: 2035071108 ns drm-engine-video: 0 ns
drm-engine-video-enhance: 0 ns
v2:
* Update for removal of name and pid.
v3:
* Use drm_driver.name.
--- Documentation/gpu/drm-usage-stats.rst | 6 +++ Documentation/gpu/i915.rst | 27 ++++++++++ drivers/gpu/drm/i915/i915_driver.c | 3 ++ drivers/gpu/drm/i915/i915_drm_client.c | 73 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 4 ++ 5 files changed, 113 insertions(+)
Documentation/gpu/drm-usage-stats.rst +6 -0
@@ -95,3 +95,9 @@ object belong to this client, in the respective memory region. Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' indicating kibi- or mebi-bytes. + +=============================== +Driver specific implementations +=============================== + +:ref:`i915-usage-stats`
Documentation/gpu/i915.rst +27 -0
@@ -708,3 +708,30 @@ The style guide for ``i915_reg.h``. .. kernel-doc:: drivers/gpu/drm/i915/i915_reg.h :doc: The i915 register macro definition style guide + +.. _i915-usage-stats: + +i915 DRM client usage stats implementation +========================================== + +The drm/i915 driver implements the DRM client usage stats specification as +documented in :ref:`drm-client-usage-stats`. + +Example of the output showing the implemented key value pairs and entirety of +the currenly possible format options: + +:: + + pos: 0 + flags: 0100002 + mnt_id: 21 + drm-driver: i915 + drm-pdev: 0000:00:02.0 + drm-client-id: 7 + drm-engine-render: 9288864723 ns + drm-engine-copy: 2035071108 ns + drm-engine-video: 0 ns + drm-engine-video-enhance: 0 ns + +Possible `drm-engine-` key names are: `render`, `copy`, `video` and +`video-enhance`.
drivers/gpu/drm/i915/i915_driver.c +3 -0
@@ -1755,6 +1755,9 @@ static const struct file_operations i915_driver_fops = { .read = drm_read, .compat_ioctl = i915_ioc32_compat_ioctl, .llseek = noop_llseek, +#ifdef CONFIG_PROC_FS + .show_fdinfo = i915_drm_client_fdinfo, +#endif }; static int
drivers/gpu/drm/i915/i915_drm_client.c +73 -0
82 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drm_client.h +4 -0
@@ -57,6 +57,10 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_add (struct i915_drm_clients *clients); +#ifdef CONFIG_PROC_FS +void i915_drm_client_fdinfo (struct seq_file *m,struct file *f); +#endif +void i915_drm_clients_fini (struct i915_drm_clients *clients);#endif /* !__I915_DRM_CLIENT_H__ */
Signature · 1 line
2.32.0
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client GPU stats (rev6)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev6)
URL : https://patchwork.freedesktop.org/series/92574/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip abb04b2f19c6 drm/i915: Explicitly track DRM clients -:129: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #129: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 227 lines checked 5188d5d83d0d drm/i915: Make GEM contexts track DRM clients 29c1f34e3c7f drm/i915: Track runtime spent in closed and unreachable GEM contexts 24e66c9cbdce drm/i915: Track all user contexts per client 3b82c287accb drm/i915: Track context current active time
-:139: WARNING:LINE_SPACING: Missing a blank line after declarations #139: FILE: drivers/gpu/drm/i915/gt/intel_context_types.h:149:
+ u32 last;
+ I915_SELFTEST_DECLARE(u32 num_underflow);
total: 0 errors, 1 warnings, 0 checks, 296 lines checked30ae1a8f706f drm: Document fdinfo format specification
-:41: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #41:
new file mode 100644
-:46: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #46: FILE: Documentation/gpu/drm-usage-stats.rst:1:
+.. _drm-client-usage-stats:
total: 0 errors, 2 warnings, 0 checks, 104 lines checked 79e0ac9f2dca drm/i915: Expose client engine utilisation via fdinfo
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per client GPU stats (rev6)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev6)
URL : https://patchwork.freedesktop.org/series/92574/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for Per client GPU stats (rev6)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev6)
URL : https://patchwork.freedesktop.org/series/92574/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or member 'client_link' not described in 'i915_gem_context'
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Per client GPU stats (rev6)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev6)
URL : https://patchwork.freedesktop.org/series/92574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11052 -> Patchwork_21932
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/index.html
Participating hosts (44 -> 37)
------------------------------
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-rpls-1 fi-bdw-samus bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21932 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +31 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@i915_selftest@live@requests:
- fi-snb-2520m: NOTRUN -> [DMESG-FAIL][2] ([i915#4610])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-snb-2520m/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-bdw-5557u/igt@[email protected]
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][4] ([i915#4312])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-skl-6600u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-icl-u2: [FAIL][5] ([i915#1888]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-icl-u2/igt@gem_exec_suspend@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-icl-u2/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@gt_contexts:
- fi-snb-2520m: [DMESG-FAIL][7] ([i915#4610]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][9] ([i915#4269]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-cml-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-cml-u2/igt@[email protected]
#### Warnings ####
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [INCOMPLETE][11] ([i915#4838]) -> [FAIL][12] ([i915#4547])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4610]: https://gitlab.freedesktop.org/drm/intel/issues/4610
[i915#4838]: https://gitlab.freedesktop.org/drm/intel/issues/4838
Build changes
-------------
* IGT: IGT_6324 -> IGTPW_6542
* Linux: CI_DRM_11052 -> Patchwork_21932
CI-20190529: 20190529
CI_DRM_11052: 5926026a36a658f615b8a5aaa74a90a2a3c5e6c5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6542: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6542/index.html
IGT_6324: 6e009504d5f7cc39866191e4bff813a4512c3e9b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21932: 79e0ac9f2dca7ae5d4c0e1f0fafb3d5a605c42f0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
79e0ac9f2dca drm/i915: Expose client engine utilisation via fdinfo 30ae1a8f706f drm: Document fdinfo format specification3b82c287accb drm/i915: Track context current active time 24e66c9cbdce drm/i915: Track all user contexts per client 29c1f34e3c7f drm/i915: Track runtime spent in closed and unreachable GEM contexts 5188d5d83d0d drm/i915: Make GEM contexts track DRM clients abb04b2f19c6 drm/i915: Explicitly track DRM clients
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for Per client GPU stats (rev6)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev6)
URL : https://patchwork.freedesktop.org/series/92574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21932_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21932_full:
### IGT changes ###
#### Possible regressions ####
* {igt@drm_fdinfo@busy@vcs0} (NEW):
- shard-snb: NOTRUN -> [FAIL][1] +23 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-snb4/igt@drm_fdinfo@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@api_intel_allocator@standalone:
- {shard-tglu}: NOTRUN -> [TIMEOUT][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglu-2/igt@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-wb:
- {shard-rkl}: ([PASS][3], [PASS][4]) -> [INCOMPLETE][5] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-rkl-5/igt@[email protected]
* igt@gem_exec_parallel@contexts@bcs0:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][6] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-rkl-5/igt@gem_exec_parallel@[email protected]
* igt@gem_userptr_blits@stress-mm:
- {shard-rkl}: [PASS][7] -> [INCOMPLETE][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-rkl-5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- {shard-tglu}: NOTRUN -> [SKIP][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglu-8/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- {shard-tglu}: [PASS][10] -> [DMESG-WARN][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglu-6/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglu-1/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_11052_full and Patchwork_21932_full:
### New IGT tests (52) ###
* igt@drm_fdinfo@all-busy-check-all:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [0.51, 0.53] s
* igt@drm_fdinfo@all-busy-idle-check-all:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.61, 0.72] s
* igt@drm_fdinfo@basics:
- Statuses : 1 fail(s) 4 pass(s)
- Exec time: [0.0, 0.03] s
* igt@drm_fdinfo@busy-check-all@bcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.51, 0.60] s
* igt@drm_fdinfo@busy-check-all@rcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.52, 0.59] s
* igt@drm_fdinfo@busy-check-all@vcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.52, 1.01] s
* igt@drm_fdinfo@busy-check-all@vcs1:
- Statuses : 3 pass(s)
- Exec time: [0.52] s
* igt@drm_fdinfo@busy-check-all@vecs0:
- Statuses : 6 pass(s)
- Exec time: [0.52, 0.58] s
* igt@drm_fdinfo@busy-hang:
- Statuses :
- Exec time: [None] s
* igt@drm_fdinfo@busy-hang@bcs0:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [0.52, 1.10] s
* igt@drm_fdinfo@busy-hang@rcs0:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [0.63, 1.10] s
* igt@drm_fdinfo@busy-hang@vcs0:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [1.01, 1.09] s
* igt@drm_fdinfo@busy-hang@vcs1:
- Statuses : 2 pass(s)
- Exec time: [1.02, 1.10] s
* igt@drm_fdinfo@busy-hang@vecs0:
- Statuses : 5 pass(s)
- Exec time: [1.03, 1.10] s
* igt@drm_fdinfo@busy-idle-check-all:
- Statuses :
- Exec time: [None] s
* igt@drm_fdinfo@busy-idle-check-all@bcs0:
- Statuses : 1 fail(s) 4 pass(s)
- Exec time: [0.61, 0.68] s
* igt@drm_fdinfo@busy-idle-check-all@rcs0:
- Statuses : 1 fail(s) 4 pass(s)
- Exec time: [0.62, 0.68] s
* igt@drm_fdinfo@busy-idle-check-all@vcs0:
- Statuses : 1 fail(s) 4 pass(s)
- Exec time: [0.62, 1.11] s
* igt@drm_fdinfo@busy-idle-check-all@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.63, 0.64] s
* igt@drm_fdinfo@busy-idle-check-all@vecs0:
- Statuses : 4 pass(s)
- Exec time: [0.62, 0.68] s
* igt@drm_fdinfo@busy-idle@bcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.62, 0.69] s
* igt@drm_fdinfo@busy-idle@rcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.62, 0.73] s
* igt@drm_fdinfo@busy-idle@vcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.62, 1.11] s
* igt@drm_fdinfo@busy-idle@vcs1:
- Statuses : 3 pass(s)
- Exec time: [0.62, 0.63] s
* igt@drm_fdinfo@busy-idle@vecs0:
- Statuses : 6 pass(s)
- Exec time: [0.62, 0.69] s
* igt@drm_fdinfo@busy@bcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.51, 0.57] s
* igt@drm_fdinfo@busy@rcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.52, 0.61] s
* igt@drm_fdinfo@busy@vcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.52, 1.01] s
* igt@drm_fdinfo@busy@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.52] s
* igt@drm_fdinfo@busy@vecs0:
- Statuses : 6 pass(s)
- Exec time: [0.52, 0.58] s
* igt@drm_fdinfo@idle@bcs0:
- Statuses : 7 pass(s)
- Exec time: [0.50, 0.52] s
* igt@drm_fdinfo@idle@rcs0:
- Statuses : 7 pass(s)
- Exec time: [0.50, 0.52] s
* igt@drm_fdinfo@idle@vcs0:
- Statuses : 7 pass(s)
- Exec time: [0.50, 0.52] s
* igt@drm_fdinfo@idle@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.50] s
* igt@drm_fdinfo@idle@vecs0:
- Statuses : 6 pass(s)
- Exec time: [0.50, 0.52] s
* igt@drm_fdinfo@isolation:
- Statuses :
- Exec time: [None] s
* igt@drm_fdinfo@isolation@bcs0:
- Statuses : 6 pass(s)
- Exec time: [0.51, 0.55] s
* igt@drm_fdinfo@isolation@rcs0:
- Statuses : 6 pass(s)
- Exec time: [0.51, 0.53] s
* igt@drm_fdinfo@isolation@vcs0:
- Statuses : 6 pass(s)
- Exec time: [0.52, 1.01] s
* igt@drm_fdinfo@isolation@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.52] s
* igt@drm_fdinfo@isolation@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.52, 0.53] s
* igt@drm_fdinfo@most-busy-check-all:
- Statuses :
- Exec time: [None] s
* igt@drm_fdinfo@most-busy-check-all@bcs0:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [0.51, 0.53] s
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [0.52, 0.62] s
* igt@drm_fdinfo@most-busy-check-all@vcs0:
- Statuses : 1 fail(s) 5 pass(s)
- Exec time: [0.51, 0.52] s
* igt@drm_fdinfo@most-busy-check-all@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.51, 0.52] s
* igt@drm_fdinfo@most-busy-check-all@vecs0:
- Statuses : 5 pass(s)
- Exec time: [0.51, 0.52] s
* igt@drm_fdinfo@most-busy-idle-check-all@bcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.61, 0.71] s
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.61, 0.72] s
* igt@drm_fdinfo@most-busy-idle-check-all@vcs0:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.61, 0.72] s
* igt@drm_fdinfo@most-busy-idle-check-all@vcs1:
- Statuses : 2 pass(s)
- Exec time: [0.61, 0.63] s
* igt@drm_fdinfo@most-busy-idle-check-all@vecs0:
- Statuses : 6 pass(s)
- Exec time: [0.61, 0.69] s
Known issues
------------
Here are the changes found in Patchwork_21932_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-apl: ([PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [FAIL][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36]) ([i915#4386]) -> ([PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl7/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl7/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl3/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl3/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl8/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl8/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl8/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl8/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl7/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl6/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl2/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl2/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl2/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: NOTRUN -> [DMESG-WARN][62] ([i915#180]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/igt@gem_ctx_isolation@[email protected]
* igt@gem_ctx_persistence@engines-persistence:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#1099])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-snb7/igt@[email protected]
* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#280]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb8/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [PASS][65] -> [SKIP][66] ([i915#4525]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb1/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb7/igt@[email protected]
* igt@gem_exec_capture@pi@vcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][67] ([i915#4547])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl4/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [PASS][68] -> [FAIL][69] ([i915#2842]) +4 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-kbl7/igt@gem_exec_fair@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl1/igt@gem_exec_fair@[email protected]
- shard-iclb: NOTRUN -> [FAIL][70] ([i915#2842])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb1/igt@gem_exec_fair@[email protected]
- shard-tglb: NOTRUN -> [FAIL][71] ([i915#2842])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][72] -> [FAIL][73] ([i915#2842])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-glk4/igt@gem_exec_fair@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-glk6/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][74] -> [FAIL][75] ([i915#2842])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/igt@gem_exec_fair@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_params@no-blt:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109283])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb2/igt@[email protected]
* igt@gem_exec_params@no-vebox:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271]) +71 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl8/igt@[email protected]
* igt@gem_exec_params@secure-non-root:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#112283])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#112283])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb1/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#4613])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-multi:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#4613])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-multi:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#4613])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#4613])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb2/igt@[email protected]
* igt@gem_mmap_gtt@coherency:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#111656])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb3/igt@[email protected]
* igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][85] ([i915#4270])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][86] ([i915#4270])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb3/igt@[email protected]
* igt@gen9_exec_parse@bb-start-far:
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#2856])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][88] ([i915#2527] / [i915#2856])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb8/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][89] ([i915#454])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl3/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: NOTRUN -> [FAIL][90] ([i915#454]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb5/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][91] ([i915#454])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl1/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][92] -> [SKIP][93] ([i915#4281])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb7/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#1937])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/igt@i915_pm_lpsp@[email protected]
* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111614])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#110725] / [fdo#111614])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb6/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: NOTRUN -> [DMESG-WARN][97] ([i915#118])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-glk2/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][98] ([i915#3743]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl9/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-16bpp-rotate-270:
- shard-iclb: [PASS][99] -> [FAIL][100] ([i915#1888])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb1/igt@[email protected]
* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][101] -> [DMESG-WARN][102] ([i915#118]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-glk8/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-glk5/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#3777])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl1/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#3777])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl4/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271]) +109 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#3886]) +4 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#3886]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl5/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#3886]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl4/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#3886])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-glk1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109278] / [i915#3886]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#3689] / [i915#3886])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#3689]) +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb5/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271]) +157 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl6/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][114] ([fdo#109278]) +11 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb3/igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs.html
- shard-tglb: NOTRUN -> [SKIP][115] ([fdo#111615] / [i915#3689]) +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb6/igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs.html
* igt@kms_chamelium@dp-frame-dump:
- shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109284] / [fdo#111827]) +4 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb5/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][117] ([fdo#109271] / [fdo#111827]) +12 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl3/igt@[email protected]
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][118] ([fdo#109271] / [fdo#111827]) +8 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl1/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [PASS][119] -> [DMESG-WARN][120] ([i915#1982])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl10/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl5/igt@[email protected]
* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109278] / [i915#1149])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb4/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-glk: NOTRUN -> [SKIP][122] ([fdo#109271] / [fdo#111827]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-glk6/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][123] ([fdo#109271] / [fdo#111827]) +3 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][124] ([fdo#109284] / [fdo#111827]) +5 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb2/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][125] ([fdo#109271] / [fdo#111827]) +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-snb4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][126] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb2/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][127] ([i915#1319]) +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-kbl7/igt@[email protected]
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][128] ([i915#1319])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-apl2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][129] ([i915#1063]) +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb6/igt@[email protected]
* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][130] ([fdo#109300] / [fdo#111066]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb3/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-rapid-movement:
- shard-skl: [PASS][131] -> [SKIP][132] ([fdo#109271]) +13 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl8/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-skl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][133] ([fdo#109279] / [i915#3359]) +3 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109278] / [fdo#109279]) +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-iclb6/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][135] ([i915#3359])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/shard-tglb1/igt@[email protected]
* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-snb: NOTRUN -> [SKIP][136]
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21932/index.html
Re: [PATCH 6/7] drm: Document fdinfo format specification
In reply to Tvrtko UrsulinQuoted 25 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)
Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>Cc Chris Healy <[email protected]>Acked-by Christian König <[email protected]>
I'm assuming this ack here and later on is a "amdgpu plans to use this too" kind of affair. Especially also in the lights of eventually using matching semantics for cgroups and everything else tied to gpu execution resource management.
If not I'm mildly worried that we're creating fake-standard stuff here which cannot actually be used by anything resembling driver-agnostic userspace.
-Daniel
Quoted 124 lines
--- Documentation/gpu/drm-usage-stats.rst | 97 +++++++++++++++++++++++++++ Documentation/gpu/index.rst | 1 + 2 files changed, 98 insertions(+) create mode 100644 Documentation/gpu/drm-usage-stats.rstDocumentation/gpu/drm-usage-stats.rst new file +97
-0@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text output via the +`fops->show_fdinfo()` as part of the driver specific file operations registered +in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic as practicaly +feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specification of the +output is split between common and driver specific parts. Having said that, +wherever possible effort should still be made to standardise as much as +possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespace character shall be + ignored when parsing. +- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification. + +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters or whitespace. + +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via the respective +`struct drm_driver` data structure. + +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of the device in +question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used to distinguish +duplicated and shared file descriptors. Conceptually the value should map 1:1 +to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or unique within the +scope of each device, in which case `drm-pdev` shall be present as well. + +Userspace should make sure to not double account any usage statistics by using +the above described criteria in order to associate data to individual clients. + +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall be given a stable +and unique name (str), with possible values documented in the driver specific +documentation. + +Value shall be in specified time units which the respective GPU engine spent +busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes the driver +implementation easier, but are required to catch up with the previously reported +larger value within a reasonable period. Upon observing a value lower than what +was previously read, userspace is expected to stay with that larger previous +value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objects by the +GPU in question shall be given a stable and unique name to be returned as the +string here. + +Value shall reflect the amount of storage currently consumed by the buffer +object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' +indicating kibi- or mebi-bytes.Documentation/gpu/index.rst +1
-0@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guide drm-kms drm-kms-helpers drm-uapi + drm-usage-stats driver-uapi drm-client driversSignature · 1 line
2.32.0
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH 6/7] drm: Document fdinfo format specification
Quoted 34 lines · Daniel Vetter
Quoted 25 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>Cc Chris Healy <[email protected]>Acked-by Christian König <[email protected]>
Quoted 8 lines
I'm assuming this ack here and later on is a "amdgpu plans to use this too" kind of affair. Especially also in the lights of eventually using matching semantics for cgroups and everything else tied to gpu execution resource management.
If not I'm mildly worried that we're creating fake-standard stuff here which cannot actually be used by anything resembling driver-agnostic userspace.
Hard to say how much adoption there would be.
At least on the statement of that the proposed spec cannot be used for driver agnostic userspace, do you have concrete concerns with the spec I proposed, or are just going by the lack of continuous engagement by any third party?
Apart from AMD, during past postings Daniel Stone also had positive feedback (along the lines of "works the driver I am familiar with"). I don't know if I have missed someone else who provided feedback, hope not.
There is of course the option of dropping the idea of trying to document a common spec, or to do anything cross-driver at this point. AFAIR it was your push to try this, and I agreed it would be a good thing if it worked out. But given AMD already exposes stuff in fdinfo, I don't think it would be a blocker for merging the i915 side even if we decided to drop the standardisation effort for now. Given I am maintaining this i915 code from ~2018 and there is a lot of interest from users it would be good to put it in.
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification
In reply to Daniel VetterQuoted 35 lines · Daniel Vetter
Quoted 25 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>Cc Chris Healy <[email protected]>Acked-by Christian König <[email protected]>
Quoted 8 lines
I'm assuming this ack here and later on is a "amdgpu plans to use this too" kind of affair. Especially also in the lights of eventually using matching semantics for cgroups and everything else tied to gpu execution resource management.
If not I'm mildly worried that we're creating fake-standard stuff here which cannot actually be used by anything resembling driver-agnostic userspace.
I think I could implement something like this for drm/msm. I am a bit uncertain about the memory stats (ie. how are we intended to account for imported/exported/shared bo's)? But we already track cycles+time per submit for devfreq, it would be pretty easy to add per drm_file counters to accumulate the per-submit results. We could even track per-context (submitqueue) for processes that have more than a single context, although not sure if that is useful.
And I think there is probably some room for shared helper to print parts other than the per-engine stats (and maybe memory stats, although even that could be a shared implementation for some drivers).. with a driver callback for the non-generic parts, ie. something like:
drm_driver::show_client_stats(struct drm_file *, struct drm_printer *)
but that can come later.
If there is a tool somewhere that displays this info, that would be useful for testing my implementation.
BR,
-R
Quoted 131 lines
-Daniel
Quoted 122 lines
--- Documentation/gpu/drm-usage-stats.rst | 97 +++++++++++++++++++++++++++ Documentation/gpu/index.rst | 1 + 2 files changed, 98 insertions(+) create mode 100644 Documentation/gpu/drm-usage-stats.rstDocumentation/gpu/drm-usage-stats.rst new file +97
-0@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text output via the +`fops->show_fdinfo()` as part of the driver specific file operations registered +in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic as practicaly +feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specification of the +output is split between common and driver specific parts. Having said that, +wherever possible effort should still be made to standardise as much as +possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespace character shall be + ignored when parsing. +- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification. + +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters or whitespace. + +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via the respective +`struct drm_driver` data structure. + +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of the device in +question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used to distinguish +duplicated and shared file descriptors. Conceptually the value should map 1:1 +to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or unique within the +scope of each device, in which case `drm-pdev` shall be present as well. + +Userspace should make sure to not double account any usage statistics by using +the above described criteria in order to associate data to individual clients. + +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall be given a stable +and unique name (str), with possible values documented in the driver specific +documentation. + +Value shall be in specified time units which the respective GPU engine spent +busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes the driver +implementation easier, but are required to catch up with the previously reported +larger value within a reasonable period. Upon observing a value lower than what +was previously read, userspace is expected to stay with that larger previous +value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objects by the +GPU in question shall be given a stable and unique name to be returned as the +string here. + +Value shall reflect the amount of storage currently consumed by the buffer +object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' +indicating kibi- or mebi-bytes.Documentation/gpu/index.rst +1
-1@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guide drm-kms drm-kms-helpers drm-uapi + drm-usage-stats driver-uapi drm-client drivers --Quoted 2 lines
2.32.0
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification
Quoted 45 lines · Rob Clark
Quoted 35 lines · Daniel Vetter
Quoted 25 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>Cc Chris Healy <[email protected]>Acked-by Christian König <[email protected]>Quoted 8 lines
I'm assuming this ack here and later on is a "amdgpu plans to use this too" kind of affair. Especially also in the lights of eventually using matching semantics for cgroups and everything else tied to gpu execution resource management.
If not I'm mildly worried that we're creating fake-standard stuff here which cannot actually be used by anything resembling driver-agnostic userspace.
Quoted 7 lines
I think I could implement something like this for drm/msm. I am a bit uncertain about the memory stats (ie. how are we intended to account for imported/exported/shared bo's)? But we already track cycles+time per submit for devfreq, it would be pretty easy to add per
drm_filecounters to accumulate the per-submit results. We could even track per-context (submitqueue) for processes that have more than a single context, although not sure if that is useful.
Interesting tidbit is that the whole i915 work started from a customer request to expose just that (per context) in a form akin to getrusage(2). I think this kind of introspection capability is interesting but as it is driver specific territory it's only anecdotal for what this thread is concerned.
Quoted 6 lines
And I think there is probably some room for shared helper to print parts other than the per-engine stats (and maybe memory stats, although even that could be a shared implementation for some drivers).. with a driver callback for the non-generic parts, ie. something like:
Quoted 6 lines
drm_driver::show_client_stats(struct drm_file *, struct drm_printer *)but that can come later.
If there is a tool somewhere that displays this info, that would be useful for testing my implementation.
I have a patch to Intel specific intel_gpu_top (see https://patchwork.freedesktop.org/patch/468491/?series=98555&rev=1). I'll have a look to see how much work would it be to extract common bits into a library and write a quick agnostic tool using it.
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification
Quoted 1 line · Tvrtko Ursulin
On 20/01/2022 16:44, Rob Clark wrote:
[snip]
Quoted 4 lines
Quoted 2 lines
If there is a tool somewhere that displays this info, that would be useful for testing my implementation.
I have a patch to Intel specific
intel_gpu_top(see https://patchwork.freedesktop.org/patch/468491/?series=98555&rev=1). I'll have a look to see how much work would it be to extract common bits into a library and write a quick agnostic tool using it.
I factored out some code from intel_gpu_top in a quick and dirty attempt to make it generic and made a very rudimentary tools/gputop:
https://cgit.freedesktop.org/~tursulin/intel-gpu-tools/log/?h=gputop
If you manage to export the right fdinfo tags (basically https://patchwork.freedesktop.org/patch/468502/?series=92574&rev=6)*, with the only local addition I have being the optional "drm-engine-capacity-<str>: <uint>" tag, we may get lucky and tool might even work. Let me know when you try. If it will work you should see something like this:
DRM minor 0
PID NAME render copy video
3838 kwin_x11 |█ || || || |
327056 mpv | || ||▌ || |
327056 mpv |▌ || || || |
1 systemd |▍ || || || |
3884 plasmashell | || || || |
4794 krunner | || || || |
4836 thunderbird | || || || |
296733 GeckoMain | || || || |Regards,
Tvrtko
*) Or for more reference this is how the i915 output looks like:
$ sudo cat /proc/7296/fdinfo/10 pos: 0 flags: 02100002 mnt_id: 26 ino: 501 drm-driver: i915 drm-pdev: 0000:00:02.0 drm-client-id: 22 drm-engine-render: 196329331 ns drm-engine-copy: 0 ns drm-engine-video: 0 ns drm-engine-capacity-video: 2 drm-engine-video-enhance: 0 ns
P.S. There is no AMD support in the current code, or nothing for memory either. Both can be added later.
Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification
Wow, nice.
Certainly +1 from my side to have that generalized, documented and uniform among all drivers.
Regards,
Christian.
Am 25.01.22 um 11:24 schrieb Tvrtko Ursulin:
Quoted 50 lines · Tvrtko Ursulin
Quoted 1 line · Rob Clark
[snip]
Quoted 4 lines
Quoted 2 lines
If there is a tool somewhere that displays this info, that would be useful for testing my implementation.
I have a patch to Intel specific
intel_gpu_top(see https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F468491%2F%3Fseries%3D98555%26rev%3D1&data=04%7C01%7Cchristian.koenig%40amd.com%7C99e7138493364003d3e908d9dfece57f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637787030821307243%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=X5Qa7rZkyvplRJ5fJwaKjwa%2FtII9EZmg5PIYMOcqKiA%3D&reserved=0). I'll have a look to see how much work would it be to extract common bits into a library and write a quick agnostic tool using it.I factored out some code from
intel_gpu_topin a quick and dirty attempt to make it generic and made a very rudimentarytools/gputop:If you manage to export the right fdinfo tags (basically https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F468502%2F%3Fseries%3D92574%26rev%3D6&data=04%7C01%7Cchristian.koenig%40amd.com%7C99e7138493364003d3e908d9dfece57f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637787030821307243%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=a0aBjo%2B2WyfzSfrjWkHteEuZAmncLbO8Z%2F5ypZKumlU%3D&reserved=0)*, with the only local addition I have being the optional "drm-engine-capacity-<str>: <uint>" tag, we may get lucky and tool might even work. Let me know when you try. If it will work you should see something like this:
DRM minor 0
PID NAME render copy video3838 kwin_x11 |█ || || || | 327056 mpv | || ||▌ || | 327056 mpv |▌ || || || | 1 systemd |▍ || || || | 3884 plasmashell | || || || | 4794 krunner | || || || | 4836 thunderbird | || || || | 296733 GeckoMain | || || || |Regards,
Tvrtko
*) Or for more reference this is how the i915 output looks like:
$ sudo cat /proc/7296/fdinfo/10 pos: 0 flags: 02100002 mnt_id: 26 ino: 501 drm-driver: i915 drm-pdev: 0000:00:02.0 drm-client-id: 22 drm-engine-render: 196329331 ns drm-engine-copy: 0 ns drm-engine-video: 0 ns drm-engine-capacity-video: 2 drm-engine-video-enhance: 0 ns
P.S. There is no AMD support in the current code, or nothing for memory either. Both can be added later.
Re: [PATCH 7/7] drm/i915: Expose client engine utilisation via fdinfo
In reply to Tvrtko UrsulinQuoted 63 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Similar to AMD commit
874442541133 ("drm/amdgpu: Addshow_fdinfo()interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915.Example of the output:
pos: 0
flags: 0100002
mnt_id: 21
drm-driver: i915
drm-pdev: 0000:00:02.0drm-client-id: 7 drm-engine-render: 9288864723 ns drm-engine-copy: 2035071108 ns drm-engine-video: 0 nsdrm-engine-video-enhance: 0 ns
v2:
* Update for removal of name and pid.v3:
* Use drm_driver.name.Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Chris Healy <[email protected]>Acked-by Christian König <[email protected]>---
Documentation/gpu/drm-usage-stats.rst | 6 +++ Documentation/gpu/i915.rst | 27 ++++++++++ drivers/gpu/drm/i915/i915_driver.c | 3 ++ drivers/gpu/drm/i915/i915_drm_client.c | 73 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 4 ++ 5 files changed, 113 insertions(+)Documentation/gpu/drm-usage-stats.rst +0
-0@@ -95,3 +95,9 @@ object belong to this client, in the respective memory region.Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' indicating kibi- or mebi-bytes.
Documentation/gpu/drm-usage-stats.rst +6
-0+ +=============================== +Driver specific implementations +=============================== + +:ref:`i915-usage-stats`Documentation/gpu/i915.rst +0
-0@@ -708,3 +708,30 @@ The style guide for ``i915_reg.h``... kernel-doc::
drivers/gpu/drm/i915/i915_reg.h
:doc: The i915 register macro definition style guideDocumentation/gpu/i915.rst +1
-0+
Documentation/gpu/i915.rst The style guide for ``i915_reg.h``. · line 721
Quoted 10 lines
Documentation/gpu/i915.rst +10
-0+.. _i915-usage-stats: + +i915 DRM client usage stats implementation +========================================== + +The drm/i915 driver implements the DRM client usage stats specification as +documented in :ref:`drm-client-usage-stats`. + +Example of the output showing the implemented key value pairs and entirety of +the currenly possible format options:
s/currenly/currently/
lgtm, for the series
Regards,
Umesh
Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification
In reply to Tvrtko UrsulinHi Rob,
Quoted 6 lines · Tvrtko Ursulin
Quoted 1 line · Tvrtko Ursulin
On 20/01/2022 16:44, Rob Clark wrote:
[snip]
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
If there is a tool somewhere that displays this info, that would be useful for testing my implementation.
I have a patch to Intel specific
intel_gpu_top(see https://patchwork.freedesktop.org/patch/468491/?series=98555&rev=1). I'll have a look to see how much work would it be to extract common bits into a library and write a quick agnostic tool using it.I factored out some code from
intel_gpu_topin a quick and dirty attempt to make it generic and made a very rudimentarytools/gputop:https://cgit.freedesktop.org/~tursulin/intel-gpu-tools/log/?h=gputop
Have you managed to spend any time playing with this yet?
The only remaining open was Daniel's mild concern if vendor agnostic userspace is possible using the proposed spec. If you managed to wire up the compliant exports and gputop tool works I think that concern would be settled.
Regards,
Tvrtko
Re: [PATCH 7/7] drm/i915: Expose client engine utilisation via fdinfo
In reply to Umesh Nerlige RamappaQuoted 80 lines · Umesh Nerlige Ramappa
Quoted 74 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Similar to AMD commit
874442541133 ("drm/amdgpu: Addshow_fdinfo()interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915.Example of the output:
pos: 0
flags: 0100002
mnt_id: 21
drm-driver: i915
drm-pdev: 0000:00:02.0
drm-client-id: 7
drm-engine-render: 9288864723 ns
drm-engine-copy: 2035071108 ns
drm-engine-video: 0 ns
drm-engine-video-enhance: 0 nsv2:
* Update for removal of name and pid.v3:
* Use drm_driver.name.Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Chris Healy <[email protected]>Acked-by Christian König <[email protected]>---
Documentation/gpu/drm-usage-stats.rst | 6 +++ Documentation/gpu/i915.rst | 27 ++++++++++ drivers/gpu/drm/i915/i915_driver.c | 3 ++drivers/gpu/drm/i915/i915_drm_client.c| 73 ++++++++++++++++++++++++++drivers/gpu/drm/i915/i915_drm_client.h| 4 ++5 files changed, 113 insertions(+)Documentation/gpu/drm-usage-stats.rst +0
-0@@ -95,3 +95,9 @@ object belong to this client, in the respectivememory region.
Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' indicating kibi- or mebi-bytes.
Documentation/gpu/drm-usage-stats.rst +6
-0+ +=============================== +Driver specific implementations +=============================== + +:ref:`i915-usage-stats`Documentation/gpu/i915.rst +0
-0@@ -708,3 +708,30 @@ The style guide for ``i915_reg.h``... kernel-doc::
drivers/gpu/drm/i915/i915_reg.h:doc: The i915 register macro definition style guideDocumentation/gpu/i915.rst +7
-0+ +.. _i915-usage-stats: + +i915 DRM client usage stats implementation +========================================== + +The drm/i915 driver implements the DRM client usage statsspecification as
Documentation/gpu/i915.rst +3
-0+documented in :ref:`drm-client-usage-stats`. + +Example of the output showing the implemented key value pairs andQuoted 2 lines
entirety of
+the currenly possible format options:s/currenly/currently/
Quoted 2 lines
lgtm, for the series
Reviewed-by Umesh Nerlige Ramappa <[email protected]>
Thanks Umesh!
There will be a small re-spin, mostly about adding drm-engine-capacity- tag which I needed for vendor agnostic gputop, and couple fixups. Some r-b's will need updating. I will copy you when sending it out.
Regards,
Tvrtko