Skip to contentSkip to conversation

drm/i915/pxp: Hold RPM wakelock during PXP unbind

PATCH In review Juston Li 4 participants 7 messages Jan 6, 2022 – Jan 18, 2022

Subsystems (2)
lore
Share & tools
lore

Juston Li

author
#0 lore raw

v2 cover drm/i915/pxp: Hold RPM wakelock during PXP unbind

Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock during PXP suspend") but to fix the same warning for unbind during shutdown

See https://patchwork.freedesktop.org/series/98310/ for trybot pass with DRM_I915_PXP enabled.

Changes since v1:
- Rebased to latest drm-tip

Juston Li (1):
drm/i915/pxp: Hold RPM wakelock during PXP unbind

 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v2 1/1 drm/i915/pxp: Hold RPM wakelock during PXP unbind

Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock during PXP suspend") but to fix the same warning for unbind during shutdown:

------------[ cut here ]------------
RPM wakelock ref not held during HW access
WARNING: CPU: 0 PID: 4139 at drivers/gpu/drm/i915/intel_runtime_pm.h:115
gen12_fwtable_write32+0x1b7/0
Modules linked in: 8021q ccm rfcomm cmac algif_hash algif_skcipher
af_alg uinput snd_hda_codec_hdmi vf industrialio iwl7000_mac80211
cros_ec_sensorhub lzo_rle lzo_compress zram iwlwifi cfg80211 joydev
CPU: 0 PID: 4139 Comm: halt Tainted: G     U  W
5.10.84 #13 344e11e079c4a03940d949e537eab645f6
RIP: 0010:gen12_fwtable_write32+0x1b7/0x200
Code: 48 c7 c7 fc b3 b5 89 31 c0 e8 2c f3 ad ff 0f 0b e9 04 ff ff ff c6
05 71 e9 1d 01 01 48 c7 c7 d67
RSP: 0018:ffffa09ec0bb3bb0 EFLAGS: 00010246
RAX: 12dde97bbd260300 RBX: 00000000000320f0 RCX: ffffffff89e60ea0
RDX: 0000000000000000 RSI: 00000000ffffdfff RDI: ffffffff89e60e70
RBP: ffffa09ec0bb3bd8 R08: 0000000000000000 R09: ffffa09ec0bb3950
R10: 00000000ffffdfff R11: ffffffff89e91160 R12: 0000000000000000
R13: 0000000028121969 R14: ffff9515c32f0990 R15: 0000000040000000
FS:  0000790dcf225740(0000) GS:ffff951737800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000058b25efae147 CR3: 0000000133ea6001 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 intel_pxp_fini_hw+0x2f/0x39
 i915_pxp_tee_component_unbind+0x1c/0x42
 component_unbind+0x32/0x48
 component_unbind_all+0x80/0x9d
 take_down_master+0x24/0x36
 component_master_del+0x56/0x70
 mei_pxp_remove+0x2c/0x68
 mei_cl_device_remove+0x35/0x68
 device_release_driver_internal+0x100/0x1a1
 mei_cl_bus_remove_device+0x21/0x79
 mei_cl_bus_remove_devices+0x3b/0x51
 mei_stop+0x3b/0xae
 mei_me_shutdown+0x23/0x58
 device_shutdown+0x144/0x1d3
 kernel_power_off+0x13/0x4c
 __se_sys_reboot+0x1d4/0x1e9
 do_syscall_64+0x43/0x55
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x790dcf316273
Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00

00 89 fa be 69 19 12 28 bf ad8
RSP: 002b:00007ffca0df9198 EFLAGS: 00000202 ORIG_RAX: 00000000000000a9
RAX: ffffffffffffffda RBX: 000000004321fedc RCX: 0000790dcf316273
RDX: 000000004321fedc RSI: 0000000028121969 RDI: 00000000fee1dead
RBP: 00007ffca0df9200 R08: 0000000000000007 R09: 0000563ce8cd8970
R10: 0000000000000000 R11: 0000000000000202 R12: 00007ffca0df9308
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000003

---[ end trace 2f501b01b348f114 ]---

ACPI: Preparing to enter system sleep state S5
reboot: Power down

Changes since v1:
- Rebase to latest drm-tip

Fixes 0cfab4cb3c4e ("drm/i915/pxp: Enable PXP power management")
---
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +4 -1
index 195b2323ec00..4b6f5655fab5 100644
@@ -107,9 +107,12 @@ static int i915_pxp_tee_component_bind(struct device *i915_kdev,
 static void i915_pxp_tee_component_unbind(struct device *i915_kdev,
 					  struct device *tee_kdev, void *data)
 {
+	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
 	struct intel_pxp *pxp = i915_dev_to_pxp(i915_kdev);
+	intel_wakeref_t wakeref;
 
-	intel_pxp_fini_hw(pxp);
+	with_intel_runtime_pm_if_in_use(&i915->runtime_pm, wakeref)
+		intel_pxp_fini_hw(pxp);
 
 	mutex_lock(&pxp->tee_mutex);
 	pxp->pxp_component = NULL;
Signature · 1 line
2.31.1
#5 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: Hold RPM wakelock during PXP unbind (rev3)

In reply to Juston Li
== Series Details ==

== Series Details ==

Series: drm/i915/pxp: Hold RPM wakelock during PXP unbind (rev3)
URL : https://patchwork.freedesktop.org/series/98245/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11052 -> Patchwork_21934
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/index.html

Participating hosts (44 -> 34)
------------------------------

Missing (10): fi-kbl-soraka bat-dg1-6 bat-dg1-5 fi-bsw-n3050 fi-icl-u2 fi-bsw-cyan bat-adlp-6 bat-rpls-1 fi-bdw-samus bat-jsl-1

Known issues
------------

Here are the changes found in Patchwork_21934 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +31 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-bdw-5557u/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][2] ([fdo#109271]) +18 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-skl-6600u/igt@amdgpu/[email protected]

* igt@amdgpu/amd_prime@i915-to-amd:
- fi-snb-2520m: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-snb-2520m/igt@amdgpu/[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][4] -> [INCOMPLETE][5] ([i915#3921])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-snb-2600/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [PASS][6] -> [DMESG-FAIL][7] ([i915#2927] / [i915#3428])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html

* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-bdw-5557u/igt@[email protected]

* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][9] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-bsw-nick/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_contexts:
- fi-snb-2520m: [DMESG-FAIL][10] ([i915#4610]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][12] ([i915#4269]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-cml-u2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-cml-u2/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [INCOMPLETE][14] ([i915#4838]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4610]: https://gitlab.freedesktop.org/drm/intel/issues/4610
[i915#4838]: https://gitlab.freedesktop.org/drm/intel/issues/4838

Build changes
-------------

* Linux: CI_DRM_11052 -> Patchwork_21934

CI-20190529: 20190529
CI_DRM_11052: 5926026a36a658f615b8a5aaa74a90a2a3c5e6c5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6324: 6e009504d5f7cc39866191e4bff813a4512c3e9b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21934: 7730367ddefca8df21b067f9f16ac39c3918624f @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

7730367ddefc drm/i915/pxp: Hold RPM wakelock during PXP unbind

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/index.html

#6 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: Hold RPM wakelock during PXP unbind (rev3)

In reply to Juston Li
== Series Details ==

== Series Details ==

Series: drm/i915/pxp: Hold RPM wakelock during PXP unbind (rev3)
URL : https://patchwork.freedesktop.org/series/98245/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21934_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (13 -> 13)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_21934_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_create@busy-create:
- {shard-rkl}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-rkl-5/igt@[email protected]

* igt@gem_exec_flush@basic-uc-prw-default:
- {shard-rkl}: ([PASS][3], [PASS][4]) -> [INCOMPLETE][5]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-rkl-5/igt@[email protected]

* igt@gem_exec_whisper@basic-contexts-forked-all:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][6] +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-rkl-5/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- {shard-tglu}: NOTRUN -> [SKIP][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglu-3/igt@[email protected]

* igt@kms_flip@dpms-off-confusion-interruptible@c-hdmi-a3:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][8] +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-dg1-18/igt@kms_flip@[email protected]

* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- {shard-tglu}: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglu-6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglu-1/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_21934_full that come from known issues:

### CI changes ###

#### Possible fixes ####

* boot:
- shard-apl: ([PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [FAIL][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35]) ([i915#4386]) -> ([PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl7/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl7/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl7/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl3/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl3/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl3/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl1/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl1/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl1/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl2/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl2/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl2/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl6/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl6/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl6/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl7/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl7/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl7/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl8/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl8/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl8/boot.html

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#280])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][62] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-tglb: [PASS][63] -> [FAIL][64] ([i915#2846])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglb1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb6/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][65] -> [FAIL][66] ([i915#2842])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglb1/igt@gem_exec_fair@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [PASS][67] -> [FAIL][68] ([i915#2842]) +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-kbl7/igt@gem_exec_fair@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][69] -> [SKIP][70] ([fdo#109271])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-kbl1/igt@gem_exec_fair@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: NOTRUN -> [FAIL][71] ([i915#2842])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][72] -> [FAIL][73] ([i915#2842]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/igt@gem_exec_fair@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#2842]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-glk4/igt@gem_exec_fair@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][76] -> [FAIL][77] ([i915#2842]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb7/igt@gem_exec_fair@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][78] ([i915#2842]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][79] -> [SKIP][80] ([i915#2190])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglb1/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb7/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#4613])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/igt@[email protected]

* igt@gem_lmem_swapping@heavy-multi:
- shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#4613])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl3/igt@[email protected]

* igt@gem_lmem_swapping@parallel-multi:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#4613])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#4613])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl9/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][85] ([i915#4613])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][86] -> [DMESG-WARN][87] ([i915#1436] / [i915#716])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-glk3/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-glk7/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#1937])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl3/igt@i915_pm_lpsp@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][89] -> [DMESG-WARN][90] ([i915#180]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl8/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl4/igt@[email protected]

* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-glk: [PASS][91] -> [DMESG-WARN][92] ([i915#118])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-glk1/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-glk2/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][93] ([i915#3743])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl3/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3777])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl9/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#3777])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl7/igt@[email protected]

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#3886]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3886]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109278] / [i915#3886])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-crc-primary-basic-yf_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109278]) +6 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@kms_ccs@pipe-d-crc-primary-basic-yf_tiled_ccs.html
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#111615] / [i915#3689])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@kms_ccs@pipe-d-crc-primary-basic-yf_tiled_ccs.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][101] ([i915#3689]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs:
- shard-kbl: NOTRUN -> [SKIP][102] ([fdo#109271]) +104 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl4/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs.html

* igt@kms_chamelium@dp-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109284] / [fdo#111827]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb8/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271] / [fdo#111827]) +7 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl3/igt@[email protected]

* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [fdo#111827]) +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/igt@[email protected]

* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278] / [i915#1149])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-negative:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109284] / [fdo#111827]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][108] ([fdo#109271] / [fdo#111827]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl9/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][109] ([i915#1319])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl6/igt@[email protected]

* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109300] / [fdo#111066])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@kms_content_protection@mei_interface.html

* igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen:
- shard-glk: [PASS][111] -> [FAIL][112] ([i915#3444])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-glk1/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-glk2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109278] / [fdo#109279])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109279] / [i915#3359])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][115] ([i915#180])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl1/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-skl: NOTRUN -> [SKIP][116] ([fdo#109271]) +16 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl9/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][117] -> [FAIL][118] ([i915#2346] / [i915#533])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#533]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl4/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109274])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][121] -> [FAIL][122] ([i915#79])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl8/igt@kms_flip@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [PASS][123] -> [INCOMPLETE][124] ([i915#4839])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl4/igt@kms_flip@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl5/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-dp1:
- shard-kbl: NOTRUN -> [FAIL][125] ([i915#2122])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][126] ([fdo#109280] / [fdo#111825]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][127] ([fdo#109280]) +6 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][128] -> [FAIL][129] ([i915#1188])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl9/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][130] -> [DMESG-WARN][131] ([i915#180]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-kbl6/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl1/igt@[email protected]

* igt@kms_plane_cursor@pipe-d-viewport-size-128:
- shard-apl: NOTRUN -> [SKIP][132] ([fdo#109271]) +32 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl3/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][133] ([i915#3536])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb8/igt@[email protected]

* igt@kms_plane_lowres@pipe-d-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][134] ([i915#3536])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][135] -> [SKIP][136] ([fdo#109441]) +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb1/igt@kms_psr@psr2_no_drrs.html

* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][137] ([i915#132] / [i915#3467])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
- shard-iclb: NOTRUN -> [SKIP][138] ([fdo#109441])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][139] -> [FAIL][140] ([i915#31])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-apl2/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-apl1/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][141] ([fdo#109271] / [i915#2437])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl3/igt@[email protected]

* igt@perf@polling:
- shard-skl: [PASS][142] -> [FAIL][143] ([i915#1542])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl9/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl8/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-iclb: [PASS][144] -> [FAIL][145] ([i915#1542])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb8/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb5/igt@[email protected]

* igt@prime_nv_api@i915_nv_import_twice:
- shard-iclb: NOTRUN -> [SKIP][146] ([fdo#109291])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb6/igt@prime_nv_api@i915_nv_import_twice.html

* igt@sysfs_clients@sema-10:
- shard-kbl: NOTRUN -> [SKIP][147] ([fdo#109271] / [i915#2994])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl4/igt@[email protected]

#### Possible fixes ####

* igt@drm_read@short-buffer-nonblock:
- {shard-rkl}: ([SKIP][148], [SKIP][149]) ([i915#4098]) -> [PASS][150]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-2/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-4/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-rkl-6/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-skl: [INCOMPLETE][151] ([i915#4793]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-skl8/igt@gem_ctx_isolation@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-skl3/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@legacy-engines-hang@render:
- {shard-dg1}: [DMESG-WARN][153] ([i915#4892]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-dg1-16/igt@gem_ctx_persistence@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-dg1-17/igt@gem_ctx_persistence@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- {shard-tglu}: [INCOMPLETE][155] -> [PASS][156] +1 similar issue
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglu-7/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglu-8/igt@[email protected]

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][157] ([i915#4525]) -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb7/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-iclb: [FAIL][159] ([i915#2846]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-iclb7/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-iclb7/igt@[email protected]
- {shard-rkl}: [FAIL][161] ([i915#2846]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-6/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-rkl-2/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][163] ([i915#2842]) -> [PASS][164]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-tglb5/igt@gem_exec_fair@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][165] ([i915#2842]) -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-kbl4/igt@gem_exec_fair@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][167] -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-dg1-18/igt@i915_pm_lpsp@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/shard-dg1-16/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@drm-resources-equal:
- {shard-rkl}: [SKIP][169] ([fdo#109308]) -> [PASS][170]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11052/shard-rkl-2/igt@[email protected]
[170]

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21934/index.html

maintainer Reviewed-by on v2 1/1
#2 lore raw
In reply to Juston Li
Quoted 59 lines · Juston Li

Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock during PXP suspend") but to fix the same warning for unbind during shutdown:

------------[ cut here ]------------
RPM wakelock ref not held during HW access
WARNING: CPU: 0 PID: 4139 at drivers/gpu/drm/i915/intel_runtime_pm.h:115
gen12_fwtable_write32+0x1b7/0
Modules linked in: 8021q ccm rfcomm cmac algif_hash algif_skcipher
af_alg uinput snd_hda_codec_hdmi vf industrialio iwl7000_mac80211
cros_ec_sensorhub lzo_rle lzo_compress zram iwlwifi cfg80211 joydev
CPU: 0 PID: 4139 Comm: halt Tainted: G     U  W
5.10.84 #13 344e11e079c4a03940d949e537eab645f6
RIP: 0010:gen12_fwtable_write32+0x1b7/0x200
Code: 48 c7 c7 fc b3 b5 89 31 c0 e8 2c f3 ad ff 0f 0b e9 04 ff ff ff c6
05 71 e9 1d 01 01 48 c7 c7 d67
RSP: 0018:ffffa09ec0bb3bb0 EFLAGS: 00010246
RAX: 12dde97bbd260300 RBX: 00000000000320f0 RCX: ffffffff89e60ea0
RDX: 0000000000000000 RSI: 00000000ffffdfff RDI: ffffffff89e60e70
RBP: ffffa09ec0bb3bd8 R08: 0000000000000000 R09: ffffa09ec0bb3950
R10: 00000000ffffdfff R11: ffffffff89e91160 R12: 0000000000000000
R13: 0000000028121969 R14: ffff9515c32f0990 R15: 0000000040000000
FS:  0000790dcf225740(0000) GS:ffff951737800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000058b25efae147 CR3: 0000000133ea6001 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 intel_pxp_fini_hw+0x2f/0x39
 i915_pxp_tee_component_unbind+0x1c/0x42
 component_unbind+0x32/0x48
 component_unbind_all+0x80/0x9d
 take_down_master+0x24/0x36
 component_master_del+0x56/0x70
 mei_pxp_remove+0x2c/0x68
 mei_cl_device_remove+0x35/0x68
 device_release_driver_internal+0x100/0x1a1
 mei_cl_bus_remove_device+0x21/0x79
 mei_cl_bus_remove_devices+0x3b/0x51
 mei_stop+0x3b/0xae
 mei_me_shutdown+0x23/0x58
 device_shutdown+0x144/0x1d3
 kernel_power_off+0x13/0x4c
 __se_sys_reboot+0x1d4/0x1e9
 do_syscall_64+0x43/0x55
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x790dcf316273
Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00

00 89 fa be 69 19 12 28 bf ad8
RSP: 002b:00007ffca0df9198 EFLAGS: 00000202 ORIG_RAX: 00000000000000a9
RAX: ffffffffffffffda RBX: 000000004321fedc RCX: 0000790dcf316273
RDX: 000000004321fedc RSI: 0000000028121969 RDI: 00000000fee1dead
RBP: 00007ffca0df9200 R08: 0000000000000007 R09: 0000563ce8cd8970
R10: 0000000000000000 R11: 0000000000000202 R12: 00007ffca0df9308
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000003

---[ end trace 2f501b01b348f114 ]---

ACPI: Preparing to enter system sleep state S5
reboot: Power down

Quoted 7 lines

Changes since v1:
- Rebase to latest drm-tip

Fixes 0cfab4cb3c4e ("drm/i915/pxp: Enable PXP power management")

and pushing to drm-intel-next right now.

Thanks for the patch.

Quoted 25 lines
---
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +4 -1
index 195b2323ec00..4b6f5655fab5 100644
@@ -107,9 +107,12 @@ static int i915_pxp_tee_component_bind(struct device *i915_kdev,
 static void i915_pxp_tee_component_unbind(struct device *i915_kdev,
 					  struct device *tee_kdev, void *data)
 {
+	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
 	struct intel_pxp *pxp = i915_dev_to_pxp(i915_kdev);
+	intel_wakeref_t wakeref;
 
-	intel_pxp_fini_hw(pxp);
+	with_intel_runtime_pm_if_in_use(&i915->runtime_pm, wakeref)
+		intel_pxp_fini_hw(pxp);
 
 	mutex_lock(&pxp->tee_mutex);
 	pxp->pxp_component = NULL;
Signature · 1 line
2.31.1
maintainer
#3 lore raw
Quoted 68 lines · Rodrigo Vivi
Quoted 59 lines · Juston Li

Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock during PXP suspend") but to fix the same warning for unbind during shutdown:

------------[ cut here ]------------
RPM wakelock ref not held during HW access
WARNING: CPU: 0 PID: 4139 at drivers/gpu/drm/i915/intel_runtime_pm.h:115
gen12_fwtable_write32+0x1b7/0
Modules linked in: 8021q ccm rfcomm cmac algif_hash algif_skcipher
af_alg uinput snd_hda_codec_hdmi vf industrialio iwl7000_mac80211
cros_ec_sensorhub lzo_rle lzo_compress zram iwlwifi cfg80211 joydev
CPU: 0 PID: 4139 Comm: halt Tainted: G     U  W
5.10.84 #13 344e11e079c4a03940d949e537eab645f6
RIP: 0010:gen12_fwtable_write32+0x1b7/0x200
Code: 48 c7 c7 fc b3 b5 89 31 c0 e8 2c f3 ad ff 0f 0b e9 04 ff ff ff c6
05 71 e9 1d 01 01 48 c7 c7 d67
RSP: 0018:ffffa09ec0bb3bb0 EFLAGS: 00010246
RAX: 12dde97bbd260300 RBX: 00000000000320f0 RCX: ffffffff89e60ea0
RDX: 0000000000000000 RSI: 00000000ffffdfff RDI: ffffffff89e60e70
RBP: ffffa09ec0bb3bd8 R08: 0000000000000000 R09: ffffa09ec0bb3950
R10: 00000000ffffdfff R11: ffffffff89e91160 R12: 0000000000000000
R13: 0000000028121969 R14: ffff9515c32f0990 R15: 0000000040000000
FS:  0000790dcf225740(0000) GS:ffff951737800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000058b25efae147 CR3: 0000000133ea6001 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
 intel_pxp_fini_hw+0x2f/0x39
 i915_pxp_tee_component_unbind+0x1c/0x42
 component_unbind+0x32/0x48
 component_unbind_all+0x80/0x9d
 take_down_master+0x24/0x36
 component_master_del+0x56/0x70
 mei_pxp_remove+0x2c/0x68
 mei_cl_device_remove+0x35/0x68
 device_release_driver_internal+0x100/0x1a1
 mei_cl_bus_remove_device+0x21/0x79
 mei_cl_bus_remove_devices+0x3b/0x51
 mei_stop+0x3b/0xae
 mei_me_shutdown+0x23/0x58
 device_shutdown+0x144/0x1d3
 kernel_power_off+0x13/0x4c
 __se_sys_reboot+0x1d4/0x1e9
 do_syscall_64+0x43/0x55
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x790dcf316273
Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00

00 89 fa be 69 19 12 28 bf ad8
RSP: 002b:00007ffca0df9198 EFLAGS: 00000202 ORIG_RAX: 00000000000000a9
RAX: ffffffffffffffda RBX: 000000004321fedc RCX: 0000790dcf316273
RDX: 000000004321fedc RSI: 0000000028121969 RDI: 00000000fee1dead
RBP: 00007ffca0df9200 R08: 0000000000000007 R09: 0000563ce8cd8970
R10: 0000000000000000 R11: 0000000000000202 R12: 00007ffca0df9308
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000003

---[ end trace 2f501b01b348f114 ]---

ACPI: Preparing to enter system sleep state S5
reboot: Power down

Quoted 7 lines

Changes since v1:
- Rebase to latest drm-tip

Fixes 0cfab4cb3c4e ("drm/i915/pxp: Enable PXP power management")
Quoted 5 lines

and pushing to drm-intel-next right now.

Thanks for the patch.

As it happens, this had already been pushed to drm-intel-gt-next by John:

commit 57ded5fc98b11d76dae505ca3591b61c9dbbbda7

Author:     Juston Li <[email protected]>
AuthorDate: Thu Jan 6 12:02:36 2022 -0800
Commit:     John Harrison <[email protected]>
CommitDate: Fri Jan 7 15:30:23 2022 -0800

drm/i915/pxp: Hold RPM wakelock during PXP unbind

I don't know if the problem is common enough to warrant more checks. It does help to reply to the list when one pushes patches, and although at least I almost always do it, we haven't really made it a requirement either.

BR,
Jani.

Quoted 26 lines
Quoted 26 lines
---
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +4 -1
index 195b2323ec00..4b6f5655fab5 100644
@@ -107,9 +107,12 @@ static int i915_pxp_tee_component_bind(struct device *i915_kdev,
 static void i915_pxp_tee_component_unbind(struct device *i915_kdev,
 					  struct device *tee_kdev, void *data)
 {
+	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
 	struct intel_pxp *pxp = i915_dev_to_pxp(i915_kdev);
+	intel_wakeref_t wakeref;
 
-	intel_pxp_fini_hw(pxp);
+	with_intel_runtime_pm_if_in_use(&i915->runtime_pm, wakeref)
+		intel_pxp_fini_hw(pxp);
 
 	mutex_lock(&pxp->tee_mutex);
 	pxp->pxp_component = NULL;
Signature · 1 line
2.31.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
maintainer
#4 lore raw
Quoted 79 lines · Jani Nikula
Quoted 78 lines · Rodrigo Vivi
Quoted 76 lines · Juston Li

Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock during
PXP suspend") but to fix the same warning for unbind during shutdown:

------------[ cut here ]------------
RPM wakelock ref not held during HW access
WARNING: CPU: 0 PID: 4139 at
drivers/gpu/drm/i915/intel_runtime_pm.h:115
gen12_fwtable_write32+0x1b7/0
Modules linked in: 8021q ccm rfcomm cmac algif_hash

algif_skcipher
af_alg uinput snd_hda_codec_hdmi vf industrialio iwl7000_mac80211 cros_ec_sensorhub lzo_rle lzo_compress zram iwlwifi cfg80211 joydev

CPU: 0 PID: 4139 Comm: halt Tainted: G     U  W
5.10.84 #13 344e11e079c4a03940d949e537eab645f6
RIP: 0010:gen12_fwtable_write32+0x1b7/0x200
Code: 48 c7 c7 fc b3 b5 89 31 c0 e8 2c f3 ad ff 0f 0b e9 04 ff ff

ff c6
05 71 e9 1d 01 01 48 c7 c7 d67
RSP: 0018:ffffa09ec0bb3bb0 EFLAGS: 00010246
RAX: 12dde97bbd260300 RBX: 00000000000320f0 RCX: ffffffff89e60ea0
RDX: 0000000000000000 RSI: 00000000ffffdfff RDI: ffffffff89e60e70
RBP: ffffa09ec0bb3bd8 R08: 0000000000000000 R09: ffffa09ec0bb3950
R10: 00000000ffffdfff R11: ffffffff89e91160 R12: 0000000000000000
R13: 0000000028121969 R14: ffff9515c32f0990 R15: 0000000040000000 FS:  0000790dcf225740(0000) GS:ffff951737800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000058b25efae147 CR3: 0000000133ea6001 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400
PKRU: 55555554

Call Trace:
 intel_pxp_fini_hw+0x2f/0x39
 i915_pxp_tee_component_unbind+0x1c/0x42
 component_unbind+0x32/0x48
 component_unbind_all+0x80/0x9d
 take_down_master+0x24/0x36
 component_master_del+0x56/0x70
 mei_pxp_remove+0x2c/0x68
 mei_cl_device_remove+0x35/0x68
 device_release_driver_internal+0x100/0x1a1
 mei_cl_bus_remove_device+0x21/0x79
 mei_cl_bus_remove_devices+0x3b/0x51
 mei_stop+0x3b/0xae
 mei_me_shutdown+0x23/0x58
 device_shutdown+0x144/0x1d3
 kernel_power_off+0x13/0x4c
 __se_sys_reboot+0x1d4/0x1e9
 do_syscall_64+0x43/0x55
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x790dcf316273
Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f

44 00
00 89 fa be 69 19 12 28 bf ad8
RSP: 002b:00007ffca0df9198 EFLAGS: 00000202 ORIG_RAX:
00000000000000a9
RAX: ffffffffffffffda RBX: 000000004321fedc RCX: 0000790dcf316273
RDX: 000000004321fedc RSI: 0000000028121969 RDI: 00000000fee1dead
RBP: 00007ffca0df9200 R08: 0000000000000007 R09: 0000563ce8cd8970
R10: 0000000000000000 R11: 0000000000000202 R12: 00007ffca0df9308
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000003

---[ end trace 2f501b01b348f114 ]---

ACPI: Preparing to enter system sleep state S5
reboot: Power down

Changes since v1:
 - Rebase to latest drm-tip

Fixes 0cfab4cb3c4e ("drm/i915/pxp: Enable PXP power management")
Reviewed-by Daniele Ceraolo Spurio

<[email protected]>

Quoted 8 lines
Quoted 5 lines

and pushing to drm-intel-next right now.

Thanks for the patch.

As it happens, this had already been pushed to drm-intel-gt-next by John:

doh! (facepalm)
sorry for the mistake this should be really in -gt-next luckly no conflicts so the propagation should be transparent, but lesson learned...

Quoted 54 lines

commit 57ded5fc98b11d76dae505ca3591b61c9dbbbda7 Author:     Juston Li <[email protected]>
AuthorDate: Thu Jan 6 12:02:36 2022 -0800 Commit:     John Harrison <[email protected]>
CommitDate: Fri Jan 7 15:30:23 2022 -0800

    drm/i915/pxp: Hold RPM wakelock during PXP unbind

I don't know if the problem is common enough to warrant more checks. It
does help to reply to the list when one pushes patches, and although at
least I almost always do it, we haven't really made it a requirement either.

BR,
Jani.

Quoted 31 lines
Quoted 31 lines

---
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +0 -0
index 195b2323ec00..4b6f5655fab5 100644
@@ -107,9 +107,12 @@ static int
 i915_pxp_tee_component_bind(struct device *i915_kdev,

 static void i915_pxp_tee_component_unbind(struct device *i915_kdev,
                                          struct device *tee_kdev, void *data)
 {
+       struct drm_i915_private *i915 = kdev_to_i915(i915_kdev); struct intel_pxp *pxp = i915_dev_to_pxp(i915_kdev); +       intel_wakeref_t wakeref;

-       intel_pxp_fini_hw(pxp);
+       with_intel_runtime_pm_if_in_use(&i915->runtime_pm, wakeref)
+               intel_pxp_fini_hw(pxp);

        mutex_lock(&pxp->tee_mutex); pxp->pxp_component = NULL;

Signature · 1 line
2.31.1