Skip to contentSkip to conversation

dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

PATCH Applied Rob Herring 3 participants 4 messages Jan 7, 2022 – Jan 10, 2022

Subsystems (4)
Device tree bindings IIO Analog Devices IIO drivers LTC2983 IIO temperature driver
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

The '/bits/ 64' notation applies the next <> list of values. Another <> list is encoded as 32-bits by default. IOW, each <> list needs to be preceeded with '/bits/ 64'.

While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file.

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/iio/temperature/adi,ltc2983.yaml | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)
Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml +11 -11
index 0f79d9a01c49..722781aa4697 100644
@@ -448,17 +448,17 @@ examples:
                         reg = <20>;
                         adi,sensor-type = <9>; //custom thermocouple
                         adi,single-ended;
-                        adi,custom-thermocouple = /bits/ 64
-                                 <(-50220000) 0>,
-                                 <(-30200000) 99100000>,
-                                 <(-5300000) 135400000>,
-                                 <0 273150000>,
-                                 <40200000 361200000>,
-                                 <55300000 522100000>,
-                                 <88300000 720300000>,
-                                 <132200000 811200000>,
-                                 <188700000 922500000>,
-                                 <460400000 1000000000>; //10 pairs
+                        adi,custom-thermocouple =
+                                 /bits/ 64 <(-50220000) 0>,
+                                 /bits/ 64 <(-30200000) 99100000>,
+                                 /bits/ 64 <(-5300000) 135400000>,
+                                 /bits/ 64 <0 273150000>,
+                                 /bits/ 64 <40200000 361200000>,
+                                 /bits/ 64 <55300000 522100000>,
+                                 /bits/ 64 <88300000 720300000>,
+                                 /bits/ 64 <132200000 811200000>,
+                                 /bits/ 64 <188700000 922500000>,
+                                 /bits/ 64 <460400000 1000000000>; //10 pairs
                };
 
         };
Signature · 1 line
2.32.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines

From: Rob Herring <[email protected]>
Sent: Friday, January 7, 2022 4:20 AM
To: Lars-Peter Clausen <[email protected]>; Hennerich, Michael <[email protected]>; Sa, Nuno <[email protected]>; Jonathan Cameron <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]
Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

[External]

The '/bits/ 64' notation applies the next <> list of values. Another <> list
is encoded as 32-bits by default. IOW, each <> list needs to be preceeded
with '/bits/ 64'.

Quoted 4 lines

While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Nuno Sá <[email protected]>

Thanks!
- Nuno Sá

maintainer Acked-by
#2 lore raw
Quoted 17 lines · Nuno
Quoted 17 lines

From: Rob Herring <[email protected]>
Sent: Friday, January 7, 2022 4:20 AM
To: Lars-Peter Clausen <[email protected]>; Hennerich, Michael <[email protected]>; Sa, Nuno <[email protected]>; Jonathan Cameron <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]
Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

[External]

The '/bits/ 64' notation applies the next <> list of values. Another <> list
is encoded as 32-bits by default. IOW, each <> list needs to be preceeded
with '/bits/ 64'.

Quoted 6 lines
Quoted 4 lines

While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Nuno Sá <[email protected]>

Hi Rob,

Do you want me to pick these up, or as they are fixes would you rather take them yourself to get them in quickly?

In case you want to pick this up.

Acked-by Jonathan Cameron <[email protected]>
Quoted 4 lines

Thanks!
- Nuno Sá

author maintainer Applied
#3 lore raw
In reply to Rob Herring
Quoted 4 lines · Rob Herring

The '/bits/ 64' notation applies the next <> list of values. Another <> list is encoded as 32-bits by default. IOW, each <> list needs to be preceeded with '/bits/ 64'.

Quoted 8 lines

While the dts format allows this, as a rule we don't mix sizes for DT properties since all size information is lost in the dtb file.

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/iio/temperature/adi,ltc2983.yaml | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

Applied, thanks!