ice: fix an error code in ice_cfg_phy_fec()
Subsystems (4)
PATCH 1/1 ice: fix an error code in ice_cfg_phy_fec()
Propagate the error code from ice_get_link_default_override() instead of returning success.
---
From static analysis. Not tested!
drivers/net/ethernet/intel/ice/ice_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_common.c +2 -1
@@ -3321,7 +3321,8 @@ ice_cfg_phy_fec(struct ice_port_info *pi, struct ice_aqc_set_phy_cfg_data *cfg, !ice_fw_supports_report_dflt_cfg(hw)) {struct ice_link_default_override_tlv tlv; -if (ice_get_link_default_override (&tlv, pi)) + status =ice_get_link_default_override (&tlv, pi); +if (status) goto out; if (!(tlv.options & ICE_LINK_OVERRIDE_STRICT_MODE) &&
Signature · 1 line
2.20.1
Quoted 16 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Dan Carpenter
Sent: Friday, January 7, 2022 1:32 PM
To: Brandeburg, Jesse <[email protected]>
Cc: Swanson, Evan <[email protected]>; netdev at vger.kernel.org; kernel-janitors at vger.kernel.org; intel-wired-lan at lists.osuosl.org; Jakub Kicinski <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH net] ice: fix an error code inice_cfg_phy_fec()Propagate the error code from
ice_get_link_default_override()instead of returning success.
Quoted 8 lines
Fixes ea78ce4dab05 ("ice: add link lenient and default override support")Signed-off-by Dan Carpenter <[email protected]>---
From static analysis. Not tested!drivers/net/ethernet/intel/ice/ice_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)