netfilter: egress: avoid a lockdep splat
Florian Westphal
maintainerPATCH 1/1 netfilter: egress: avoid a lockdep splat
include/linux/netfilter_netdev.h:97 suspicious rcu_dereference_check() usage! 2 locks held by sd-resolve/1100:
0: ..(rcu_read_lock_bh){1:3}, at: ip_finish_output2
1: ..(rcu_read_lock_bh){1:3}, at: __dev_queue_xmit __dev_queue_xmit+0 ..
The helper has two callers, one uses rcu_read_lock, the other rcu_read_lock_bh(). Annotate the dereference to reflect this.
---
targetting -next since its only a wrong annotation.
include/linux/netfilter_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/netfilter_netdev.h +1 -1
@@ -94,7 +94,7 @@ static inline struct sk_buff *nf_hook_egress(struct sk_buff *skb, int *rc,return skb;#endif - e =rcu_dereference (dev->nf_hooks_egress); + e =rcu_dereference_check (dev->nf_hooks_egress,rcu_read_lock_bh_held ());if (!e)return skb;
Signature · 1 line
2.34.1
Quoted 8 lines · Florian Westphal
include/linux/netfilter_netdev.h:97suspiciousrcu_dereference_check()usage! 2 locks held by sd-resolve/1100:
0: ..(rcu_read_lock_bh){1:3}, at:ip_finish_output2
1: ..(rcu_read_lock_bh){1:3}, at:__dev_queue_xmit__dev_queue_xmit+0 ..The helper has two callers, one uses
rcu_read_lock, the otherrcu_read_lock_bh(). Annotate the dereference to reflect this.
Applied, thanks