simplebench: Fix Python syntax error (reported by LGTM)
PATCH 1/1 simplebench: Fix Python syntax error (reported by LGTM)
--- scripts/simplebench/bench-example.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/simplebench/bench-example.py +1 -1
@@ -25,7 +25,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ - return bench_block_copy(env['qemu_binary'], env['cmd'], {} + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, case['source'], case['target'])
Signature · 1 line
2.30.2
Quoted 10 lines · Stefan Weil
Signed-off-by Stefan Weil <[email protected]>--- scripts/simplebench/bench-example.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/simplebench/bench-example.py +0
-0
scripts/simplebench/bench-example.py line 31
Quoted 8 lines
scripts/simplebench/bench-example.py +1
-1@@ -25,7 +25,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ - return bench_block_copy(env['qemu_binary'], env['cmd'], {} + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, case['source'], case['target'])
Quoted 20 lines · Stefan Weil
Signed-off-by Stefan Weil <[email protected]>--- scripts/simplebench/bench-example.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/simplebench/bench-example.py +1
-2@@ -25,7 +25,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ - return bench_block_copy(env['qemu_binary'], env['cmd'], {} + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, case['source'], case['target']) --
Quoted 2 lines
2.30.2
Good spot. If it's not too late and not a hassle, can you add a fixes:
commit-id in the commit message? No big deal if not.
Am 10.01.22 um 18:08 schrieb John Snow:
Quoted 25 lines · Stefan Weil
Signed-off-by: Stefan Weil <[email protected]>
---
scripts/simplebench/bench-example.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/simplebench/bench-example.py
b/scripts/simplebench/bench-example.py
index 4864435f39..fc370691e0 100644
--- a/scripts/simplebench/bench-example.py
+++ b/scripts/simplebench/bench-example.py
@@ -25,7 +25,7 @@
def bench_func(env, case):
""" Handle one "cell" of benchmarking table. """
- return bench_block_copy(env['qemu_binary'], env['cmd'], {}
+ return bench_block_copy(env['qemu_binary'], env['cmd'], {},
case['source'], case['target'])
--
2.30.2Quoted 3 lines
Good spot. If it's not too late and not a hassle, can you add a fixes: commit-id in the commit message? No big deal if not.
Reviewed-by John Snow <[email protected]>
Maybe that can be added locally to avoid a V2 patch. Here it is:
Thanks,
Stefan
Quoted 35 lines · Stefan Weil
Am 10.01.22 um 18:08 schrieb John Snow:
Quoted 20 lines · Stefan Weil
Signed-off-by Stefan Weil <[email protected]>--- scripts/simplebench/bench-example.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/simplebench/bench-example.py +1
-2@@ -25,7 +25,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ - return bench_block_copy(env['qemu_binary'], env['cmd'], {} + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, case['source'], case['target']) --Quoted 2 lines
2.30.2
Good spot. If it's not too late and not a hassle, can you add a fixes:
commit-id in the commit message? No big deal if not.Reviewed-by John Snow <[email protected]>Maybe that can be added locally to avoid a V2 patch. Here it is:
Quoted 8 lines
Fixes b2fcb0c5754c2554b8406376e99a75e9e0a6b7bdThanks,
Stefan
Got it. I just got back from holiday today, so there's still lots of mail
to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks!
--js
Quoted 37 lines · John Snow
On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil <[email protected] <mailto:[email protected]>> wrote:
Am 10.01.22 um 18:08 schrieb John Snow:Quoted 20 lines · On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <[email protected]…
Signed-off-by: Stefan Weil <[email protected] <mailto:[email protected]>> --- scripts/simplebench/bench-example.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/simplebench/bench-example.py b/scripts/simplebench/bench-example.py index 4864435f39..fc370691e0 100644 --- a/scripts/simplebench/bench-example.py +++ b/scripts/simplebench/bench-example.py @@ -25,7 +25,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ - return bench_block_copy(env['qemu_binary'], env['cmd'], {} + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, case['source'], case['target'])Quoted 7 lines
-- 2.30.2 Good spot. If it's not too late and not a hassle, can you add a fixes: commit-id in the commit message? No big deal if not. Reviewed-by: John Snow <[email protected] <mailto:[email protected]>>Maybe that can be added locally to avoid a V2 patch. Here it is:
Quoted 9 lines
Fixes b2fcb0c5754c2554b8406376e99a75e9e0a6b7bdThanks,
Stefan
Got it. I just got back from holiday today, so there's still lots of mail to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks!
It would be nice, thanks!
Signature · 2 lines
Best regards, Vladimir
Quoted 43 lines · Vladimir Sementsov-Ogievskiy
Quoted 41 lines · John Snow
On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil <[email protected] <mailto:[email protected]>> wrote:
Am 10.01.22 um 18:08 schrieb John Snow:Quoted 20 lines · On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <[email protected]…
Signed-off-by Stefan Weil <[email protected] <mailto:[email protected]>>---
scripts/simplebench/bench-example.py| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git
a/scripts/simplebench/bench-example.pyb/scripts/simplebench/bench-example.pyindex4864435f39..fc370691e0100644
---a/scripts/simplebench/bench-example.py
+++b/scripts/simplebench/bench-example.py
@@ -25,7 +25,7 @@def
bench_func(env, case):
""" Handle one "cell" of benchmarking table. """
- return bench_block_copy(env['qemu_binary'], env['cmd'], {}
+ return bench_block_copy(env['qemu_binary'], env['cmd'], {},
case['source'], case['target'])Quoted 7 lines
--
2.30.2Good spot. If it's not too late and not a hassle, can you add a fixes: commit-id in the commit message? No big deal if not.
Reviewed-by John Snow <[email protected] <mailto:[email protected]>>Maybe that can be added locally to avoid a V2 patch. Here it is:
Fixes b2fcb0c5754c2554b8406376e99a75e9e0a6b7bdThanks,
Quoted 8 lines
Quoted 5 lines
Stefan
Got it. I just got back from holiday today, so there's still lots of mail to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks!
It would be nice, thanks!
Should be in origin/master by now, I forgot to update this thread.
--js