Skip to contentSkip to conversation

softingcs: Fix memleak on registration failure in softingcs_probe

PATCH Applied Miaoqian Lin 3 participants 3 messages Jan 8, 2022 – Jan 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softingcs: Fix memleak on registration failure in softingcs_probe

In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).

Fixes 0a0b7a5f7a04 ("can: add driver for Softing card")
---
 drivers/net/can/softing/softing_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/softing/softing_cs.c +1 -1
index 2e93ee792373..e5c939b63fa6 100644
@@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)
 	return 0;
 
 platform_failed:
-	kfree(dev);
+	platform_device_put(pdev);
 mem_failed:
 pcmcia_bad:
 pcmcia_failed:
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Miaoqian Lin

In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).

Fixes 0a0b7a5f7a04 ("can: add driver for Softing card")

Thanks for your patch, a similar one has already been posted:

| https://lore.kernel.org/all/[email protected]/

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
#2 lore raw
In reply to Miaoqian Lin
This patch was applied to netdev/net.git (master) by Marc Kleine-Budde <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Marc Kleine-Budde <[email protected]>:

Quoted 8 lines · On Sat, 8 Jan 2022 09:25:51 +0000 you wrote:

In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).

Fixes 0a0b7a5f7a04 ("can: add driver for Softing card")

[...]

Here is the summary with links:
- softingcs: Fix memleak on registration failure in softingcs_probe

    https://git.kernel.org/netdev/net/c/ced4913efb0a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html