i3c: master: dw: check return of dw_i3c_master_get_free_pos()

From: Tom Rix <[email protected]>

Clang static analysis reports this problem dw-i3c-master.c:799:9: warning: The result of the left shift is
undefined because the left operand is negative

                      COMMAND_PORT_DEV_INDEX(pos) |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

pos can be negative because dw_i3c_master_get_free_pos() can return an error. So check for an error.

---
 drivers/i3c/master/dw-i3c-master.c | 4 ++++
 1 file changed, 4 insertions(+)

index 03a368da51b95..51a8608203de7 100644
@@ -793,6 +793,10 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
 		return -ENOMEM;
 
 	pos = dw_i3c_master_get_free_pos(master);
+	if (pos < 0) {
+		dw_i3c_master_free_xfer(xfer);
+		return pos;
+	}
 	cmd = &xfer->cmds[0];
 	cmd->cmd_hi = 0x1;
 	cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |

2.26.3

Applied, thanks!

[1/1] i3c: master: dw: check return of dw_i3c_master_get_free_pos()

      commit: 13462ba1815db5a96891293a9cfaa2451f7bd623

Best regards,

Alexandre Belloni <[email protected]>