Skip to contentSkip to conversation

GitHub workflow fixes

PATCH In review Josh Soref 2 participants 4 messages Jan 9, 2022

lore
Share & tools
lore

Josh Soref

author
#0 lore raw

cover GitHub workflow fixes

The current workflow fails to provide a comment explaining why it has closed a PR. This is not friendly.

Also, while it's perfectly reasonable to close PRs to the qemu organization, it's a bit much to close them in forks.

These patches address both of these issues.

Josh Soref (2):
Fix lockdown comment argument
Limit lockdown to qemu

 .github/workflows/lockdown.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.32.0 (Apple Git-132)
author
#1 lore raw

PATCH 1/2 Fix lockdown comment argument

---
 .github/workflows/lockdown.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.github/workflows/lockdown.yml +1 -1
index ad8b8f7..37c6065 100644
@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: dessant/repo-lockdown@v2
         with:
-          pull-comment: |
+          pr-comment: |
             Thank you for your interest in the QEMU project.
 
             This repository is a read-only mirror of the project's repostories hosted
Signature · 1 line
2.32.0 (Apple Git-132)
author
#2 lore raw

PATCH 2/2 Limit lockdown to qemu

In reply to Josh Soref
---
 .github/workflows/lockdown.yml | 1 +
 1 file changed, 1 insertion(+)
.github/workflows/lockdown.yml +1 -0
index 37c6065..b924b25 100644
@@ -12,6 +12,7 @@ permissions:
 jobs:
   action:
     runs-on: ubuntu-latest
+    if: github.repository_owner == 'qemu'
     steps:
       - uses: dessant/repo-lockdown@v2
         with:
Signature · 1 line
2.32.0 (Apple Git-132)
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] Limit lockdown to qemu

Quoted 10 lines · Josh Soref
---
 .github/workflows/lockdown.yml | 1 +
 1 file changed, 1 insertion(+)
.github/workflows/lockdown.yml +0 -0
index 37c6065..b924b25 100644

.github/workflows/lockdown.yml permissions: · line 18

Quoted 7 lines
.github/workflows/lockdown.yml +1 -0
@@ -12,6 +12,7 @@ permissions:
 jobs:
   action:
     runs-on: ubuntu-latest
+    if: github.repository_owner == 'qemu'
     steps:
       - uses: dessant/repo-lockdown@v2
         with: