drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc
PATCH 1/1 drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc
The function performs a check on the "ctx" input parameter, however, it is used before the check.
Initialize the "base" variable after the sanity check to avoid a possible NULL pointer dereference.
Fixes 4259ff7ae509e ("drm/msm/dpu: add support for pcc color block in dpu driver")
Addresses-Coverity-ID: 1493866 ("Null pointer dereference")
Signed-off-by José Expósito <[email protected]>
--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c +9 -2
@@ -26,9 +26,16 @@ static void dpu_setup_dspp_pcc(struct dpu_hw_dspp *ctx, struct dpu_hw_pcc_cfg *cfg) { -u32 base = ctx->cap->sblk->pcc.base; +u32 base; -if (!ctx || !base) { +if (!ctx) { +DRM_ERROR ("invalid ctx %pK\n" , ctx); +return ; + } + + base = ctx->cap->sblk->pcc.base; + +if (!base) {DRM_ERROR ("invalid ctx %pK pcc base 0x%x\n" , ctx, base);return ; }
Signature · 1 line
2.25.1