pcmcia: fix setting of kthread task states
Dominik Brodowski
maintainerPATCH 1/1 pcmcia: fix setting of kthread task states
We need to set TASK_INTERRUPTIBLE before calling kthread_should_stop(). Otherwise, kthread_stop() might see that the pccardd thread is still in TASK_RUNNING state and fail to wake it up.
Additonally, we only need to set the state back to TASK_RUNNING if kthread_should_stop() breaks the loop.
Cc Matthew Wilcox <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Reported-by Al Viro <[email protected]>
Fixes d3046ba809ce ("pcmcia: fix a boot time warning in pcmcia cs code")
Signed-off-by Dominik Brodowski <[email protected]>
--- drivers/pcmcia/cs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/pcmcia/cs.c +3 -5
@@ -666,18 +666,16 @@ static int pccardd(void *__skt)if (events || sysfs_events)continue ; +set_current_state (TASK_INTERRUPTIBLE );if (kthread_should_stop ())break ; -set_current_state (TASK_INTERRUPTIBLE ); -schedule (); -/* make sure we are running */ -__set_current_state (TASK_RUNNING ); -try_to_freeze (); } +/* make sure we are running before we exit */ +__set_current_state (TASK_RUNNING );/* shut down socket, if a device is still present */ if (skt->state &SOCKET_PRESENT ) {
Signature · 1 line
2.34.1
Quoted 4 lines · Dominik Brodowski
We need to set
TASK_INTERRUPTIBLEbefore callingkthread_should_stop(). Otherwise,kthread_stop()might see that the pccardd thread is still inTASK_RUNNINGstate and fail to wake it up.
Quoted 8 lines
Additonally, we only need to set the state back to
TASK_RUNNINGifkthread_should_stop()breaks the loop.Cc Matthew Wilcox <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Reported-by Al Viro <[email protected]>Fixes d3046ba809ce ("pcmcia: fix a boot time warning in pcmcia cs code")Signed-off-by Dominik Brodowski <[email protected]>
Reviewed-by Matthew Wilcox (Oracle) <[email protected]>