Skip to contentSkip to conversation

drm/tegra: Fix reference leak in tegra_dsi_ganged_probe

PATCH New Miaoqian Lin 1 participant 1 message Jan 10, 2022

Subsystems (3)
DRM drivers Tegra architecture support DRM drivers for NVIDIA Tegra
lore
Share & tools
lore

Miaoqian Lin

author
#0 lore raw

PATCH 1/1 drm/tegra: Fix reference leak in tegra_dsi_ganged_probe

The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add put_device() call to fix this.

Fixes e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support")
Signed-off-by Miaoqian Lin <[email protected]>
---
 drivers/gpu/drm/tegra/dsi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/tegra/dsi.c +3 -1
index f46d377f0c30..de1333dc0d86 100644
@@ -1538,8 +1538,10 @@ static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi)
 		dsi->slave = platform_get_drvdata(gangster);
 		of_node_put(np);
 
-		if (!dsi->slave)
+		if (!dsi->slave) {
+			put_device(&gangster->dev);
 			return -EPROBE_DEFER;
+		}
 
 		dsi->slave->master = dsi;
 	}
Signature · 1 line
2.17.1