Skip to contentSkip to conversation

package/rtl8723bu: bump version to d34603a39a7c925d810fe17c6e8dea5063d43a33

PATCH In review Michael Fischer 2 participants 3 messages Jan 10, 2022 – Jan 11, 2022

lore
Share & tools
lore

Michael Fischer

author
#0 lore raw

PATCH 1/1 package/rtl8723bu: bump version to d34603a39a7c925d810fe17c6e8dea5063d43a33

patch 0001: Disable concurrrent mode. This causes disconnections.

Signed-off-by Michael Fischer <[email protected]>
---
 package/rtl8723bu/0001-disable_concurent_mode.patch | 12 ++++++++++++
 package/rtl8723bu/rtl8723bu.hash                    |  2 +-
 package/rtl8723bu/rtl8723bu.mk                      |  2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 package/rtl8723bu/0001-disable_concurent_mode.patch
package/rtl8723bu/0001-disable_concurent_mode.patch new file +12 -0
new file mode 100644
index 0000000000..037b1642fc
@@ -0,0 +1,12 @@
+diff -purN a/Makefile b/Makefile
+--- a/Makefile	2021-11-04 20:36:55.000000000 +0100
++++ b/Makefile	2022-01-10 14:35:17.333934039 +0100
+@@ -18,7 +18,7 @@ EXTRA_CFLAGS += -Wno-unused-label
+ EXTRA_CFLAGS += -Wno-unused-parameter
+ EXTRA_CFLAGS += -Wno-unused-function
+ EXTRA_CFLAGS += -Wno-unused
+-EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE
++#EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE
+ 
+ ccflags-y += -D__CHECK_ENDIAN__
+
package/rtl8723bu/rtl8723bu.hash +1 -1
index 04bc776a07..df990a8d63 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256  4c7314dccebda1e55ec8dcf0d5ca8915c2490d17a9f56923f25e6e0e945c10cc  rtl8723bu-9ce1c38439f4f574bb7adaf33949835c25536a28.tar.gz
+sha256  c9cde757941c88c6117560a2c350dc9c4382dcd6a313b1cae7c6e7eade7055bf  rtl8723bu-d34603a39a7c925d810fe17c6e8dea5063d43a33.tar.gz
package/rtl8723bu/rtl8723bu.mk +1 -1
index c35fad5832..e73987cfeb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RTL8723BU_VERSION = 9ce1c38439f4f574bb7adaf33949835c25536a28
+RTL8723BU_VERSION = d34603a39a7c925d810fe17c6e8dea5063d43a33
 RTL8723BU_SITE = $(call github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
 RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Michael, All,

On 2022-01-10 16:13 +0100, Michael Fischer spake thusly:

Quoted 1 line

patch 0001: Disable concurrrent mode. This causes disconnections.

That patch is missing a commit log and a sign-off for itself:

    # ./utils/check-package package/rtl8723bu/0001-disable_concurent_mode.patch
    package/rtl8723bu/0001-disable_concurent_mode.patch:0: missing Signed-off-by in the header
    (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)

But see below...

Quoted 14 lines
Signed-off-by Michael Fischer <[email protected]>
---
 package/rtl8723bu/0001-disable_concurent_mode.patch | 12 ++++++++++++
 package/rtl8723bu/rtl8723bu.hash                    |  2 +-
 package/rtl8723bu/rtl8723bu.mk                      |  2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 package/rtl8723bu/0001-disable_concurent_mode.patch
package/rtl8723bu/0001-disable_concurent_mode.patch new file +0 -0
new file mode 100644
index 0000000000..037b1642fc

package/rtl8723bu/0001-disable_concurent_mode.patch line 9

Quoted 9 lines
package/rtl8723bu/0001-disable_concurent_mode.patch new file +9 -0
@@ -0,0 +1,12 @@
+diff -purN a/Makefile b/Makefile
+--- a/Makefile	2021-11-04 20:36:55.000000000 +0100
++++ b/Makefile	2022-01-10 14:35:17.333934039 +0100
+@@ -18,7 +18,7 @@ EXTRA_CFLAGS += -Wno-unused-label
+ EXTRA_CFLAGS += -Wno-unused-parameter
+ EXTRA_CFLAGS += -Wno-unused-function
+ EXTRA_CFLAGS += -Wno-unused
+-EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE
++#EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE

When patching out unused code, don't comment it; just remove it.

Can you fix those two issues and resubmit, plese?

Regards,
Yann E. MORIN.

Quoted 30 lines
package/rtl8723bu/0001-disable_concurent_mode.patch new file +2 -0
+ ccflags-y += -D__CHECK_ENDIAN__
+
package/rtl8723bu/rtl8723bu.hash +1 -1
index 04bc776a07..df990a8d63 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256  4c7314dccebda1e55ec8dcf0d5ca8915c2490d17a9f56923f25e6e0e945c10cc  rtl8723bu-9ce1c38439f4f574bb7adaf33949835c25536a28.tar.gz
+sha256  c9cde757941c88c6117560a2c350dc9c4382dcd6a313b1cae7c6e7eade7055bf  rtl8723bu-d34603a39a7c925d810fe17c6e8dea5063d43a33.tar.gz
package/rtl8723bu/rtl8723bu.mk +1 -1
index c35fad5832..e73987cfeb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RTL8723BU_VERSION = 9ce1c38439f4f574bb7adaf33949835c25536a28
+RTL8723BU_VERSION = d34603a39a7c925d810fe17c6e8dea5063d43a33
 RTL8723BU_SITE = $(call github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
 RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#2 lore raw

Yann E.,All

Quoted 1 line

When patching out unused code, don't comment it; just remove it.

I just followed the README.md, but no problem i'll change that.
- Step 2: Find the line that contains EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE and insert a # symbol at the beginning of that line. This comments that line and disables concurrent mode.

PS:
Is there something wrong with the mailing list ?
I have not received any mails for a week now.

Regards,
Michael Fischer

Quoted 99 lines

-----Ursprüngliche Nachricht-----
Von: Yann E. MORIN [mailto:[email protected]]
Gesendet: Montag, 10. Januar 2022 16:58
An: Michael Fischer <[email protected]>
Cc: [email protected]
Betreff: Re: [Buildroot] [PATCH 1/1] package/rtl8723bu: bump version to d34603a39a7c925d810fe17c6e8dea5063d43a33

Michael, All,

On 2022-01-10 16:13 +0100, Michael Fischer spake thusly:

Quoted 1 line

patch 0001: Disable concurrrent mode. This causes disconnections.

That patch is missing a commit log and a sign-off for itself:

    # ./utils/check-package package/rtl8723bu/0001-
disable_concurent_mode.patch
    package/rtl8723bu/0001-disable_concurent_mode.patch:0: missing Signed-
off-by in the header

(http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)

But see below...

Quoted 15 lines
Signed-off-by Michael Fischer <[email protected]>
---
 package/rtl8723bu/0001-disable_concurent_mode.patch | 12 ++++++++++++
 package/rtl8723bu/rtl8723bu.hash                    |  2 +-
 package/rtl8723bu/rtl8723bu.mk                      |  2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)  create mode 100644

package/rtl8723bu/0001-disable_concurent_mode.patch

package/rtl8723bu/0001-disable_concurent_mode.patch new file +0 -0
new file mode 100644
index 0000000000..037b1642fc

package/rtl8723bu/0001-disable_concurent_mode.patch line 4

Quoted 4 lines
package/rtl8723bu/0001-disable_concurent_mode.patch new file +4 -0
@@ -0,0 +1,12 @@
+diff -purN a/Makefile b/Makefile
+--- a/Makefile	2021-11-04 20:36:55.000000000 +0100
++++ b/Makefile	2022-01-10 14:35:17.333934039 +0100
+@@ -18,7 +18,7 @@ EXTRA_CFLAGS += -Wno-unused-label  EXTRA_CFLAGS

+=
> +-Wno-unused-parameter  EXTRA_CFLAGS += -Wno-unused-function

package/rtl8723bu/0001-disable_concurent_mode.patch line 5

Quoted 1 line
package/rtl8723bu/0001-disable_concurent_mode.patch new file +1 -0
+EXTRA_CFLAGS += -Wno-unused -EXTRA_CFLAGS += -

DCONFIG_CONCURRENT_MODE

package/rtl8723bu/0001-disable_concurent_mode.patch line 9

Quoted 1 line
package/rtl8723bu/0001-disable_concurent_mode.patch new file +1 -0
++#EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE

When patching out unused code, don't comment it; just remove it.

Can you fix those two issues and resubmit, plese?

Regards,
Yann E. MORIN.

Quoted 20 lines
package/rtl8723bu/0001-disable_concurent_mode.patch new file +2 -0
+ ccflags-y += -D__CHECK_ENDIAN__
+
package/rtl8723bu/rtl8723bu.hash +0 -1
index 04bc776a07..df990a8d63 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256

4c7314dccebda1e55ec8dcf0d5ca8915c2490d17a9f56923f25e6e0e945c10cc rtl8723bu-9ce1c38439f4f574bb7adaf33949835c25536a28.tar.gz

package/rtl8723bu/rtl8723bu.hash +3 -0
+sha256
+c9cde757941c88c6117560a2c350dc9c4382dcd6a313b1cae7c6e7eade7055bf
+rtl8723bu-d34603a39a7c925d810fe17c6e8dea5063d43a33.tar.gz
(quoted diff) +0 -0

b/package/rtl8723bu/rtl8723bu.mk index c35fad5832..e73987cfeb 100644

package/rtl8723bu/rtl8723bu.mk line 6

Quoted 3 lines
package/rtl8723bu/rtl8723bu.mk +0 -0
@@ -4,7 +4,7 @@
 #

################################################################
######

Quoted 8 lines
package/rtl8723bu/rtl8723bu.mk +1 -1
 ##########
 
-RTL8723BU_VERSION = 9ce1c38439f4f574bb7adaf33949835c25536a28
+RTL8723BU_VERSION = d34603a39a7c925d810fe17c6e8dea5063d43a33
 RTL8723BU_SITE = $(call

github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)

Quoted 7 lines

--
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

Quoted 8 lines
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
| conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot