Skip to contentSkip to conversation

Revert "net: vertexcom: default to disabled on kbuild"

PATCH Applied Saeed Mahameed 3 participants 4 messages Jan 10, 2022 – Jan 11, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "net: vertexcom: default to disabled on kbuild"

From: Saeed Mahameed <[email protected]>

This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.

To align with other vendors, NET_VENDOR configs are supposed to be ON by default, while their drivers should default to OFF.

---
 drivers/net/ethernet/vertexcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/vertexcom/Kconfig +1 -1
index 6e2cf062ddba..4184a635fe01 100644
@@ -5,7 +5,7 @@
 
 config NET_VENDOR_VERTEXCOM
 	bool "Vertexcom devices"
-	default n
+	default y
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 6 lines · On Mon, 10 Jan 2022 12:52:46 -0800 Saeed Mahameed wrote:

From: Saeed Mahameed <[email protected]>

This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.

To align with other vendors, NET_VENDOR configs are supposed to be ON by default, while their drivers should default to OFF.

Still planning to rework everything to default to 'n' in net-next later or did you change your mind? :)

#3 lore raw
In reply to Saeed Mahameed
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 10 Jan 2022 12:52:46 -0800 you wrote:

From: Saeed Mahameed <[email protected]>

This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.

To align with other vendors, NET_VENDOR configs are supposed to be ON by default, while their drivers should default to OFF.

[...]

Here is the summary with links:
- [net-next] Revert "net: vertexcom: default to disabled on kbuild"

    https://git.kernel.org/netdev/net/c/7d6019b602de

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#2 lore raw
In reply to Jakub Kicinski
Quoted 10 lines · Jakub Kicinski
Quoted 6 lines · On Mon, 10 Jan 2022 12:52:46 -0800 Saeed Mahameed wrote:

From: Saeed Mahameed <[email protected]>

This reverts commit 6bf950a8ff72920340dfdec93c18bd3f5f35de6a.

To align with other vendors, NET_VENDOR configs are supposed to be ON by default, while their drivers should default to OFF.

Still planning to rework everything to default to 'n' in net-next later or did you change your mind? :)

absolutely, I wouldn't miss any chance to write a sed regex to make a major patch for me ;), I am just waiting for the next release.