softmmu/device_tree: Remove redundant pointer assignment
PATCH 1/1 softmmu/device_tree: Remove redundant pointer assignment
The pointer assignment "const char *p = path;" in function qemu_fdt_add_path is unnecessary. Let's remove it and just use the "path" passed in. No functional change.
---
Based on: softmmu/device_tree: Silence compiler warning with --enable-sanitizers
https://patchew.org/QEMU/[email protected]/
--- softmmu/device_tree.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
softmmu/device_tree.c +4 -5
@@ -556,7 +556,6 @@ int qemu_fdt_add_subnode(void *fdt, const char *name)int qemu_fdt_add_path (void *fdt,const char *path) {const char *name; -const char *p = path;int namelen, retval;int parent =0 ;
@@ -565,9 +564,9 @@ int qemu_fdt_add_path(void *fdt, const char *path) } do { - name = p + 1; - p = strchr(name, '/'); - namelen = p != NULL ? p - name : strlen(name); + name = path + 1; + path = strchr(name, '/'); + namelen = path != NULL ? path - name : strlen(name); retval = fdt_subnode_offset_namelen(fdt, parent, name, namelen); if (retval < 0 && retval != -FDT_ERR_NOTFOUND) {
@@ -584,7 +583,7 @@ int qemu_fdt_add_path(void *fdt, const char *path) } parent = retval; - }while (p); + }while (path);return retval; }
Signature · 1 line
2.27.0
Quoted 50 lines · Yanan Wang
The pointer assignment "const char *p = path;" in function
qemu_fdt_add_pathis unnecessary. Let's remove it and just use the "path" passed in. No functional change.Suggested-by Richard Henderson <[email protected]>Signed-off-by Yanan Wang <[email protected]>---
Based on: softmmu/device_tree: Silence compiler warning with --enable-sanitizers
https://patchew.org/QEMU/[email protected]/--- softmmu/device_tree.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)softmmu/device_tree.c +4
-5@@ -556,7 +556,6 @@ int qemu_fdt_add_subnode(void *fdt, const char *name)int qemu_fdt_add_path (void *fdt,const char *path) {const char *name; -const char *p = path;int namelen, retval;int parent =0 ;@@ -565,9 +564,9 @@ int qemu_fdt_add_path(void *fdt, const char *path) } do { - name = p + 1; - p = strchr(name, '/'); - namelen = p != NULL ? p - name : strlen(name); + name = path + 1; + path = strchr(name, '/'); + namelen = path != NULL ? path - name : strlen(name); retval = fdt_subnode_offset_namelen(fdt, parent, name, namelen); if (retval < 0 && retval != -FDT_ERR_NOTFOUND) {@@ -584,7 +583,7 @@ int qemu_fdt_add_path(void *fdt, const char *path) } parent = retval; - }while (p); + }while (path);return retval; }Signature · 1 line
2.27.0
Quoted 7 lines · Yanan Wang via
The pointer assignment "const char *p = path;" in function
qemu_fdt_add_pathis unnecessary. Let's remove it and just use the "path" passed in. No functional change.Suggested-by Richard Henderson <[email protected]>Signed-off-by Yanan Wang <[email protected]>
Alistair
Quoted 45 lines
---
Based on: softmmu/device_tree: Silence compiler warning with --enable-sanitizers
https://patchew.org/QEMU/[email protected]/--- softmmu/device_tree.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)softmmu/device_tree.c +4
-6@@ -556,7 +556,6 @@ int qemu_fdt_add_subnode(void *fdt, const char *name)int qemu_fdt_add_path (void *fdt,const char *path) {const char *name; -const char *p = path;int namelen, retval;int parent =0 ;@@ -565,9 +564,9 @@ int qemu_fdt_add_path(void *fdt, const char *path) } do { - name = p + 1; - p = strchr(name, '/'); - namelen = p != NULL ? p - name : strlen(name); + name = path + 1; + path = strchr(name, '/'); + namelen = path != NULL ? path - name : strlen(name); retval = fdt_subnode_offset_namelen(fdt, parent, name, namelen); if (retval < 0 && retval != -FDT_ERR_NOTFOUND) {@@ -584,7 +583,7 @@ int qemu_fdt_add_path(void *fdt, const char *path) } parent = retval; - }while (p); + }while (path);return retval; } --2.27.0
Quoted 4 lines · Yanan Wang
The pointer assignment "const char *p = path;" in function
qemu_fdt_add_pathis unnecessary. Let's remove it and just use the "path" passed in. No functional change.
Quoted 8 lines
Suggested-by Richard Henderson <[email protected]>Signed-off-by Yanan Wang <[email protected]>---
Based on: softmmu/device_tree: Silence compiler warning with --enable-sanitizers
https://patchew.org/QEMU/[email protected]/--- softmmu/device_tree.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
Alistair Francis
AppliedQuoted 7 lines · Yanan Wang via
The pointer assignment "const char *p = path;" in function
qemu_fdt_add_pathis unnecessary. Let's remove it and just use the "path" passed in. No functional change.Suggested-by Richard Henderson <[email protected]>Signed-off-by Yanan Wang <[email protected]>
Thanks!
Applied to riscv-to-apply.next
Alistair
Quoted 45 lines
---
Based on: softmmu/device_tree: Silence compiler warning with --enable-sanitizers
https://patchew.org/QEMU/[email protected]/--- softmmu/device_tree.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)softmmu/device_tree.c +4
-6@@ -556,7 +556,6 @@ int qemu_fdt_add_subnode(void *fdt, const char *name)int qemu_fdt_add_path (void *fdt,const char *path) {const char *name; -const char *p = path;int namelen, retval;int parent =0 ;@@ -565,9 +564,9 @@ int qemu_fdt_add_path(void *fdt, const char *path) } do { - name = p + 1; - p = strchr(name, '/'); - namelen = p != NULL ? p - name : strlen(name); + name = path + 1; + path = strchr(name, '/'); + namelen = path != NULL ? path - name : strlen(name); retval = fdt_subnode_offset_namelen(fdt, parent, name, namelen); if (retval < 0 && retval != -FDT_ERR_NOTFOUND) {@@ -584,7 +583,7 @@ int qemu_fdt_add_path(void *fdt, const char *path) } parent = retval; - }while (p); + }while (path);return retval; } --2.27.0