dt-bindings: display: Turn lvds.yaml into a generic schema
Subsystems (6)
PATCH v3 1/2 dt-bindings: display: Turn lvds.yaml into a generic schema
The lvds.yaml file so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding.
That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it further.
However, this situation makes it fairly hard to extend and reuse both the generic parts, and the panel-lvds itself.
Let's remove the panel-lvds parts and leave only the generic LVDS properties.
---
Changes from v2:
- Fix references to that file
Changes from v1:
- Moved the schema out of panel
---
.../bindings/display/bridge/lvds-codec.yaml | 2 +-
.../bindings/display/{panel => }/lvds.yaml | 31 ++-----------------
.../display/panel/advantech,idk-1110wr.yaml | 19 ++++++++++--
.../display/panel/innolux,ee101ia-01d.yaml | 23 ++++++++++++--
.../display/panel/mitsubishi,aa104xd12.yaml | 19 ++++++++++--
.../display/panel/mitsubishi,aa121td01.yaml | 19 ++++++++++--
.../display/panel/sgd,gktw70sdae4se.yaml | 19 ++++++++++--
MAINTAINERS | 2 +-
8 files changed, 93 insertions(+), 41 deletions(-)
rename Documentation/devicetree/bindings/display/{panel => }/lvds.yaml (86%)Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +1 -1
@@ -67,7 +67,7 @@ properties: - vesa-24 description: | The color signals mapping order. See details in - Documentation/devicetree/bindings/display/panel/lvds.yaml + Documentation/devicetree/bindings/display/lvds.yaml port@1: $ref: /schemas/graph.yaml#/properties/port
Documentation/devicetree/bindings/display/lvds.yaml renamed from Documentation/devicetree/bindings/display/panel/lvds.yaml +2 -29
@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 %YAML 1.2 --- -$id: http://devicetree.org/schemas/display/panel/lvds.yaml# +$id: http://devicetree.org/schemas/display/lvds.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: LVDS Display Panel +title: LVDS Display Common Properties maintainers: - Laurent Pinchart <[email protected]>
@@ -26,18 +26,7 @@ description: |+ Device compatible with those specifications have been marketed under the FPD-Link and FlatLink brands. -allOf: - - $ref: panel-common.yaml# - properties: - compatible: - contains: - const: panel-lvds - description: - Shall contain "panel-lvds" in addition to a mandatory panel-specific - compatible string defined in individual panel bindings. The "panel-lvds" - value shall never be used on its own. - data-mapping: enum: - jeida-18
@@ -96,22 +85,6 @@ properties: If set, reverse the bit order described in the data mappings below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. - port: true - ports: true - -required: - - compatible - - data-mapping - - width-mm - - height-mm - - panel-timing - -oneOf: - - required: - - port - - required: - - ports - additionalProperties: true ...
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +17 -2
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: advantech,idk-1110wr + + required: + - compatible properties: compatible: items: - const: advantech,idk-1110wr - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-24
@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+
Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml +21 -2
@@ -11,15 +11,26 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: innolux,ee101ia-01d + + required: + - compatible properties: compatible: items: - const: innolux,ee101ia-01d - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds backlight: true + data-mapping: true enable-gpios: true power-supply: true width-mm: true
@@ -27,5 +38,13 @@ properties: panel-timing: true port: true +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + additionalProperties: false ...
Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml +17 -2
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: mitsubishi,aa104xd12 + + required: + - compatible properties: compatible: items: - const: mitsubishi,aa104xd12 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.
@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+
Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml +17 -2
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: mitsubishi,aa121td01 + + required: + - compatible properties: compatible: items: - const: mitsubishi,aa121td01 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.
@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+
Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml +17 -2
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: sgd,gktw70sdae4se + + required: + - compatible properties: compatible: items: - const: sgd,gktw70sdae4se - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-18
@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - port + - data-mapping + - width-mm + - height-mm + - panel-timing examples: - |+
MAINTAINERS +1 -1
@@ -6079,7 +6079,7 @@ L: [email protected] T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/panel/panel-lvds.c -F: Documentation/devicetree/bindings/display/panel/lvds.yaml +F: Documentation/devicetree/bindings/display/lvds.yaml DRM DRIVER FOR MANTIX MLAF057WE51 PANELS M: Guido Günther <[email protected]>
Signature · 1 line
2.34.1
PATCH v3 2/2 dt-bindings: panel: Introduce a panel-lvds binding
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
---
Changes from v2:
- Added a MAINTAINERS entry
Changes from v1:
- Added missing compatible
- Fixed lint
--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +57 -0
@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not: + properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4se + + required: + - compatible + +properties: + compatible: + items: + - enum: + - auo,b101ew05 + - tbs,a711-panel + + - const: panel-lvds + +unevaluatedProperties: false + +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + +...
MAINTAINERS +1 -0
@@ -6080,6 +6080,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/panel/panel-lvds.c F: Documentation/devicetree/bindings/display/lvds.yaml +F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml DRM DRIVER FOR MANTIX MLAF057WE51 PANELS M: Guido Günther <[email protected]>
Signature · 1 line
2.34.1
Laurent Pinchart
maintainerRe: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Hi Maxime,
Thank you for the patch.
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4se
I still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panel
?
Quoted 36 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +24
-0+ + required: + - compatible + +properties: + compatible: + items: + - enum: + - auo,b101ew05 + - tbs,a711-panel + + - const: panel-lvds + +unevaluatedProperties: false + +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + +...MAINTAINERS +1
-0@@ -6080,6 +6080,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/panel/panel-lvds.c F: Documentation/devicetree/bindings/display/lvds.yaml +F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml DRM DRIVER FOR MANTIX MLAF057WE51 PANELS M: Guido Günther <[email protected]>
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Hi Laurent,
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panel
Quoted 1 line
?
That works too, I'll send another version.
Maxime
Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Quoted 75 lines · Maxime Ripard
Hi Laurent,
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panel
Quoted 3 lines
Quoted 1 line
?
That works too, I'll send another version.
Actually, no, it doesn't work.
If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error.
I'll merge this version (together with the v4 version of patch 1)
Maxime
Laurent Pinchart
maintainerRe: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Hi Maxime,
Quoted 78 lines · Maxime Ripard
Quoted 73 lines · Maxime Ripard
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panelQuoted 3 lines
Quoted 1 line
?
That works too, I'll send another version.
Quoted 7 lines
Actually, no, it doesn't work.
If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error.
I'll merge this version (together with the v4 version of patch 1)
I'm sorry but I *really* *really* dislike this. Having to list all other compatible values in this file is a sign that something is wrong in the validation infrastructure. People will forget to update it when adding new bindings, and will get confused by the result. If I were a maintainer for DT bindings I'd nack this.
If a DT has panel-lvds and no other compatible string, or invalid ones, won't the validation report that the compatible isn't understood ? I think that would be enough.
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Quoted 85 lines · Laurent Pinchart
Quoted 84 lines · Maxime Ripard
Quoted 73 lines · Maxime Ripard
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panelQuoted 3 lines
Quoted 1 line
?
That works too, I'll send another version.
Actually, no, it doesn't work.
If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error.
Quoted 7 lines
Quoted 1 line
I'll merge this version (together with the v4 version of patch 1)
I'm sorry but I *really* *really* dislike this. Having to list all other compatible values in this file is a sign that something is wrong in the validation infrastructure. People will forget to update it when adding new bindings, and will get confused by the result. If I were a maintainer for DT bindings I'd nack this.
The validation infrastructure is what it is, and we can't change that. Rewriting one from scratch isn't reasonable either. That being said, the *only* case where this has been a problem are the panels because there's so many pointless schemas which should really be a single schema.
That's the root cause.
I tried to merge all of them, but once again panels seem to be special, and it was shot down. So be it. But at the end of the day, there's not a lot of solutions to do what we are doing for every other case out there.
Quoted 3 lines
If a DT has panel-lvds and no other compatible string, or invalid ones, won't the validation report that the compatible isn't understood ? I think that would be enough.
That's just worse. How would you not get confused if there's an error that the compatible isn't documented, you search for it, and it's actually documented there?
We really have two solutions:
- Either we merge all the panel-lvds schemas in one,
- Or we have this.
The first was shot down, only the latter remains.
Maxime
Laurent Pinchart
maintainerRe: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Quoted 105 lines · Maxime Ripard
Quoted 85 lines · Laurent Pinchart
Quoted 84 lines · Maxime Ripard
Quoted 73 lines · Maxime Ripard
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panelQuoted 3 lines
Quoted 1 line
?
That works too, I'll send another version.
Actually, no, it doesn't work.
If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error.
Quoted 7 lines
Quoted 1 line
I'll merge this version (together with the v4 version of patch 1)
I'm sorry but I *really* *really* dislike this. Having to list all other compatible values in this file is a sign that something is wrong in the validation infrastructure. People will forget to update it when adding new bindings, and will get confused by the result. If I were a maintainer for DT bindings I'd nack this.
The validation infrastructure is what it is, and we can't change that. Rewriting one from scratch isn't reasonable either. That being said, the *only* case where this has been a problem are the panels because there's so many pointless schemas which should really be a single schema.
That's the root cause.
I tried to merge all of them, but once again panels seem to be special, and it was shot down. So be it. But at the end of the day, there's not a lot of solutions to do what we are doing for every other case out there.
Quoted 7 lines
Quoted 3 lines
If a DT has panel-lvds and no other compatible string, or invalid ones, won't the validation report that the compatible isn't understood ? I think that would be enough.
That's just worse. How would you not get confused if there's an error that the compatible isn't documented, you search for it, and it's actually documented there?
Is that any different than a binding that would have
properties:
compatible:
items:
enum:
- foo,bar
- foo,baz
const: foo,base
and a device tree that would set compatible = "foo,base"; ? This type of binding is very common, and I haven't heard anyone complaining that the resulting validation error is an issue.
Quoted 7 lines
We really have two solutions:
- Either we merge all the panel-lvds schemas in one,
- Or we have this.
The first was shot down, only the latter remains.
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Quoted 124 lines · Laurent Pinchart
Quoted 105 lines · Maxime Ripard
Quoted 85 lines · Laurent Pinchart
Quoted 84 lines · Maxime Ripard
Quoted 73 lines · Maxime Ripard
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panelQuoted 3 lines
Quoted 1 line
?
That works too, I'll send another version.
Actually, no, it doesn't work.
If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error.
Quoted 7 lines
Quoted 1 line
I'll merge this version (together with the v4 version of patch 1)
I'm sorry but I *really* *really* dislike this. Having to list all other compatible values in this file is a sign that something is wrong in the validation infrastructure. People will forget to update it when adding new bindings, and will get confused by the result. If I were a maintainer for DT bindings I'd nack this.
The validation infrastructure is what it is, and we can't change that. Rewriting one from scratch isn't reasonable either. That being said, the *only* case where this has been a problem are the panels because there's so many pointless schemas which should really be a single schema.
That's the root cause.
I tried to merge all of them, but once again panels seem to be special, and it was shot down. So be it. But at the end of the day, there's not a lot of solutions to do what we are doing for every other case out there.
Quoted 7 lines
Quoted 3 lines
If a DT has panel-lvds and no other compatible string, or invalid ones, won't the validation report that the compatible isn't understood ? I think that would be enough.
That's just worse. How would you not get confused if there's an error that the compatible isn't documented, you search for it, and it's actually documented there?
Is that any different than a binding that would have
properties:
compatible:
items:
enum:
- foo,bar
- foo,baz
const: foo,base
Quoted 3 lines
and a device tree that would set compatible = "foo,base"; ? This type of binding is very common, and I haven't heard anyone complaining that the resulting validation error is an issue.
That works indeed, but it's not what panel-lvds is doing. For some reason, instead of that enum, we need multiple schemas, one for each combination. And this is why we need that select clause, to work around that decision.
Maxime
Laurent Pinchart
maintainerRe: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Quoted 125 lines · Maxime Ripard
Quoted 124 lines · Laurent Pinchart
Quoted 105 lines · Maxime Ripard
Quoted 85 lines · Laurent Pinchart
Quoted 84 lines · Maxime Ripard
Quoted 73 lines · Maxime Ripard
Quoted 72 lines · Laurent Pinchart
Quoted 50 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Added aMAINTAINERSentryChanges from v1:
- Added missing compatible
- Fixed lint--- .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +23
-0@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not:Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - advantech,idk-2121wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4seI still don't like this :-( Couldn't we instead do
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panelQuoted 3 lines
Quoted 1 line
?
That works too, I'll send another version.
Actually, no, it doesn't work.
If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error.
Quoted 7 lines
Quoted 1 line
I'll merge this version (together with the v4 version of patch 1)
I'm sorry but I *really* *really* dislike this. Having to list all other compatible values in this file is a sign that something is wrong in the validation infrastructure. People will forget to update it when adding new bindings, and will get confused by the result. If I were a maintainer for DT bindings I'd nack this.
The validation infrastructure is what it is, and we can't change that. Rewriting one from scratch isn't reasonable either. That being said, the *only* case where this has been a problem are the panels because there's so many pointless schemas which should really be a single schema.
That's the root cause.
I tried to merge all of them, but once again panels seem to be special, and it was shot down. So be it. But at the end of the day, there's not a lot of solutions to do what we are doing for every other case out there.
Quoted 7 lines
Quoted 3 lines
If a DT has panel-lvds and no other compatible string, or invalid ones, won't the validation report that the compatible isn't understood ? I think that would be enough.
That's just worse. How would you not get confused if there's an error that the compatible isn't documented, you search for it, and it's actually documented there?
Is that any different than a binding that would have
properties:
compatible:
items:
enum:
- foo,bar
- foo,baz
const: foo,base
Quoted 8 lines
Quoted 3 lines
and a device tree that would set compatible = "foo,base"; ? This type of binding is very common, and I haven't heard anyone complaining that the resulting validation error is an issue.
That works indeed, but it's not what panel-lvds is doing. For some reason, instead of that enum, we need multiple schemas, one for each combination. And this is why we need that select clause, to work around that decision.
I get that, but unless I'm mistaken, you concern with
select:
properties:
compatible:
contains:
enum:
- auo,b101ew05
- tbs,a711-panel
is that it will result in skipping validation silently (until all nodes are required to be validated) if a DT contains compatible = "aou,b101ew05", "panel-lvds". Don't we also get the same problem with compatible = "foo,bat", "foo,base" ? How do the two issues differ ?
Signature · 3 lines
Regards, Laurent Pinchart
Maxime Ripard
AppliedRe: (subset) [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding
In reply to Maxime RipardQuoted 5 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
Hi Maxime,
Thank you for the patch.
Documentation/devicetree/bindings/display/lvds.yaml description: |+
Quoted 69 lines · Maxime Ripard
The
lvds.yamlfile so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding.That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it further.
However, this situation makes it fairly hard to extend and reuse both the generic parts, and the panel-lvds itself.
Let's remove the panel-lvds parts and leave only the generic LVDS properties.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Changes from v2:
- Fix references to that fileChanges from v1:
- Moved the schema out of panel--- .../bindings/display/bridge/lvds-codec.yaml | 2 +- .../bindings/display/{panel => }/lvds.yaml | 31 ++----------------- .../display/panel/advantech,idk-1110wr.yaml | 19 ++++++++++-- .../display/panel/innolux,ee101ia-01d.yaml | 23 ++++++++++++-- .../display/panel/mitsubishi,aa104xd12.yaml | 19 ++++++++++-- .../display/panel/mitsubishi,aa121td01.yaml | 19 ++++++++++-- .../display/panel/sgd,gktw70sdae4se.yaml | 19 ++++++++++-- MAINTAINERS | 2 +- 8 files changed, 93 insertions(+), 41 deletions(-) rename Documentation/devicetree/bindings/display/{panel => }/lvds.yaml (86%)Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +1
-1@@ -67,7 +67,7 @@ properties: - vesa-24 description: | The color signals mapping order. See details in - Documentation/devicetree/bindings/display/panel/lvds.yaml + Documentation/devicetree/bindings/display/lvds.yaml port@1: $ref: /schemas/graph.yaml#/properties/portDocumentation/devicetree/bindings/display/lvds.yaml renamed from Documentation/devicetree/bindings/display/panel/lvds.yaml +2
-2@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 %YAML 1.2 --- -$id: http://devicetree.org/schemas/display/panel/lvds.yaml# +$id: http://devicetree.org/schemas/display/lvds.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: LVDS Display Panel +title: LVDS Display Common Properties maintainers: - Laurent Pinchart <[email protected]>@@ -26,18 +26,7 @@ description: |+
The description mentions "This bindings supports display panels compatible with the following specifications". This needs a small update to avoid referring to panels.
With this updated,
Quoted 269 lines
Documentation/devicetree/bindings/display/lvds.yaml renamed from Documentation/devicetree/bindings/display/panel/lvds.yaml +0
-27Device compatible with those specifications have been marketed under the FPD-Link and FlatLink brands. -allOf: - - $ref: panel-common.yaml# - properties: - compatible: - contains: - const: panel-lvds - description: - Shall contain "panel-lvds" in addition to a mandatory panel-specific - compatible string defined in individual panel bindings. The "panel-lvds" - value shall never be used on its own. - data-mapping: enum: - jeida-18@@ -96,22 +85,6 @@ properties: If set, reverse the bit order described in the data mappings below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. - port: true - ports: true - -required: - - compatible - - data-mapping - - width-mm - - height-mm - - panel-timing - -oneOf: - - required: - - port - - required: - - ports - additionalProperties: trueDocumentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +17
-2@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: advantech,idk-1110wr + + required: + - compatible properties: compatible: items: - const: advantech,idk-1110wr - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-24@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml +21
-2@@ -11,15 +11,26 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: innolux,ee101ia-01d + + required: + - compatible properties: compatible: items: - const: innolux,ee101ia-01d - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds backlight: true + data-mapping: true enable-gpios: true power-supply: true width-mm: true@@ -27,5 +38,13 @@ properties: panel-timing: true port: true +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + additionalProperties: falseDocumentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml +17
-2@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: mitsubishi,aa104xd12 + + required: + - compatible properties: compatible: items: - const: mitsubishi,aa104xd12 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml +17
-2@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: mitsubishi,aa121td01 + + required: + - compatible properties: compatible: items: - const: mitsubishi,aa121td01 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml +17
-2@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: - - $ref: lvds.yaml# + - $ref: panel-common.yaml# + - $ref: /schemas/display/lvds.yaml/# + +select: + properties: + compatible: + contains: + const: sgd,gktw70sdae4se + + required: + - compatible properties: compatible: items: - const: sgd,gktw70sdae4se - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-18@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - port + - data-mapping + - width-mm + - height-mm + - panel-timing examples: - |+MAINTAINERS +1
-1@@ -6079,7 +6079,7 @@ L: [email protected] T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/panel/panel-lvds.c -F: Documentation/devicetree/bindings/display/panel/lvds.yaml +F: Documentation/devicetree/bindings/display/lvds.yaml DRM DRIVER FOR MANTIX MLAF057WE51 PANELS M: Guido Günther <[email protected]>
Signature · 3 lines
Regards, Laurent Pinchart