Skip to contentSkip to conversation

habanalabs: Remove unused enum member DMA_SRAM_TO_SRAM

PATCH In review Cai Huoqing 3 participants 8 messages Jan 11, 2022 – Jan 23, 2022 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: Remove unused enum member DMA_SRAM_TO_SRAM

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
 	DMA_SRAM_TO_HOST,
 	DMA_DRAM_TO_HOST,
 	DMA_DRAM_TO_DRAM,
-	DMA_SRAM_TO_SRAM,
 	DMA_ENUM_MAX
 };
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 22 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -2
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
--
Quoted 2 lines

2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

In addition, I prefer to have this value present for completeness, even if the driver doesn't refer to it.

Oded

#2 lore raw
Quoted 22 lines · Oded Gabbay
Quoted 21 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
Quoted 9 lines
Quoted 3 lines

--
2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

If this is synced to userspace, shouldn't it be in a uapi file with a specific value associated with it?

thanks,

greg k-h

#3 lore raw
Quoted 34 lines · Greg Kroah-Hartman
Quoted 22 lines · Oded Gabbay
Quoted 21 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
Quoted 9 lines
Quoted 3 lines

--
2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

Quoted 6 lines

If this is synced to userspace, shouldn't it be in a uapi file with a specific value associated with it?

thanks,

greg k-h

Yes, it was a mistake from day 1. A mistake we didn't repeat in future ASICs. I take great care of putting anything that is synced between driver and userspace in our uapi file.

Having said that, after almost 3 years of having this mistake, I feel it is not too disastrous to leave it as is.
Our Goya s/w stack is pretty much stable and I don't want to make changes without good reason.

wdyt ?

Oded

#4 lore raw
Quoted 43 lines · Oded Gabbay
Quoted 34 lines · Greg Kroah-Hartman
Quoted 22 lines · Oded Gabbay
Quoted 21 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
Quoted 9 lines
Quoted 3 lines

--
2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

Quoted 6 lines

If this is synced to userspace, shouldn't it be in a uapi file with a specific value associated with it?

thanks,

greg k-h

Quoted 8 lines

Yes, it was a mistake from day 1. A mistake we didn't repeat in future ASICs. I take great care of putting anything that is synced between driver and userspace in our uapi file.

Having said that, after almost 3 years of having this mistake, I feel it is not too disastrous to leave it as is.
Our Goya s/w stack is pretty much stable and I don't want to make changes without good reason.

You should just move this to a uapi file to show that it is something that can't be changed. Can't you do that without breaking anything on the kernel side?

Otherwise maintaining this is going to be hard as no one has a clue that this is a value that userspace uses.

thanks,

greg k-h

#5 lore raw
Quoted 49 lines · Greg Kroah-Hartman
Quoted 47 lines · Oded Gabbay
Quoted 34 lines · Greg Kroah-Hartman
Quoted 22 lines · Oded Gabbay
Quoted 21 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
Quoted 9 lines
Quoted 3 lines

--
2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

Quoted 6 lines

If this is synced to userspace, shouldn't it be in a uapi file with a specific value associated with it?

thanks,

greg k-h

Yes, it was a mistake from day 1. A mistake we didn't repeat in future ASICs. I take great care of putting anything that is synced between driver and userspace in our uapi file.

Quoted 8 lines
Quoted 4 lines

Having said that, after almost 3 years of having this mistake, I feel it is not too disastrous to leave it as is.
Our Goya s/w stack is pretty much stable and I don't want to make changes without good reason.

You should just move this to a uapi file to show that it is something that can't be changed. Can't you do that without breaking anything on the kernel side?

On the kernel side there isn't any problem with moving it. What I'm afraid of, is that the userspace will now have a duplicate definition of this enum.
Both in the original file, which is included in the user space stack from day 1, and from our uapi file.
In short, I'm afraid of breaking its compilation.
If you think that's acceptable, I don't have a problem moving it.

Quoted 3 lines

Otherwise maintaining this is going to be hard as no one has a clue that this is a value that userspace uses.

I can document it with a BIG comment in the file.
And as I said, Goya s/w stack is pretty much fixed and I don't believe is going to change anymore.

Oded

Quoted 4 lines

thanks,

greg k-h

#6 lore raw
Quoted 68 lines · Oded Gabbay
Quoted 49 lines · Greg Kroah-Hartman
Quoted 47 lines · Oded Gabbay
Quoted 34 lines · Greg Kroah-Hartman
Quoted 22 lines · Oded Gabbay
Quoted 21 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
Quoted 9 lines
Quoted 3 lines

--
2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

Quoted 6 lines

If this is synced to userspace, shouldn't it be in a uapi file with a specific value associated with it?

thanks,

greg k-h

Yes, it was a mistake from day 1. A mistake we didn't repeat in future ASICs. I take great care of putting anything that is synced between driver and userspace in our uapi file.

Quoted 8 lines
Quoted 4 lines

Having said that, after almost 3 years of having this mistake, I feel it is not too disastrous to leave it as is.
Our Goya s/w stack is pretty much stable and I don't want to make changes without good reason.

You should just move this to a uapi file to show that it is something that can't be changed. Can't you do that without breaking anything on the kernel side?

On the kernel side there isn't any problem with moving it. What I'm afraid of, is that the userspace will now have a duplicate definition of this enum.
Both in the original file, which is included in the user space stack from day 1, and from our uapi file.
In short, I'm afraid of breaking its compilation.
If you think that's acceptable, I don't have a problem moving it.

Quoted 1 line
Quoted 6 lines
Quoted 2 lines

Otherwise maintaining this is going to be hard as no one has a clue that this is a value that userspace uses.

I can document it with a BIG comment in the file.
And as I said, Goya s/w stack is pretty much fixed and I don't believe is going to change anymore.

The trick is long-term maintaince for the next 20+ years of this code in the kernel. A huge comment would help, but even better to move this where it needs to go in a uapi file so that it makes it obvious we can not change this.

thanks,

greg k-h

#7 lore raw
Quoted 77 lines · Greg Kroah-Hartman
Quoted 68 lines · Oded Gabbay
Quoted 49 lines · Greg Kroah-Hartman
Quoted 47 lines · Oded Gabbay
Quoted 34 lines · Greg Kroah-Hartman
Quoted 22 lines · Oded Gabbay
Quoted 21 lines · Cai Huoqing

The driver don't support the SRAM-to-SRAM translation of DMA, so remove 'DMA_SRAM_TO_SRAM'.

---
 drivers/misc/habanalabs/include/goya/goya_packets.h | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/habanalabs/include/goya/goya_packets.h +0 -1
index ef54bad20509..25fbebdc6143 100644
@@ -36,7 +36,6 @@ enum goya_dma_direction {
        DMA_SRAM_TO_HOST,
        DMA_DRAM_TO_HOST,
        DMA_DRAM_TO_DRAM,
-       DMA_SRAM_TO_SRAM,
        DMA_ENUM_MAX
 };
 
Quoted 9 lines
Quoted 3 lines

--
2.25.1

This is a general spec file in our s/w stack, and therefore a change in it in the driver will cause our driver to be out of sync with our user-space stack. i.e. the value of DMA_ENUM_MAX will be different in the driver and in the user-space stack. I don't know if there will be any consequences but I prefer not to risk it.

Quoted 6 lines

If this is synced to userspace, shouldn't it be in a uapi file with a specific value associated with it?

thanks,

greg k-h

Yes, it was a mistake from day 1. A mistake we didn't repeat in future ASICs. I take great care of putting anything that is synced between driver and userspace in our uapi file.

Quoted 8 lines
Quoted 4 lines

Having said that, after almost 3 years of having this mistake, I feel it is not too disastrous to leave it as is.
Our Goya s/w stack is pretty much stable and I don't want to make changes without good reason.

You should just move this to a uapi file to show that it is something that can't be changed. Can't you do that without breaking anything on the kernel side?

On the kernel side there isn't any problem with moving it. What I'm afraid of, is that the userspace will now have a duplicate definition of this enum.
Both in the original file, which is included in the user space stack from day 1, and from our uapi file.
In short, I'm afraid of breaking its compilation.
If you think that's acceptable, I don't have a problem moving it.

Quoted 1 line
Quoted 6 lines
Quoted 2 lines

Otherwise maintaining this is going to be hard as no one has a clue that this is a value that userspace uses.

I can document it with a BIG comment in the file.
And as I said, Goya s/w stack is pretty much fixed and I don't believe is going to change anymore.

Quoted 8 lines

The trick is long-term maintaince for the next 20+ years of this code in the kernel. A huge comment would help, but even better to move this where it needs to go in a uapi file so that it makes it obvious we can not change this.

thanks,

greg k-h

ok, I'll try to do this internally and see what happens. I'll upstream either the change or a comment, depending on my check.

Oded