scsi: message: fusion: Fix returned errno code
Subsystems (2)
PATCH 1/1 scsi: message: fusion: Fix returned errno code
The callers of initChainBuffers() and PrimeIocFifos() only cares about gross success/failure, but we still might as well resolve the following smatch warnings and fix the other error paths as well:
drivers/message/fusion/mptbase.c:4330 initChainBuffers() warn: returning -1 instead of -ENOMEM is sloppy drivers/message/fusion/mptbase.c:4404 initChainBuffers() warn: returning -1 instead of -ENOMEM is sloppy
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
--- drivers/message/fusion/mptbase.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/message/fusion/mptbase.c +4 -4
@@ -4327,14 +4327,14 @@ initChainBuffers(MPT_ADAPTER *ioc) sz = ioc->req_depth *sizeof (int ); mem =kmalloc (sz,GFP_ATOMIC );if (mem ==NULL ) -return -1 ; +return -ENOMEM ; ioc->ReqToChain = (int *) mem;dinitprintk (ioc,printk (MYIOC_s_DEBUG_FMT"ReqToChain alloc @ %p, sz=%d bytes\n" , ioc->name, mem, sz)); mem =kmalloc (sz,GFP_ATOMIC );if (mem ==NULL ) -return -1 ; +return -ENOMEM ; ioc->RequestNB = (int *) mem; dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT "RequestNB alloc @ %p, sz=%d bytes\n",
@@ -4401,7 +4401,7 @@ initChainBuffers(MPT_ADAPTER *ioc)if (ioc->ChainToChain ==NULL ) { mem =kmalloc (sz,GFP_ATOMIC );if (mem ==NULL ) -return -1 ; +return -ENOMEM ; ioc->ChainToChain = (int *) mem; dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT "ChainToChain alloc @ %p, sz=%d bytes\n",
@@ -4440,7 +4440,7 @@ PrimeIocFifos(MPT_ADAPTER *ioc)if (ioc->reply_frames ==NULL ) {if ( (num_chain =initChainBuffers (ioc)) <0 ) -return -1 ; +return -ENOMEM ;/* * 1078 errata workaround for the 36GB limitation */
Signature · 1 line
2.20.1.7.g153144c