Skip to contentSkip to conversation

tune-cortexa72: Enable the crc extension by default for cortexa72

PATCH In review Kevin Hao 4 participants 8 messages Jan 12, 2022 – Jan 13, 2022

lore
Share & tools
lore

Kevin Hao

author
#0 lore raw

PATCH 1/1 tune-cortexa72: Enable the crc extension by default for cortexa72

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

---
 .../machine/include/arm/armv8a/tune-cortexa72.inc    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +6 -6
index 3651cf6e802b..4c9add32f5f5 100644
@@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
 ARMPKGARCH:tune-cortexa72-crc         = "cortexa72"
 ARMPKGARCH:tune-cortexa72-crc-crypto  = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
-TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72} crc"
-TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72}"
+TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto"
 BASE_LIB:tune-cortexa72            = "lib64"
 BASE_LIB:tune-cortexa72-crc        = "lib64"
 BASE_LIB:tune-cortexa72-crc-crypto = "lib64"
Signature · 1 line
2.31.1
#1 lore raw
Quoted 5 lines · Kevin Hao

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

this looks good. Is there a way to warn such users to migrate to better option ?

Quoted 40 lines
---
  .../machine/include/arm/armv8a/tune-cortexa72.inc    | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +6 -7
index 3651cf6e802b..4c9add32f5f5 100644
@@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
  ARMPKGARCH:tune-cortexa72             = "cortexa72"
  ARMPKGARCH:tune-cortexa72-crc         = "cortexa72"
  ARMPKGARCH:tune-cortexa72-crc-crypto  = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
-TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72} crc"
-TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72}"
+TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto"
  BASE_LIB:tune-cortexa72            = "lib64"
  BASE_LIB:tune-cortexa72-crc        = "lib64"
  BASE_LIB:tune-cortexa72-crc-crypto = "lib64"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480
Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 4 lines · Khem Raj

On 1/12/22 1:07 AM, Kevin Hao wrote:

Quoted 8 lines
Quoted 5 lines

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

this looks good. Is there a way to warn such users to migrate to better option ?

We could just remove the crc and when it breaks they'll look....

Quoted 44 lines
Quoted 25 lines
---
  .../machine/include/arm/armv8a/tune-cortexa72.inc    | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +0 -5
index 3651cf6e802b..4c9add32f5f5 100644
@@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
  ARMPKGARCH:tune-cortexa72             = "cortexa72"
  ARMPKGARCH:tune-cortexa72-crc         = "cortexa72"
  ARMPKGARCH:tune-cortexa72-crc-crypto  = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
-TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72} crc"
-TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"

meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" · line 21

Quoted 10 lines
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +6 -1
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72}"
+TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto"
  BASE_LIB:tune-cortexa72            = "lib64"
  BASE_LIB:tune-cortexa72-crc        = "lib64"
  BASE_LIB:tune-cortexa72-crc-crypto = "lib64"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160496): https://lists.openembedded.org/g/openembedded-core/message/160496
Mute This Topic: https://lists.openembedded.org/mt/88369540/3616920
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Acked-by on v1 1/1
#3 lore raw
In reply to Kevin Hao
Quoted 8 lines · Kevin Hao

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, A73, and almost all of the others listed. I can patch the rest.

Thanks,
Jon

Quoted 39 lines
---
 .../machine/include/arm/armv8a/tune-cortexa72.inc    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +6 -7
index 3651cf6e802b..4c9add32f5f5 100644
@@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
 ARMPKGARCH:tune-cortexa72-crc         = "cortexa72"
 ARMPKGARCH:tune-cortexa72-crc-crypto  = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
-TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72} crc"
-TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72}"
+TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto"
 BASE_LIB:tune-cortexa72            = "lib64"
 BASE_LIB:tune-cortexa72-crc        = "lib64"
 BASE_LIB:tune-cortexa72-crc-crypto = "lib64"
--

2.31.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480
Mute This Topic: https://lists.openembedded.org/mt/88369540/3616920
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw
Quoted 8 lines · Jon Mason
Quoted 7 lines · Kevin Hao

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

Quoted 6 lines
Quoted 1 line

From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, A73, and almost all of the others listed. I can patch the rest.

I did wonder if we should just drop the duplicate tune too. It will cause an error but it is an error that should be quickly/easily fixed...

Cheers,

Richard

#5 lore raw
Quoted 12 lines · Richard Purdie
Quoted 1 line · Jon Mason

On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <[email protected]>

Quoted 9 lines · wrote:
Quoted 8 lines

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

Quoted 8 lines
Quoted 4 lines

From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, A73, and almost all of the others listed. I can patch the rest.

I did wonder if we should just drop the duplicate tune too. It will cause an
error but it is an error that should be quickly/easily fixed...

I am good with that problem is only for bsp layers which support multiple releases with a single branch but I guess that’s something less of a concern for me

Quoted 18 lines

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#160501):
https://lists.openembedded.org/g/openembedded-core/message/160501
Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#6 lore raw
Quoted 24 lines · Khem Raj

[Please note: This e-mail is from an EXTERNAL e-mail address]

On Wed, Jan 12, 2022 at 1:58 PM Richard Purdie <
[email protected]> wrote:

On Wed, 2022-01-12 at 14:23 -0500, Jon Mason wrote:
> On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <[email protected]> wrote:
> >
> > The crc extension is optional for the ARMv8.0 but is mandatory for the > > cortexa72, so there is no reason not to enable it for the cortexa72 > > tune. With this change, the cortexa72-crc seems redundant. But we > > had better to keep it to be compatible with the BSP which already used > > that tune.
> >
> > Signed-off-by: Kevin Hao <[email protected]>
>
> Acked-by: Jon Mason <[email protected]>
>
> From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, > A73, and almost all of the others listed. I can patch the rest.

Quoted 8 lines

I did wonder if we should just drop the duplicate tune too. It will cause an
error but it is an error that should be quickly/easily fixed...

I am good with that problem is only for bsp layers which support multiple releases with a single branch but I guess that’s something less of a concern for me

OK, I will send a add-on patch to drop the cortexa72-crc tune.

Thanks,
Kevin

Quoted 19 lines


    Cheers,

    Richard


    -=-=-=-=-=-=-=-=-=-=-=-
    Links: You receive all messages sent to this group.
    View/Reply Online (#160501): https://lists.openembedded.org/g/
    openembedded-core/message/160501
    Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914
    Group Owner: [email protected]
    Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
    [email protected]]
    -=-=-=-=-=-=-=-=-=-=-=-
#7 lore raw
In reply to Jon Mason
Quoted 8 lines · Jon Mason
Quoted 7 lines · Kevin Hao

The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.

Quoted 6 lines
Quoted 1 line

From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, A73, and almost all of the others listed. I can patch the rest.

Looking over the other ARMv8.0 that we have tunes for, there are none that have CRC except A72 (which is now removed). And git blame shows I didn't add that (much to my relief). So please disregard my comment about about needing to make additional changes.

Thanks,
Jon

Quoted 45 lines

Thanks,
Jon

Quoted 39 lines
---
 .../machine/include/arm/armv8a/tune-cortexa72.inc    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +6 -7
index 3651cf6e802b..4c9add32f5f5 100644
@@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
 ARMPKGARCH:tune-cortexa72-crc         = "cortexa72"
 ARMPKGARCH:tune-cortexa72-crc-crypto  = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
-TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72} crc"
-TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crc      = "${TUNE_FEATURES:tune-cortexa72}"
+TUNE_FEATURES:tune-cortexa72-crc-crypto   = "${TUNE_FEATURES:tune-cortexa72} crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72        = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto"
 BASE_LIB:tune-cortexa72            = "lib64"
 BASE_LIB:tune-cortexa72-crc        = "lib64"
 BASE_LIB:tune-cortexa72-crc-crypto = "lib64"
--

2.31.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480
Mute This Topic: https://lists.openembedded.org/mt/88369540/3616920
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-